e190a0c389
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Alain Volmat <alain.volmat@foss.st.com> Acked-by: Ard Biesheuvel <ardb@kernel.org> Acked-by: Baruch Siach <baruch@tkos.co.il> Acked-by: Florian Fainelli <f.fainelli@gmail.com> Acked-by: Heiko Stuebner <heiko@sntech.de> Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Acked-by: Jochen Friedrich <jochen@scram.de> Acked-by: Peter Rosin <peda@axentia.se> Acked-by: Vadim Pasternak <vadimp@nvidia.com> Reviewed-by: Asmaa Mnebhi <asnaa@nvidia.com> Reviewed-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz> Reviewed-by: Chris Pringle <chris.pringle@phabrix.com> Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Jean Delvare <jdelvare@suse.de> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com> Reviewed-by: Tali Perry <tali.perry@nuvoton.com> Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com> Signed-off-by: Wolfram Sang <wsa@kernel.org>
137 lines
3.1 KiB
C
137 lines
3.1 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* i2c-versatile.c
|
|
*
|
|
* Copyright (C) 2006 ARM Ltd.
|
|
* written by Russell King, Deep Blue Solutions Ltd.
|
|
*/
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/i2c.h>
|
|
#include <linux/i2c-algo-bit.h>
|
|
#include <linux/init.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/io.h>
|
|
|
|
#define I2C_CONTROL 0x00
|
|
#define I2C_CONTROLS 0x00
|
|
#define I2C_CONTROLC 0x04
|
|
#define SCL (1 << 0)
|
|
#define SDA (1 << 1)
|
|
|
|
struct i2c_versatile {
|
|
struct i2c_adapter adap;
|
|
struct i2c_algo_bit_data algo;
|
|
void __iomem *base;
|
|
};
|
|
|
|
static void i2c_versatile_setsda(void *data, int state)
|
|
{
|
|
struct i2c_versatile *i2c = data;
|
|
|
|
writel(SDA, i2c->base + (state ? I2C_CONTROLS : I2C_CONTROLC));
|
|
}
|
|
|
|
static void i2c_versatile_setscl(void *data, int state)
|
|
{
|
|
struct i2c_versatile *i2c = data;
|
|
|
|
writel(SCL, i2c->base + (state ? I2C_CONTROLS : I2C_CONTROLC));
|
|
}
|
|
|
|
static int i2c_versatile_getsda(void *data)
|
|
{
|
|
struct i2c_versatile *i2c = data;
|
|
return !!(readl(i2c->base + I2C_CONTROL) & SDA);
|
|
}
|
|
|
|
static int i2c_versatile_getscl(void *data)
|
|
{
|
|
struct i2c_versatile *i2c = data;
|
|
return !!(readl(i2c->base + I2C_CONTROL) & SCL);
|
|
}
|
|
|
|
static const struct i2c_algo_bit_data i2c_versatile_algo = {
|
|
.setsda = i2c_versatile_setsda,
|
|
.setscl = i2c_versatile_setscl,
|
|
.getsda = i2c_versatile_getsda,
|
|
.getscl = i2c_versatile_getscl,
|
|
.udelay = 30,
|
|
.timeout = HZ,
|
|
};
|
|
|
|
static int i2c_versatile_probe(struct platform_device *dev)
|
|
{
|
|
struct i2c_versatile *i2c;
|
|
struct resource *r;
|
|
int ret;
|
|
|
|
i2c = devm_kzalloc(&dev->dev, sizeof(struct i2c_versatile), GFP_KERNEL);
|
|
if (!i2c)
|
|
return -ENOMEM;
|
|
|
|
r = platform_get_resource(dev, IORESOURCE_MEM, 0);
|
|
i2c->base = devm_ioremap_resource(&dev->dev, r);
|
|
if (IS_ERR(i2c->base))
|
|
return PTR_ERR(i2c->base);
|
|
|
|
writel(SCL | SDA, i2c->base + I2C_CONTROLS);
|
|
|
|
i2c->adap.owner = THIS_MODULE;
|
|
strscpy(i2c->adap.name, "Versatile I2C adapter", sizeof(i2c->adap.name));
|
|
i2c->adap.algo_data = &i2c->algo;
|
|
i2c->adap.dev.parent = &dev->dev;
|
|
i2c->adap.dev.of_node = dev->dev.of_node;
|
|
i2c->algo = i2c_versatile_algo;
|
|
i2c->algo.data = i2c;
|
|
|
|
i2c->adap.nr = dev->id;
|
|
ret = i2c_bit_add_numbered_bus(&i2c->adap);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
platform_set_drvdata(dev, i2c);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void i2c_versatile_remove(struct platform_device *dev)
|
|
{
|
|
struct i2c_versatile *i2c = platform_get_drvdata(dev);
|
|
|
|
i2c_del_adapter(&i2c->adap);
|
|
}
|
|
|
|
static const struct of_device_id i2c_versatile_match[] = {
|
|
{ .compatible = "arm,versatile-i2c", },
|
|
{},
|
|
};
|
|
MODULE_DEVICE_TABLE(of, i2c_versatile_match);
|
|
|
|
static struct platform_driver i2c_versatile_driver = {
|
|
.probe = i2c_versatile_probe,
|
|
.remove_new = i2c_versatile_remove,
|
|
.driver = {
|
|
.name = "versatile-i2c",
|
|
.of_match_table = i2c_versatile_match,
|
|
},
|
|
};
|
|
|
|
static int __init i2c_versatile_init(void)
|
|
{
|
|
return platform_driver_register(&i2c_versatile_driver);
|
|
}
|
|
|
|
static void __exit i2c_versatile_exit(void)
|
|
{
|
|
platform_driver_unregister(&i2c_versatile_driver);
|
|
}
|
|
|
|
subsys_initcall(i2c_versatile_init);
|
|
module_exit(i2c_versatile_exit);
|
|
|
|
MODULE_DESCRIPTION("ARM Versatile I2C bus driver");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_ALIAS("platform:versatile-i2c");
|