iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net/ipv6
History
Eric Dumazet 7170a97774 net: annotate accesses to sk->sk_incoming_cpu 
This socket field can be read and written by concurrent cpus.

Use READ_ONCE() and WRITE_ONCE() annotations to document this,
and avoid some compiler 'optimizations'.

KCSAN reported :

BUG: KCSAN: data-race in tcp_v4_rcv / tcp_v4_rcv

write to 0xffff88812220763c of 4 bytes by interrupt on cpu 0:
 sk_incoming_cpu_update include/net/sock.h:953 [inline]
 tcp_v4_rcv+0x1b3c/0x1bb0 net/ipv4/tcp_ipv4.c:1934
 ip_protocol_deliver_rcu+0x4d/0x420 net/ipv4/ip_input.c:204
 ip_local_deliver_finish+0x110/0x140 net/ipv4/ip_input.c:231
 NF_HOOK include/linux/netfilter.h:305 [inline]
 NF_HOOK include/linux/netfilter.h:299 [inline]
 ip_local_deliver+0x133/0x210 net/ipv4/ip_input.c:252
 dst_input include/net/dst.h:442 [inline]
 ip_rcv_finish+0x121/0x160 net/ipv4/ip_input.c:413
 NF_HOOK include/linux/netfilter.h:305 [inline]
 NF_HOOK include/linux/netfilter.h:299 [inline]
 ip_rcv+0x18f/0x1a0 net/ipv4/ip_input.c:523
 __netif_receive_skb_one_core+0xa7/0xe0 net/core/dev.c:5010
 __netif_receive_skb+0x37/0xf0 net/core/dev.c:5124
 process_backlog+0x1d3/0x420 net/core/dev.c:5955
 napi_poll net/core/dev.c:6392 [inline]
 net_rx_action+0x3ae/0xa90 net/core/dev.c:6460
 __do_softirq+0x115/0x33f kernel/softirq.c:292
 do_softirq_own_stack+0x2a/0x40 arch/x86/entry/entry_64.S:1082
 do_softirq.part.0+0x6b/0x80 kernel/softirq.c:337
 do_softirq kernel/softirq.c:329 [inline]
 __local_bh_enable_ip+0x76/0x80 kernel/softirq.c:189

read to 0xffff88812220763c of 4 bytes by interrupt on cpu 1:
 sk_incoming_cpu_update include/net/sock.h:952 [inline]
 tcp_v4_rcv+0x181a/0x1bb0 net/ipv4/tcp_ipv4.c:1934
 ip_protocol_deliver_rcu+0x4d/0x420 net/ipv4/ip_input.c:204
 ip_local_deliver_finish+0x110/0x140 net/ipv4/ip_input.c:231
 NF_HOOK include/linux/netfilter.h:305 [inline]
 NF_HOOK include/linux/netfilter.h:299 [inline]
 ip_local_deliver+0x133/0x210 net/ipv4/ip_input.c:252
 dst_input include/net/dst.h:442 [inline]
 ip_rcv_finish+0x121/0x160 net/ipv4/ip_input.c:413
 NF_HOOK include/linux/netfilter.h:305 [inline]
 NF_HOOK include/linux/netfilter.h:299 [inline]
 ip_rcv+0x18f/0x1a0 net/ipv4/ip_input.c:523
 __netif_receive_skb_one_core+0xa7/0xe0 net/core/dev.c:5010
 __netif_receive_skb+0x37/0xf0 net/core/dev.c:5124
 process_backlog+0x1d3/0x420 net/core/dev.c:5955
 napi_poll net/core/dev.c:6392 [inline]
 net_rx_action+0x3ae/0xa90 net/core/dev.c:6460
 __do_softirq+0x115/0x33f kernel/softirq.c:292
 run_ksoftirqd+0x46/0x60 kernel/softirq.c:603
 smpboot_thread_fn+0x37d/0x4a0 kernel/smpboot.c:165

Reported by Kernel Concurrency Sanitizer on:
CPU: 1 PID: 16 Comm: ksoftirqd/1 Not tainted 5.4.0-rc3+ #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-10-30 13:24:25 -07:00
..
ila
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
netfilter
netfilter: drop bridge nf reset from nf_reset
2019-10-01 18:42:15 +02:00
addrconf_core.c
ipv6: include <net/addrconf.h> for missing declarations
2019-10-22 15:17:03 -07:00
addrconf.c
Revert "blackhole_netdev: fix syzkaller reported issue"
2019-10-16 13:41:26 -04:00
addrlabel.c
netlink: make validation more configurable for future strictness
2019-04-27 17:07:21 -04:00
af_inet6.c
ipv6: use indirect call wrappers for {tcp, udpv6}_{recv, send}msg()
2019-07-03 13:51:54 -07:00
ah6.c
ipv6: Use ipv6_authlen for len
2019-07-11 14:43:25 -07:00
anycast.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
calipso.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13
2019-05-21 11:28:45 +02:00
datagram.c
udp: correct reuseport selection with connected sockets
2019-09-16 09:02:18 +02:00
esp6_offload.c
Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec-next
2019-07-05 15:01:15 -07:00
esp6.c
xfrm: remove get_mtu indirection from xfrm_type
2019-07-01 06:16:40 +02:00
exthdrs_core.c
ipv6: remove printk
2019-07-27 14:23:48 -07:00
exthdrs_offload.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
exthdrs.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
fib6_notifier.c
net: Add module reference to FIB notifiers
2017-09-01 20:33:42 -07:00
fib6_rules.c
ipv6: do not free rt if FIB_LOOKUP_NOREF is set on suppress rule
2019-09-26 09:34:25 +02:00
fou6.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
icmp.c
ipv6: icmp: allow flowlabel reflection in echo replies
2019-07-01 10:54:51 -07:00
inet6_connection_sock.c
ipv6: add priority parameter to ip6_xmit()
2019-09-27 12:05:02 +02:00
inet6_hashtables.c
net: annotate accesses to sk->sk_incoming_cpu
2019-10-30 13:24:25 -07:00
ip6_checksum.c
net: udp: fix handling of CHECKSUM_COMPLETE packets
2018-10-24 14:18:16 -07:00
ip6_fib.c
ipv6: fix a typo in fib6_rule_lookup()
2019-09-20 19:17:57 -07:00
ip6_flowlabel.c
ipv6: fix static key imbalance in fl_create()
2019-07-11 14:43:25 -07:00
ip6_gre.c
erspan: fix the tun_info options_len check for erspan
2019-10-29 17:36:42 -07:00
ip6_icmp.c
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
ip6_input.c
ipv6: drop incoming packets having a v4mapped source address
2019-10-03 11:40:21 -04:00
ip6_offload.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
ip6_offload.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
ip6_output.c
net: ensure correct skb->tstamp in various fragmenters
2019-10-18 10:02:37 -07:00
ip6_tunnel.c
ip6_tunnel: fix possible use-after-free on xmit
2019-07-26 14:17:44 -07:00
ip6_udp_tunnel.c
treewide: Add SPDX license identifier for more missed files
2019-05-21 10:50:45 +02:00
ip6_vti.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
ip6mr.c
ipmr: remove hard code cache_resolve_queue_len limit
2019-09-07 17:49:00 +02:00
ipcomp6.c
xfrm: remove type and offload_type map from xfrm_state_afinfo
2019-06-06 08:34:50 +02:00
ipv6_sockglue.c
SPDX update for 5.2-rc3, round 1
2019-05-31 08:34:32 -07:00
Kconfig
treewide: Add SPDX license identifier - Makefile/Kconfig
2019-05-21 10:50:46 +02:00
Makefile
xfrm: make xfrm modes builtin
2019-04-08 09:15:17 +02:00
mcast_snoop.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 343
2019-06-05 17:37:07 +02:00
mcast.c
mld: fix memory leak in mld_del_delrec()
2019-08-28 14:47:35 -07:00
mip6.c
xfrm: remove type and offload_type map from xfrm_state_afinfo
2019-06-06 08:34:50 +02:00
ndisc.c
net-ipv6-ndisc: add support for RFC7710 RA Captive Portal Identifier
2019-07-22 12:10:54 -07:00
netfilter.c
net: ensure correct skb->tstamp in various fragmenters
2019-10-18 10:02:37 -07:00
output_core.c
treewide: Add SPDX license identifier for missed files
2019-05-21 10:50:45 +02:00
ping.c
ipv6: Fix the link time qualifier of 'ping_v6_proc_exit_net()'
2019-09-12 11:20:33 +01:00
proc.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2019-06-07 11:00:14 -07:00
protocol.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
raw.c
netfilter: drop bridge nf reset from nf_reset
2019-10-01 18:42:15 +02:00
reassembly.c
inet: frags: re-introduce skb coalescing for local delivery
2019-08-08 15:55:10 -07:00
route.c
Revert "blackhole_netdev: fix syzkaller reported issue"
2019-10-16 13:41:26 -04:00
seg6_hmac.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
seg6_iptunnel.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
seg6_local.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
seg6.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
sit.c
sit: use dst_cache in ipip6_tunnel_xmit
2019-07-14 12:15:28 -07:00
syncookies.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
sysctl_net_ipv6.c
proc/sysctl: add shared variables for range check
2019-07-18 17:08:07 -07:00
tcp_ipv6.c
tcp: annotate tp->write_seq lockless reads
2019-10-13 10:13:08 -07:00
tcpv6_offload.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
tunnel6.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13
2019-05-21 11:28:45 +02:00
udp_impl.h
udp6: add missing rehash callback to udplite
2019-01-17 15:01:08 -08:00
udp_offload.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
udp.c
net: annotate accesses to sk->sk_incoming_cpu
2019-10-30 13:24:25 -07:00
udplite.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
xfrm6_input.c
net: use skb_sec_path helper in more places
2018-12-19 11:21:37 -08:00
xfrm6_output.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
xfrm6_policy.c
xfrm: remove decode_session indirection from afinfo_policy
2019-04-23 07:42:20 +02:00
xfrm6_protocol.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
xfrm6_state.c
xfrm: remove eth_proto value from xfrm_state_afinfo
2019-06-06 08:34:50 +02:00
xfrm6_tunnel.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 13
2019-05-21 11:28:45 +02:00