a9da824762
VMware high-bandwidth hypercalls take the RBP register as input. This
breaks basic frame pointer convention, as RBP should never be clobbered.
So frame pointer unwinding is broken for the instructions surrounding
the hypercalls. Fortunately this doesn't break live patching with
CONFIG_FRAME_POINTER, as it only unwinds from blocking tasks, and stack
traces from preempted tasks are already marked unreliable anyway.
However, for live patching with ORC, this could actually be a
theoretical problem if vmw_port_hb_{in,out}() were still compiled with a
frame pointer due to having an aligned stack. In practice that hasn't
seemed to be an issue since the objtool warnings have only been seen
with CONFIG_FRAME_POINTER.
Add unwind hint annotations to tell the ORC unwinder to mark stack
traces as unreliable.
Fixes the following warnings:
vmlinux.o: warning: objtool: vmw_port_hb_in+0x1df: return with modified stack frame
vmlinux.o: warning: objtool: vmw_port_hb_out+0x1dd: return with modified stack frame
Fixes: 89da76fde68d ("drm/vmwgfx: Add VMWare host messaging capability")
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202305160135.97q0Elax-lkp@intel.com/
Link: https://lore.kernel.org/r/4c795f2d87bc0391cf6543bcb224fa540b55ce4b.1685981486.git.jpoimboe@kernel.org
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
228 lines
7.6 KiB
C
228 lines
7.6 KiB
C
/* SPDX-License-Identifier: GPL-2.0+ OR MIT */
|
|
/**************************************************************************
|
|
*
|
|
* Copyright 2016-2021 VMware, Inc., Palo Alto, CA., USA
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the
|
|
* "Software"), to deal in the Software without restriction, including
|
|
* without limitation the rights to use, copy, modify, merge, publish,
|
|
* distribute, sub license, and/or sell copies of the Software, and to
|
|
* permit persons to whom the Software is furnished to do so, subject to
|
|
* the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the
|
|
* next paragraph) shall be included in all copies or substantial portions
|
|
* of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL
|
|
* THE COPYRIGHT HOLDERS, AUTHORS AND/OR ITS SUPPLIERS BE LIABLE FOR ANY CLAIM,
|
|
* DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
* OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
* USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
*
|
|
**************************************************************************
|
|
*
|
|
* Based on code from vmware.c and vmmouse.c.
|
|
* Author:
|
|
* Sinclair Yeh <syeh@vmware.com>
|
|
*/
|
|
#ifndef _VMWGFX_MSG_X86_H
|
|
#define _VMWGFX_MSG_X86_H
|
|
|
|
|
|
#if defined(__i386__) || defined(__x86_64__)
|
|
|
|
#include <asm/vmware.h>
|
|
|
|
/**
|
|
* Hypervisor-specific bi-directional communication channel. Should never
|
|
* execute on bare metal hardware. The caller must make sure to check for
|
|
* supported hypervisor before using these macros.
|
|
*
|
|
* The last two parameters are both input and output and must be initialized.
|
|
*
|
|
* @cmd: [IN] Message Cmd
|
|
* @in_ebx: [IN] Message Len, through EBX
|
|
* @in_si: [IN] Input argument through SI, set to 0 if not used
|
|
* @in_di: [IN] Input argument through DI, set ot 0 if not used
|
|
* @flags: [IN] hypercall flags + [channel id]
|
|
* @magic: [IN] hypervisor magic value
|
|
* @eax: [OUT] value of EAX register
|
|
* @ebx: [OUT] e.g. status from an HB message status command
|
|
* @ecx: [OUT] e.g. status from a non-HB message status command
|
|
* @edx: [OUT] e.g. channel id
|
|
* @si: [OUT]
|
|
* @di: [OUT]
|
|
*/
|
|
#define VMW_PORT(cmd, in_ebx, in_si, in_di, \
|
|
flags, magic, \
|
|
eax, ebx, ecx, edx, si, di) \
|
|
({ \
|
|
asm volatile (VMWARE_HYPERCALL : \
|
|
"=a"(eax), \
|
|
"=b"(ebx), \
|
|
"=c"(ecx), \
|
|
"=d"(edx), \
|
|
"=S"(si), \
|
|
"=D"(di) : \
|
|
"a"(magic), \
|
|
"b"(in_ebx), \
|
|
"c"(cmd), \
|
|
"d"(flags), \
|
|
"S"(in_si), \
|
|
"D"(in_di) : \
|
|
"memory"); \
|
|
})
|
|
|
|
|
|
/**
|
|
* Hypervisor-specific bi-directional communication channel. Should never
|
|
* execute on bare metal hardware. The caller must make sure to check for
|
|
* supported hypervisor before using these macros.
|
|
*
|
|
* The last 3 parameters are both input and output and must be initialized.
|
|
*
|
|
* @cmd: [IN] Message Cmd
|
|
* @in_ecx: [IN] Message Len, through ECX
|
|
* @in_si: [IN] Input argument through SI, set to 0 if not used
|
|
* @in_di: [IN] Input argument through DI, set to 0 if not used
|
|
* @flags: [IN] hypercall flags + [channel id]
|
|
* @magic: [IN] hypervisor magic value
|
|
* @bp: [IN]
|
|
* @eax: [OUT] value of EAX register
|
|
* @ebx: [OUT] e.g. status from an HB message status command
|
|
* @ecx: [OUT] e.g. status from a non-HB message status command
|
|
* @edx: [OUT] e.g. channel id
|
|
* @si: [OUT]
|
|
* @di: [OUT]
|
|
*/
|
|
#ifdef __x86_64__
|
|
|
|
#define VMW_PORT_HB_OUT(cmd, in_ecx, in_si, in_di, \
|
|
flags, magic, bp, \
|
|
eax, ebx, ecx, edx, si, di) \
|
|
({ \
|
|
asm volatile ( \
|
|
UNWIND_HINT_SAVE \
|
|
"push %%rbp;" \
|
|
UNWIND_HINT_UNDEFINED \
|
|
"mov %12, %%rbp;" \
|
|
VMWARE_HYPERCALL_HB_OUT \
|
|
"pop %%rbp;" \
|
|
UNWIND_HINT_RESTORE : \
|
|
"=a"(eax), \
|
|
"=b"(ebx), \
|
|
"=c"(ecx), \
|
|
"=d"(edx), \
|
|
"=S"(si), \
|
|
"=D"(di) : \
|
|
"a"(magic), \
|
|
"b"(cmd), \
|
|
"c"(in_ecx), \
|
|
"d"(flags), \
|
|
"S"(in_si), \
|
|
"D"(in_di), \
|
|
"r"(bp) : \
|
|
"memory", "cc"); \
|
|
})
|
|
|
|
|
|
#define VMW_PORT_HB_IN(cmd, in_ecx, in_si, in_di, \
|
|
flags, magic, bp, \
|
|
eax, ebx, ecx, edx, si, di) \
|
|
({ \
|
|
asm volatile ( \
|
|
UNWIND_HINT_SAVE \
|
|
"push %%rbp;" \
|
|
UNWIND_HINT_UNDEFINED \
|
|
"mov %12, %%rbp;" \
|
|
VMWARE_HYPERCALL_HB_IN \
|
|
"pop %%rbp;" \
|
|
UNWIND_HINT_RESTORE : \
|
|
"=a"(eax), \
|
|
"=b"(ebx), \
|
|
"=c"(ecx), \
|
|
"=d"(edx), \
|
|
"=S"(si), \
|
|
"=D"(di) : \
|
|
"a"(magic), \
|
|
"b"(cmd), \
|
|
"c"(in_ecx), \
|
|
"d"(flags), \
|
|
"S"(in_si), \
|
|
"D"(in_di), \
|
|
"r"(bp) : \
|
|
"memory", "cc"); \
|
|
})
|
|
|
|
#elif defined(__i386__)
|
|
|
|
/*
|
|
* In the 32-bit version of this macro, we store bp in a memory location
|
|
* because we've ran out of registers.
|
|
* Now we can't reference that memory location while we've modified
|
|
* %esp or %ebp, so we first push it on the stack, just before we push
|
|
* %ebp, and then when we need it we read it from the stack where we
|
|
* just pushed it.
|
|
*/
|
|
#define VMW_PORT_HB_OUT(cmd, in_ecx, in_si, in_di, \
|
|
flags, magic, bp, \
|
|
eax, ebx, ecx, edx, si, di) \
|
|
({ \
|
|
asm volatile ("push %12;" \
|
|
"push %%ebp;" \
|
|
"mov 0x04(%%esp), %%ebp;" \
|
|
VMWARE_HYPERCALL_HB_OUT \
|
|
"pop %%ebp;" \
|
|
"add $0x04, %%esp;" : \
|
|
"=a"(eax), \
|
|
"=b"(ebx), \
|
|
"=c"(ecx), \
|
|
"=d"(edx), \
|
|
"=S"(si), \
|
|
"=D"(di) : \
|
|
"a"(magic), \
|
|
"b"(cmd), \
|
|
"c"(in_ecx), \
|
|
"d"(flags), \
|
|
"S"(in_si), \
|
|
"D"(in_di), \
|
|
"m"(bp) : \
|
|
"memory", "cc"); \
|
|
})
|
|
|
|
|
|
#define VMW_PORT_HB_IN(cmd, in_ecx, in_si, in_di, \
|
|
flags, magic, bp, \
|
|
eax, ebx, ecx, edx, si, di) \
|
|
({ \
|
|
asm volatile ("push %12;" \
|
|
"push %%ebp;" \
|
|
"mov 0x04(%%esp), %%ebp;" \
|
|
VMWARE_HYPERCALL_HB_IN \
|
|
"pop %%ebp;" \
|
|
"add $0x04, %%esp;" : \
|
|
"=a"(eax), \
|
|
"=b"(ebx), \
|
|
"=c"(ecx), \
|
|
"=d"(edx), \
|
|
"=S"(si), \
|
|
"=D"(di) : \
|
|
"a"(magic), \
|
|
"b"(cmd), \
|
|
"c"(in_ecx), \
|
|
"d"(flags), \
|
|
"S"(in_si), \
|
|
"D"(in_di), \
|
|
"m"(bp) : \
|
|
"memory", "cc"); \
|
|
})
|
|
#endif /* defined(__i386__) */
|
|
|
|
#endif /* defined(__i386__) || defined(__x86_64__) */
|
|
|
|
#endif /* _VMWGFX_MSG_X86_H */
|