Cezar Bulinaru
4f61f133f3
net: tap: NULL pointer derefence in dev_parse_header_protocol when skb->dev is null ...
Fixes a NULL pointer derefence bug triggered from tap driver.
When tap_get_user calls virtio_net_hdr_to_skb the skb->dev is null
(in tap.c skb->dev is set after the call to virtio_net_hdr_to_skb)
virtio_net_hdr_to_skb calls dev_parse_header_protocol which
needs skb->dev field to be valid.
The line that trigers the bug is in dev_parse_header_protocol
(dev is at offset 0x10 from skb and is stored in RAX register)
if (!dev->header_ops || !dev->header_ops->parse_protocol)
22e1: mov 0x10(%rbx),%rax
22e5: mov 0x230(%rax),%rax
Setting skb->dev before the call in tap.c fixes the issue.
BUG: kernel NULL pointer dereference, address: 0000000000000230
RIP: 0010:virtio_net_hdr_to_skb.constprop.0+0x335/0x410 [tap]
Code: c0 0f 85 b7 fd ff ff eb d4 41 39 c6 77 cf 29 c6 48 89 df 44 01 f6 e8 7a 79 83 c1 48 85 c0 0f 85 d9 fd ff ff eb b7 48 8b 43 10 <48> 8b 80 30 02 00 00 48 85 c0 74 55 48 8b 40 28 48 85 c0 74 4c 48
RSP: 0018:ffffc90005c27c38 EFLAGS: 00010246
RAX: 0000000000000000 RBX: ffff888298f25300 RCX: 0000000000000010
RDX: 0000000000000005 RSI: ffffc90005c27cb6 RDI: ffff888298f25300
RBP: ffffc90005c27c80 R08: 00000000ffffffea R09: 00000000000007e8
R10: ffff88858ec77458 R11: 0000000000000000 R12: 0000000000000001
R13: 0000000000000014 R14: ffffc90005c27e08 R15: ffffc90005c27cb6
FS: 0000000000000000(0000) GS:ffff88858ec40000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000000000000230 CR3: 0000000281408006 CR4: 00000000003706e0
Call Trace:
tap_get_user+0x3f1/0x540 [tap]
tap_sendmsg+0x56/0x362 [tap]
? get_tx_bufs+0xc2/0x1e0 [vhost_net]
handle_tx_copy+0x114/0x670 [vhost_net]
handle_tx+0xb0/0xe0 [vhost_net]
handle_tx_kick+0x15/0x20 [vhost_net]
vhost_worker+0x7b/0xc0 [vhost]
? vhost_vring_call_reset+0x40/0x40 [vhost]
kthread+0xfa/0x120
? kthread_complete_and_exit+0x20/0x20
ret_from_fork+0x1f/0x30
Fixes: 924a9bc362a5 ("net: check if protocol extracted by virtio_net_hdr_set_proto is correct")
Signed-off-by: Cezar Bulinaru <cbulinaru@gmail.com>
Reviewed-by: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2022-08-05 08:56:35 +01:00
2022-05-20 21:07:05 +02:00
2022-08-03 14:38:02 -07:00
2022-07-14 13:17:48 +01:00
2022-06-05 17:14:03 -07:00
2022-08-03 15:26:04 -07:00
2022-07-11 19:49:53 -07:00
2022-08-02 11:17:00 -07:00
2022-05-09 14:41:43 +03:00
2022-08-02 13:46:35 -07:00
2022-07-22 17:14:37 -07:00
2022-07-29 19:58:52 +02:00
2022-06-28 06:33:15 -06:00
2022-08-02 17:45:14 -07:00
2022-08-02 19:34:45 -07:00
2022-07-28 12:33:34 +02:00
2022-06-10 15:21:23 +02:00
2022-07-29 19:33:13 +02:00
2022-08-02 19:12:45 -07:00
2022-08-02 17:45:14 -07:00
2022-06-28 22:03:18 -07:00
2022-05-16 13:37:59 -07:00
2022-07-15 11:40:08 +09:00
2022-05-19 18:56:51 +02:00
2022-07-06 10:53:25 +05:30
2022-08-03 11:35:20 -07:00
2022-07-27 10:42:52 +02:00
2022-05-13 17:03:41 +09:00
2022-07-28 22:21:54 -07:00
2022-08-03 14:41:36 -07:00
2022-05-10 16:05:38 +08:00
2022-08-01 12:48:15 -07:00
2022-08-03 11:35:20 -07:00
2022-06-08 12:28:13 +00:00
2022-05-20 15:54:41 +02:00
2022-06-10 08:41:28 +00:00
2022-08-02 11:07:04 -07:00
2022-05-09 16:03:24 +01:00
2022-08-02 08:10:10 -07:00
2022-05-17 22:34:42 +02:00
2022-08-02 11:17:00 -07:00
2022-06-20 09:49:52 +02:00
2022-08-03 16:29:08 -07:00
2022-08-03 14:38:02 -07:00
2022-06-03 11:36:34 -07:00
2022-08-01 12:48:15 -07:00
2022-08-02 08:29:18 -07:00
2022-06-22 18:20:46 -07:00
2022-06-02 15:23:54 -07:00
2022-05-22 15:58:30 +10:00
2022-05-24 08:08:24 -05:00
2022-08-02 14:38:59 -07:00
2022-06-03 11:17:49 -07:00
2022-07-12 22:53:08 +02:00
2022-06-28 06:33:15 -06:00
2022-08-02 11:12:25 -07:00
2022-08-03 10:35:43 -07:00
2022-08-02 19:34:45 -07:00
2022-08-02 13:46:35 -07:00
2022-08-05 08:56:35 +01:00
2022-07-13 18:52:12 -07:00
2022-08-02 13:46:35 -07:00
2022-08-03 13:50:22 -07:00
2022-05-09 15:46:29 +02:00
2022-07-01 15:22:16 +02:00
2022-07-15 19:17:30 +02:00
2022-07-07 09:38:04 +01:00
2022-07-08 08:44:15 +01:00
2022-06-02 15:23:54 -07:00
2022-07-19 18:50:09 +01:00
2022-07-08 14:09:58 -07:00
2022-08-01 12:48:15 -07:00
2022-07-29 19:58:52 +02:00
2022-06-09 21:08:38 +02:00
2022-08-02 11:17:00 -07:00
2022-07-28 18:21:16 -07:00
2022-07-29 13:41:18 +02:00
2022-07-28 00:01:30 +01:00
2022-05-09 09:29:25 -06:00
2022-07-19 15:42:00 +02:00
2022-06-03 11:48:47 -07:00
2022-06-02 15:23:54 -07:00
2022-08-03 16:29:08 -07:00
2022-08-02 13:46:35 -07:00
2022-07-07 09:38:04 +01:00
2022-06-03 11:48:47 -07:00
2022-08-02 08:10:10 -07:00
2022-06-23 20:53:06 +02:00
2022-08-02 10:55:04 -07:00
2022-05-11 08:29:11 +03:00
2022-08-03 16:29:08 -07:00
2022-08-02 13:46:35 -07:00
2022-07-08 10:51:24 +02:00
2022-08-02 11:27:53 -07:00
2022-08-02 19:34:45 -07:00
2022-08-02 08:10:10 -07:00
2022-08-02 13:46:35 -07:00
2022-05-09 15:42:57 +02:00
2022-07-29 19:58:52 +02:00
2022-06-24 02:49:48 -04:00
2022-08-03 11:35:20 -07:00
2022-06-27 08:05:35 -04:00
2022-07-07 10:52:35 +02:00
2022-08-02 19:34:45 -07:00
2022-08-03 10:35:43 -07:00
2022-06-09 12:20:34 +02:00
2022-08-01 12:48:15 -07:00
2022-06-05 09:25:12 -07:00
2022-06-05 09:25:12 -07:00
4f61f133f3