iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs
History
Robbie Ko 3fe6b9aa5c Btrfs: fix cur_offset in the error case for nocow 
commit 506481b20e818db40b6198815904ecd2d6daee64 upstream.

When the cow_file_range fails, the related resources are unlocked
according to the range [start..end), so the unlock cannot be repeated in
run_delalloc_nocow.

In some cases (e.g. cur_offset <= end && cow_start != -1), cur_offset is
not updated correctly, so move the cur_offset update before
cow_file_range.

  kernel BUG at mm/page-writeback.c:2663!
  Internal error: Oops - BUG: 0 [#1] SMP
  CPU: 3 PID: 31525 Comm: kworker/u8:7 Tainted: P O
  Hardware name: Realtek_RTD1296 (DT)
  Workqueue: writeback wb_workfn (flush-btrfs-1)
  task: ffffffc076db3380 ti: ffffffc02e9ac000 task.ti: ffffffc02e9ac000
  PC is at clear_page_dirty_for_io+0x1bc/0x1e8
  LR is at clear_page_dirty_for_io+0x14/0x1e8
  pc : [<ffffffc00033c91c>] lr : [<ffffffc00033c774>] pstate: 40000145
  sp : ffffffc02e9af4f0
  Process kworker/u8:7 (pid: 31525, stack limit = 0xffffffc02e9ac020)
  Call trace:
  [<ffffffc00033c91c>] clear_page_dirty_for_io+0x1bc/0x1e8
  [<ffffffbffc514674>] extent_clear_unlock_delalloc+0x1e4/0x210 [btrfs]
  [<ffffffbffc4fb168>] run_delalloc_nocow+0x3b8/0x948 [btrfs]
  [<ffffffbffc4fb948>] run_delalloc_range+0x250/0x3a8 [btrfs]
  [<ffffffbffc514c0c>] writepage_delalloc.isra.21+0xbc/0x1d8 [btrfs]
  [<ffffffbffc516048>] __extent_writepage+0xe8/0x248 [btrfs]
  [<ffffffbffc51630c>] extent_write_cache_pages.isra.17+0x164/0x378 [btrfs]
  [<ffffffbffc5185a8>] extent_writepages+0x48/0x68 [btrfs]
  [<ffffffbffc4f5828>] btrfs_writepages+0x20/0x30 [btrfs]
  [<ffffffc00033d758>] do_writepages+0x30/0x88
  [<ffffffc0003ba0f4>] __writeback_single_inode+0x34/0x198
  [<ffffffc0003ba6c4>] writeback_sb_inodes+0x184/0x3c0
  [<ffffffc0003ba96c>] __writeback_inodes_wb+0x6c/0xc0
  [<ffffffc0003bac20>] wb_writeback+0x1b8/0x1c0
  [<ffffffc0003bb0f0>] wb_workfn+0x150/0x250
  [<ffffffc0002b0014>] process_one_work+0x1dc/0x388
  [<ffffffc0002b02f0>] worker_thread+0x130/0x500
  [<ffffffc0002b6344>] kthread+0x10c/0x110
  [<ffffffc000284590>] ret_from_fork+0x10/0x40
  Code: d503201f a9025bb5 a90363b7 f90023b9 (d4210000)

CC: stable@vger.kernel.org # 4.4+
Reviewed-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Robbie Ko <robbieko@synology.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2018-11-21 09:26:01 +01:00
..
9p
9p locks: fix glock.client_id leak in do_lock
2018-11-21 09:25:57 +01:00
adfs
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
affs
affs_lookup(): close a race with affs_remove_link()
2018-05-30 07:50:16 +02:00
afs
afs: Fix abort on signal while waiting for call completion
2017-12-20 10:07:25 +01:00
autofs4
autofs: fix autofs_sbi() does not check super block type
2018-09-19 22:47:16 +02:00
befs
befs fixes for 4.9-rc1
2016-10-15 12:09:13 -07:00
bfs
Merge remote-tracking branch 'ovl/rename2' into for-linus
2016-10-10 23:02:51 -04:00
btrfs
Btrfs: fix cur_offset in the error case for nocow
2018-11-21 09:26:01 +01:00
cachefiles
cachefiles: fix the race between cachefiles_bury_object() and rmdir(2)
2018-11-10 07:43:00 -08:00
ceph
Revert "ceph: fix dentry leak in splice_dentry()"
2018-11-21 09:25:59 +01:00
cifs
smb3: on kerberos mount if server doesn't specify auth type use krb5
2018-11-13 11:17:01 -08:00
coda
coda: fix 'kernel memory exposure attempt' in fsync
2017-11-24 08:33:42 +01:00
configfs
configfs: fix registered group removal
2018-09-26 08:36:38 +02:00
cramfs
Cramfs: fix abad comparison when wrap-arounds occur
2018-11-13 11:17:03 -08:00
crypto
fscrypt: use unbound workqueue for decryption
2018-08-03 07:55:20 +02:00
debugfs
dentry name snapshots
2017-08-06 18:59:43 -07:00
devpts
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
dlm
dlm: avoid double-free on error path in dlm_device_{register,unregister}
2017-09-09 17:39:40 +02:00
ecryptfs
do d_instantiate/unlock_new_inode combinations safely
2018-05-30 07:50:16 +02:00
efivarfs
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
efs
…
exofs
fs: exofs: print a hex number after a 0x prefix
2016-10-27 18:43:43 -07:00
exportfs
exportfs: be careful to only return expected errors.
2016-10-06 09:07:44 -04:00
ext2
do d_instantiate/unlock_new_inode combinations safely
2018-05-30 07:50:16 +02:00
ext4
ext4: propagate error from dquot_initialize() in EXT4_IOC_FSSETXATTR
2018-11-13 11:16:56 -08:00
f2fs
f2fs: fix multiple f2fs_add_link() having same name for inline dentry
2018-11-10 07:42:45 -08:00
fat
fs/fat/fatent.c: add cond_resched() to fat_count_free_clusters()
2018-11-10 07:42:56 -08:00
freevxfs
…
fscache
fscache: Allow cancelled operations to be enqueued
2018-09-05 09:20:02 +02:00
fuse
fuse: set FR_SENT while locked
2018-11-21 09:25:58 +01:00
gfs2
gfs2_meta: ->mount() can get NULL dev_name
2018-11-13 11:16:56 -08:00
hfs
hfs: prevent crash on exit from failed search
2018-09-15 09:42:57 +02:00
hfsplus
hfsplus: fix NULL dereference in hfsplus_lookup()
2018-09-15 09:42:57 +02:00
hostfs
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
hpfs
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
hugetlbfs
hugetlbfs: initialize shared policy as part of inode allocation
2017-10-08 10:26:09 +02:00
isofs
isofs: fix timestamps beyond 2027
2017-11-30 08:39:04 +00:00
jbd2
jbd2: fix use after free in jbd2_log_do_checkpoint()
2018-11-13 11:16:55 -08:00
jffs2
jffs2: free jffs2_sb_info through jffs2_kill_sb()
2018-11-13 11:16:46 -08:00
jfs
jfs: Fix inconsistency between memory allocation and ea_buf->max_size
2018-08-09 12:18:00 +02:00
kernfs
kernfs: fix regression in kernfs_fop_write caused by wrong type
2018-02-17 13:21:15 +01:00
lockd
lockd: fix access beyond unterminated strings in prints
2018-11-13 11:17:02 -08:00
logfs
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
minix
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
ncpfs
staging: ncpfs: memory corruption in ncp_read_kernel()
2018-03-28 18:39:23 +02:00
nfs
NFSv4.1: Fix the r/wsize checking
2018-11-13 11:17:01 -08:00
nfs_common
lockd: fix "list_add double add" caused by legacy signal interface
2018-02-03 17:05:38 +01:00
nfsd
nfsd: fix corrupted reply to badly ordered compound
2018-10-03 17:01:48 -07:00
nilfs2
do d_instantiate/unlock_new_inode combinations safely
2018-05-30 07:50:16 +02:00
nls
…
notify
fanotify: fix logic of events on child
2018-04-24 09:34:18 +02:00
ntfs
fs: remove the never implemented aio_fsync file operation
2016-10-30 13:09:42 -04:00
ocfs2
ocfs2: fix a misuse a of brelse after failing ocfs2_check_dir_entry
2018-11-21 09:26:00 +01:00
omfs
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
openpromfs
fs: Replace CURRENT_TIME with current_time() for inode timestamps
2016-09-27 21:06:21 -04:00
orangefs
orangefs: off by ones in xattr size checks
2018-11-10 07:42:46 -08:00
overlayfs
ovl: filter trusted xattr for non-admin
2018-04-13 19:48:12 +02:00
proc
sched/cputime: Convert kcpustat to nsecs
2018-10-20 09:51:32 +02:00
pstore
pstore: Fix incorrect persistent ram buffer mapping
2018-09-26 08:36:35 +02:00
qnx4
…
qnx6
…
quota
fs/quota: Fix spectre gadget in do_quotactl
2018-09-09 20:01:26 +02:00
ramfs
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
reiserfs
reiserfs: change j_timestamp type to time64_t
2018-09-15 09:42:57 +02:00
romfs
romfs: use different way to generate fsid for BLOCK or MTD
2017-06-17 06:41:56 +02:00
squashfs
Squashfs: Compute expected length from inode size rather than block length
2018-09-05 09:20:03 +02:00
sysfs
scsi: sysfs: Introduce sysfs_{un,}break_active_protection()
2018-09-05 09:20:10 +02:00
sysv
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
tracefs
fs: Replace CURRENT_TIME with current_time() for inode timestamps
2016-09-27 21:06:21 -04:00
ubifs
ubifs: Check for name being NULL while mounting
2018-10-13 09:18:58 +02:00
udf
udf: Detect incorrect directory size
2018-07-03 11:23:17 +02:00
ufs
ufs: we need to sync inode before freeing it
2018-11-10 07:42:49 -08:00
xfs
xfs: truncate transaction does not modify the inobt
2018-11-10 07:43:00 -08:00
aio.c
fix io_destroy()/aio_complete() race
2018-06-06 16:44:38 +02:00
anon_inodes.c
…
attr.c
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2016-10-10 20:16:43 -07:00
bad_inode.c
bad_inode: add missing i_op initializers
2017-01-09 08:32:24 +01:00
binfmt_aout.c
…
binfmt_elf_fdpic.c
…
binfmt_elf.c
binfmt_elf: Respect error return from `regset->active'
2018-09-26 08:36:37 +02:00
binfmt_em86.c
fs/binfmt_em86.c: fix incompatible pointer type
2016-08-02 19:35:15 -04:00
binfmt_flat.c
…
binfmt_misc.c
fs/binfmt_misc.c: do not allow offset overflow
2018-06-26 08:08:09 +08:00
binfmt_script.c
…
block_dev.c
fs/mpage.c: fix mpage_writepage() for pages with buffers
2017-10-18 09:35:39 +02:00
buffer.c
fs: add i_blocksize()
2017-06-14 15:06:00 +02:00
char_dev.c
dax: define a unified inode/address_space for device-dax mappings
2016-08-23 22:58:51 -07:00
compat_binfmt_elf.c
binfmt_elf: compat: avoid unused function warning
2018-02-25 11:05:55 +01:00
compat_ioctl.c
fs: compat: Remove warning from COMPATIBLE_IOCTL
2018-04-08 12:12:44 +02:00
compat.c
compat: remove compat_printk()
2016-09-27 21:20:53 -04:00
coredump.c
coredump: Ensure proper size of sparse core files
2017-07-05 14:40:26 +02:00
dax.c
fs/dax.c: fix inefficiency in dax_writeback_mapping_range()
2018-02-28 10:18:33 +01:00
dcache.c
fs/dcache.c: fix kmemcheck splat at take_dentry_name_snapshot()
2018-09-15 09:42:58 +02:00
dcookies.c
…
direct-io.c
direct-io: Prevent NULL pointer access in submit_page_section
2017-10-18 09:35:41 +02:00
drop_caches.c
…
eventfd.c
…
eventpoll.c
epoll: fix race between ep_poll_callback(POLLFREE) and ep_free()/ep_remove()
2017-09-07 08:35:41 +02:00
exec.c
exec: avoid gcc-8 warning for get_task_comm
2018-07-28 07:49:14 +02:00
fcntl.c
fs/fcntl: f_setown, avoid undefined behaviour
2018-01-31 12:55:52 +01:00
fhandle.c
…
file_table.c
…
file.c
fs/file: more unsigned file descriptors
2016-09-27 18:47:38 -04:00
filesystems.c
…
fs_pin.c
…
fs_struct.c
…
fs-writeback.c
bdi: Fix oops in wb_workfn()
2018-05-16 10:08:42 +02:00
inode.c
Fix up non-directory creation in SGID directories
2018-07-17 11:37:53 +02:00
internal.h
xfs: evict all inodes involved with log redo item
2017-09-20 08:20:01 +02:00
ioctl.c
vfs: cap dedupe request structure size at PAGE_SIZE
2016-09-15 13:29:52 -07:00
iomap.c
iomap: fix integer truncation issues in the zeroing and dirtying helpers
2017-09-20 08:19:59 +02:00
Kconfig
mm/hugetlb: introduce ARCH_HAS_GIGANTIC_PAGE
2016-10-07 18:46:29 -07:00
Kconfig.binfmt
ARM: 8594/1: enable binfmt_flat on systems with an MMU
2016-08-12 16:47:05 +01:00
libfs.c
libfs: Modify mount_pseudo_xattr to be clear it is not a userspace mount
2017-12-09 22:01:51 +01:00
locks.c
locking, fs/locks: Add missing file_sem locks
2016-10-18 12:21:28 +02:00
Makefile
…
mbcache.c
mbcache: initialize entry->e_referenced in mb_cache_entry_create()
2018-02-22 15:43:48 +01:00
mount.h
mnt: In propgate_umount handle visiting mounts in any order
2017-07-21 07:42:22 +02:00
mpage.c
fs/mpage.c: fix mpage_writepage() for pages with buffers
2017-10-18 09:35:39 +02:00
namei.c
getname_kernel() needs to make sure that ->name != ->iname in long case
2018-04-20 08:21:07 +02:00
namespace.c
fix __legitimize_mnt()/mntput() race
2018-08-15 18:14:43 +02:00
no-block.c
…
nsfs.c
nsfs: mark dentry with DCACHE_RCUACCESS
2018-02-17 13:21:15 +01:00
open.c
fs: completely ignore unknown open flags
2017-07-12 15:01:02 +02:00
pipe.c
pipe: fix off-by-one error when checking buffer limits
2018-02-17 13:21:18 +01:00
pnode.c
mnt: Make propagate_umount less slow for overlapping mount propagation trees
2017-07-21 07:42:22 +02:00
pnode.h
mnt: Tuck mounts under others instead of creating shadow/side mounts.
2017-03-15 10:02:43 +08:00
posix_acl.c
tmpfs: clear S_ISGID when setting posix ACLs
2017-01-26 08:24:37 +01:00
proc_namespace.c
…
read_write.c
vfs: deny copy_file_range() for non regular files
2017-10-12 11:51:26 +02:00
readdir.c
…
select.c
fs/select: add vmalloc fallback for select(2)
2016-10-11 15:06:30 -07:00
seq_file.c
seq/proc: modify seq_put_decimal_[u]ll to take a const char *, not char
2016-10-07 18:46:30 -07:00
signalfd.c
…
splice.c
vfs: fix uninitialized flags in splice_to_pipe()
2017-02-23 17:44:35 +01:00
stack.c
…
stat.c
ufs: restore maintaining ->i_blocks
2017-06-14 15:06:01 +02:00
statfs.c
…
super.c
sget(): handle failures of register_shrinker()
2018-03-03 10:23:21 +01:00
sync.c
…
timerfd.c
timerfd: Protect the might cancel mechanism proper
2017-05-08 07:47:54 +02:00
userfaultfd.c
userfaultfd: shmem: __do_fault requires VM_FAULT_NOPAGE
2017-12-20 10:07:18 +01:00
utimes.c
Merge remote-tracking branch 'jk/vfs' into work.misc
2016-10-08 11:06:08 -04:00
xattr.c
sysfs: Do not return POSIX ACL xattrs via listxattr
2018-10-10 08:53:22 +02:00