Xiubo Li 409e873ea3 ceph: fix use-after-free bug for inodes when flushing capsnaps
There is a race between capsnaps flush and removing the inode from
'mdsc->snap_flush_list' list:

   == Thread A ==                     == Thread B ==
ceph_queue_cap_snap()
 -> allocate 'capsnapA'
 ->ihold('&ci->vfs_inode')
 ->add 'capsnapA' to 'ci->i_cap_snaps'
 ->add 'ci' to 'mdsc->snap_flush_list'
    ...
   == Thread C ==
ceph_flush_snaps()
 ->__ceph_flush_snaps()
  ->__send_flush_snap()
                                handle_cap_flushsnap_ack()
                                 ->iput('&ci->vfs_inode')
                                   this also will release 'ci'
                                    ...
				      == Thread D ==
                                ceph_handle_snap()
                                 ->flush_snaps()
                                  ->iterate 'mdsc->snap_flush_list'
                                   ->get the stale 'ci'
 ->remove 'ci' from                ->ihold(&ci->vfs_inode) this
   'mdsc->snap_flush_list'           will WARNING

To fix this we will increase the inode's i_count ref when adding 'ci'
to the 'mdsc->snap_flush_list' list.

[ idryomov: need_put int -> bool ]

Cc: stable@vger.kernel.org
Link: https://bugzilla.redhat.com/show_bug.cgi?id=2209299
Signed-off-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
2023-06-08 08:56:25 +02:00
..
2023-05-05 19:12:01 -07:00
2023-02-20 14:10:36 -08:00
2023-06-02 17:16:19 -04:00
2023-04-27 16:52:33 -07:00
2023-02-27 10:04:49 -08:00
2023-04-26 16:07:23 -07:00
2023-03-01 08:42:27 -08:00
\n
2023-04-26 09:07:46 -07:00
2023-04-26 09:42:10 -07:00
2023-04-27 11:53:57 -07:00
2023-05-10 17:15:18 +02:00
2023-04-29 10:35:48 -07:00
2023-04-24 19:20:27 -07:00
2023-04-27 11:53:57 -07:00
2023-05-17 09:56:01 -07:00
2023-06-02 13:38:55 -04:00
2023-04-29 10:52:37 -07:00
2023-04-27 17:03:40 -07:00
2023-03-14 12:56:30 -06:00
\n
2023-04-26 09:07:46 -07:00
2023-06-01 08:27:34 -04:00
2023-03-12 20:03:41 -04:00
2023-05-11 16:51:11 -05:00
2023-03-30 08:51:48 +02:00
2023-04-08 13:45:37 -07:00
2022-08-20 11:34:33 -04:00
2023-04-05 18:06:23 -07:00
2022-10-10 19:45:17 -07:00
2023-04-28 15:57:53 -07:00
2023-02-20 11:53:11 -08:00
2023-05-06 08:28:58 -07:00
2022-10-10 14:21:11 -07:00
2023-01-19 09:24:30 +01:00
2023-04-24 19:14:20 -07:00
2023-04-06 14:53:38 +02:00
2023-03-06 09:59:20 +01:00
2023-05-06 08:15:20 -07:00
2023-02-20 11:53:11 -08:00
2023-02-20 11:53:11 -08:00