84513eccd6
Change the inline function mtk_phy_update_field() into a macro to
avoid check warning of FIELD_PREP() with compiler parameter
-Wtautological-constant-out-of-range-compare
the warning is caused by mask check:
"BUILD_BUG_ON_MSG(__bf_cast_unsigned(_mask, _mask) > \"
Fixes: 29c07477556e ("phy: mediatek: add a new helper to update bitfield")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20220928070746.5393-1-chunfeng.yun@mediatek.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
47 lines
857 B
C
47 lines
857 B
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* Copyright (C) 2021 MediaTek Inc.
|
|
*
|
|
* Author: Chunfeng Yun <chunfeng.yun@mediatek.com>
|
|
*/
|
|
|
|
#ifndef __PHY_MTK_H__
|
|
#define __PHY_MTK_H__
|
|
|
|
#include <linux/bitfield.h>
|
|
#include <linux/io.h>
|
|
|
|
static inline void mtk_phy_clear_bits(void __iomem *reg, u32 bits)
|
|
{
|
|
u32 tmp = readl(reg);
|
|
|
|
tmp &= ~bits;
|
|
writel(tmp, reg);
|
|
}
|
|
|
|
static inline void mtk_phy_set_bits(void __iomem *reg, u32 bits)
|
|
{
|
|
u32 tmp = readl(reg);
|
|
|
|
tmp |= bits;
|
|
writel(tmp, reg);
|
|
}
|
|
|
|
static inline void mtk_phy_update_bits(void __iomem *reg, u32 mask, u32 val)
|
|
{
|
|
u32 tmp = readl(reg);
|
|
|
|
tmp &= ~mask;
|
|
tmp |= val & mask;
|
|
writel(tmp, reg);
|
|
}
|
|
|
|
/* field @mask shall be constant and continuous */
|
|
#define mtk_phy_update_field(reg, mask, val) \
|
|
({ \
|
|
typeof(mask) mask_ = (mask); \
|
|
mtk_phy_update_bits(reg, mask_, FIELD_PREP(mask_, val)); \
|
|
})
|
|
|
|
#endif
|