Bartosz Golaszewski 410ab742a5 gpiolib: don't clear FLAG_IS_OUT when emulating open-drain/open-source
[ Upstream commit e735244e2cf068f98b6384681a38993e0517a838 ]

When emulating open-drain/open-source by not actively driving the output
lines - we're simply changing their mode to input. This is wrong as it
will then make it impossible to change the value of such line - it's now
considered to actually be in input mode. If we want to still use the
direction_input() callback for simplicity then we need to set FLAG_IS_OUT
manually in gpiod_direction_output() and not clear it in
gpio_set_open_drain_value_commit() and
gpio_set_open_source_value_commit().

Fixes: c663e5f56737 ("gpio: support native single-ended hardware drivers")
Cc: stable@vger.kernel.org
Reported-by: Kent Gibson <warthog618@gmail.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
[Bartosz: backported to v5.3, v4.19]
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2019-10-17 13:45:21 -07:00
..
2018-03-19 01:50:07 +01:00
2018-05-16 14:35:24 +02:00
2018-03-19 01:50:29 +01:00
2018-08-10 23:19:17 +02:00
2018-05-24 17:09:41 +02:00
2017-12-22 15:24:31 +01:00
2018-01-09 14:51:00 +01:00
2017-08-23 09:21:54 +02:00
2019-06-22 08:15:16 +02:00
2018-08-20 15:38:44 -07:00