The value returned by an i2c driver's remove function is mostly ignored. (Only an error message is printed if the value is non-zero that the error is ignored.) So change the prototype of the remove function to return no value. This way driver authors are not tempted to assume that passing an error to the upper layer is a good idea. All drivers are adapted accordingly. There is no intended change of behaviour, all callbacks were prepared to return 0 before. Reviewed-by: Peter Senna Tschudin <peter.senna@gmail.com> Reviewed-by: Jeremy Kerr <jk@codeconstruct.com.au> Reviewed-by: Benjamin Mugnier <benjamin.mugnier@foss.st.com> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Crt Mori <cmo@melexis.com> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Marek Behún <kabel@kernel.org> # for leds-turris-omnia Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Petr Machata <petrm@nvidia.com> # for mlxsw Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com> # for surface3_power Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> # for bmc150-accel-i2c + kxcjk-1013 Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> # for media/* + staging/media/* Acked-by: Miguel Ojeda <ojeda@kernel.org> # for auxdisplay/ht16k33 + auxdisplay/lcd2s Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> # for versaclock5 Reviewed-by: Ajay Gupta <ajayg@nvidia.com> # for ucsi_ccg Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> # for iio Acked-by: Peter Rosin <peda@axentia.se> # for i2c-mux-*, max9860 Acked-by: Adrien Grassein <adrien.grassein@gmail.com> # for lontium-lt8912b Reviewed-by: Jean Delvare <jdelvare@suse.de> # for hwmon, i2c-core and i2c/muxes Acked-by: Corey Minyard <cminyard@mvista.com> # for IPMI Reviewed-by: Vladimir Oltean <olteanv@gmail.com> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Acked-by: Sebastian Reichel <sebastian.reichel@collabora.com> # for drivers/power Acked-by: Krzysztof Hałasa <khalasa@piap.pl> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Wolfram Sang <wsa@kernel.org>
84 lines
2.1 KiB
C
84 lines
2.1 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* 3-axis magnetometer driver supporting following I2C Bosch-Sensortec chips:
|
|
* - BMC150
|
|
* - BMC156
|
|
* - BMM150
|
|
*
|
|
* Copyright (c) 2016, Intel Corporation.
|
|
*/
|
|
#include <linux/device.h>
|
|
#include <linux/mod_devicetable.h>
|
|
#include <linux/i2c.h>
|
|
#include <linux/module.h>
|
|
#include <linux/acpi.h>
|
|
#include <linux/regmap.h>
|
|
|
|
#include "bmc150_magn.h"
|
|
|
|
static int bmc150_magn_i2c_probe(struct i2c_client *client,
|
|
const struct i2c_device_id *id)
|
|
{
|
|
struct regmap *regmap;
|
|
const char *name = NULL;
|
|
|
|
regmap = devm_regmap_init_i2c(client, &bmc150_magn_regmap_config);
|
|
if (IS_ERR(regmap)) {
|
|
dev_err(&client->dev, "Failed to initialize i2c regmap\n");
|
|
return PTR_ERR(regmap);
|
|
}
|
|
|
|
if (id)
|
|
name = id->name;
|
|
|
|
return bmc150_magn_probe(&client->dev, regmap, client->irq, name);
|
|
}
|
|
|
|
static void bmc150_magn_i2c_remove(struct i2c_client *client)
|
|
{
|
|
bmc150_magn_remove(&client->dev);
|
|
}
|
|
|
|
static const struct acpi_device_id bmc150_magn_acpi_match[] = {
|
|
{"BMC150B", 0},
|
|
{"BMC156B", 0},
|
|
{"BMM150B", 0},
|
|
{},
|
|
};
|
|
MODULE_DEVICE_TABLE(acpi, bmc150_magn_acpi_match);
|
|
|
|
static const struct i2c_device_id bmc150_magn_i2c_id[] = {
|
|
{"bmc150_magn", 0},
|
|
{"bmc156_magn", 0},
|
|
{"bmm150_magn", 0},
|
|
{}
|
|
};
|
|
MODULE_DEVICE_TABLE(i2c, bmc150_magn_i2c_id);
|
|
|
|
static const struct of_device_id bmc150_magn_of_match[] = {
|
|
{ .compatible = "bosch,bmc150_magn" },
|
|
{ .compatible = "bosch,bmc156_magn" },
|
|
{ .compatible = "bosch,bmm150_magn" }, /* deprecated compatible */
|
|
{ .compatible = "bosch,bmm150" },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, bmc150_magn_of_match);
|
|
|
|
static struct i2c_driver bmc150_magn_driver = {
|
|
.driver = {
|
|
.name = "bmc150_magn_i2c",
|
|
.of_match_table = bmc150_magn_of_match,
|
|
.acpi_match_table = ACPI_PTR(bmc150_magn_acpi_match),
|
|
.pm = &bmc150_magn_pm_ops,
|
|
},
|
|
.probe = bmc150_magn_i2c_probe,
|
|
.remove = bmc150_magn_i2c_remove,
|
|
.id_table = bmc150_magn_i2c_id,
|
|
};
|
|
module_i2c_driver(bmc150_magn_driver);
|
|
|
|
MODULE_AUTHOR("Daniel Baluta <daniel.baluta@intel.com");
|
|
MODULE_LICENSE("GPL v2");
|
|
MODULE_DESCRIPTION("BMC150 I2C magnetometer driver");
|
|
MODULE_IMPORT_NS(IIO_BMC150_MAGN);
|