linux/drivers/gpu/drm/omapdrm
Arnd Bergmann 417fc6123b drm/omap: fix misleading indentation in pixinc()
An old patch added a 'return' statement after each BUG() in this driver,
which was necessary at the time, but has become redundant after the BUG()
definition was updated to handle this properly.

gcc-11 now warns about one such instance, where the 'return' statement
was incorrectly indented:

drivers/gpu/drm/omapdrm/dss/dispc.c: In function ‘pixinc’:
drivers/gpu/drm/omapdrm/dss/dispc.c:2093:9: error: this ‘else’ clause does not guard... [-Werror=misleading-indentation]
 2093 |         else
      |         ^~~~
drivers/gpu/drm/omapdrm/dss/dispc.c:2095:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘else’
 2095 |                 return 0;
      |                 ^~~~~~

Address this by removing the return again and changing the BUG()
to be unconditional to make this more intuitive.

Fixes: c6eee968d4 ("OMAPDSS: remove compiler warnings when CONFIG_BUG=n")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210322164203.827324-1-arnd@kernel.org
2021-03-26 09:13:37 +02:00
..
dss drm/omap: fix misleading indentation in pixinc() 2021-03-26 09:13:37 +02:00
Kconfig drm/omap: squash omapdrm sub-modules into one 2020-12-15 16:08:27 +02:00
Makefile drm/omap: remove unused display.c 2020-12-15 16:08:27 +02:00
omap_crtc.c drm/omap: remove dss_mgr_ops 2020-12-15 16:17:30 +02:00
omap_crtc.h drm/omap: remove dss_mgr_ops 2020-12-15 16:17:30 +02:00
omap_debugfs.c drm: omapdrm: Replace HTTP links with HTTPS ones 2020-11-10 14:41:22 +02:00
omap_dmm_priv.h drm: omapdrm: Replace HTTP links with HTTPS ones 2020-11-10 14:41:22 +02:00
omap_dmm_tiler.c drm/omap: dmm_tiler: fix return error code in omap_dmm_probe() 2020-11-17 14:43:19 +01:00
omap_dmm_tiler.h drm: omapdrm: Replace HTTP links with HTTPS ones 2020-11-10 14:41:22 +02:00
omap_drv.c drm/omapdrm: Annotate dma-fence critical section in commit path 2021-02-23 12:54:19 +01:00
omap_drv.h drm/omap: remove dispc_ops 2020-12-15 16:15:06 +02:00
omap_encoder.c drm/omap: drop unused DSS next pointer 2020-12-15 16:08:26 +02:00
omap_encoder.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234 2019-06-19 17:09:07 +02:00
omap_fb.c drm: omapdrm: Replace HTTP links with HTTPS ones 2020-11-10 14:41:22 +02:00
omap_fb.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234 2019-06-19 17:09:07 +02:00
omap_fbdev.c drm: omapdrm: Replace HTTP links with HTTPS ones 2020-11-10 14:41:22 +02:00
omap_fbdev.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234 2019-06-19 17:09:07 +02:00
omap_gem_dmabuf.c drm: omapdrm: Replace HTTP links with HTTPS ones 2020-11-10 14:41:22 +02:00
omap_gem.c drm/prime: split array import functions v4 2020-11-30 15:00:45 +01:00
omap_gem.h drm/omapdrm: Introduce GEM object functions 2020-09-25 09:21:10 +02:00
omap_irq.c drm/omap: remove dispc_ops 2020-12-15 16:15:06 +02:00
omap_irq.h drm main pull request for v5.3-rc1 (sans mm changes) 2019-07-15 19:04:27 -07:00
omap_plane.c drm: Use state helper instead of the plane state pointer 2021-02-25 08:05:28 +01:00
omap_plane.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234 2019-06-19 17:09:07 +02:00
tcm-sita.c drm/omap: Delete useless kfree code 2020-12-15 17:19:54 +02:00
tcm.h
TODO