Eric Dumazet
a1865f2e7d
netlink: annotate lockless accesses to nlk->max_recvmsg_len ...
syzbot reported a data-race in data-race in netlink_recvmsg() [1]
Indeed, netlink_recvmsg() can be run concurrently,
and netlink_dump() also needs protection.
[1]
BUG: KCSAN: data-race in netlink_recvmsg / netlink_recvmsg
read to 0xffff888141840b38 of 8 bytes by task 23057 on cpu 0:
netlink_recvmsg+0xea/0x730 net/netlink/af_netlink.c:1988
sock_recvmsg_nosec net/socket.c:1017 [inline]
sock_recvmsg net/socket.c:1038 [inline]
__sys_recvfrom+0x1ee/0x2e0 net/socket.c:2194
__do_sys_recvfrom net/socket.c:2212 [inline]
__se_sys_recvfrom net/socket.c:2208 [inline]
__x64_sys_recvfrom+0x78/0x90 net/socket.c:2208
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
write to 0xffff888141840b38 of 8 bytes by task 23037 on cpu 1:
netlink_recvmsg+0x114/0x730 net/netlink/af_netlink.c:1989
sock_recvmsg_nosec net/socket.c:1017 [inline]
sock_recvmsg net/socket.c:1038 [inline]
____sys_recvmsg+0x156/0x310 net/socket.c:2720
___sys_recvmsg net/socket.c:2762 [inline]
do_recvmmsg+0x2e5/0x710 net/socket.c:2856
__sys_recvmmsg net/socket.c:2935 [inline]
__do_sys_recvmmsg net/socket.c:2958 [inline]
__se_sys_recvmmsg net/socket.c:2951 [inline]
__x64_sys_recvmmsg+0xe2/0x160 net/socket.c:2951
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
value changed: 0x0000000000000000 -> 0x0000000000001000
Reported by Kernel Concurrency Sanitizer on:
CPU: 1 PID: 23037 Comm: syz-executor.2 Not tainted 6.3.0-rc4-syzkaller-00195-g5a57b48fdfcb #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023
Fixes: 9063e21fb026 ("netlink: autosize skb lengthes")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230403214643.768555-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2023-04-04 18:57:13 -07:00
2023-03-01 08:52:49 -08:00
2022-12-25 13:38:09 -08:00
2022-10-28 20:13:54 -07:00
2022-11-24 17:12:15 +01:00
2022-11-16 13:31:03 +00:00
2023-01-21 19:01:59 +01:00
2023-03-23 13:09:38 -07:00
2023-03-06 11:15:54 -08:00
2023-02-22 21:25:23 -08:00
2023-03-02 22:22:07 -08:00
2023-03-27 14:40:45 +02:00
2023-02-21 18:24:12 -08:00
2023-04-02 13:26:21 +01:00
2023-01-20 09:33:22 +00:00
2023-02-10 19:53:42 -08:00
2023-02-20 11:38:35 +00:00
2022-11-01 10:04:52 -07:00
2023-03-30 11:32:46 -07:00
2022-12-07 20:02:44 -08:00
2023-04-04 18:57:10 -07:00
2023-03-16 21:11:03 -07:00
2023-03-17 09:13:53 +01:00
2023-04-04 18:56:58 -07:00
2023-04-04 18:56:58 -07:00
2023-03-16 17:34:40 -07:00
2023-01-23 11:26:50 +00:00
2023-02-13 09:30:14 +00:00
2023-03-31 09:25:12 +01:00
2023-03-30 11:19:53 +02:00
2023-02-20 16:40:52 -08:00
2023-01-28 00:26:09 -08:00
2023-02-15 10:26:37 +00:00
2023-03-10 21:42:56 -08:00
2023-03-16 17:41:28 +00:00
2023-03-08 12:26:42 +01:00
2023-04-04 18:57:13 -07:00
2023-01-30 07:30:47 +00:00
2023-03-07 13:37:05 -08:00
2023-02-23 17:55:40 -08:00
2023-02-15 10:25:21 +00:00
2023-01-23 11:26:50 +00:00
2023-04-03 10:15:45 +01:00
2023-02-13 09:33:39 +00:00
2023-02-14 12:21:14 +01:00
2023-01-28 00:19:57 -08:00
2023-02-21 18:24:12 -08:00
2023-03-16 21:25:45 -07:00
2023-04-02 13:44:58 +01:00
2023-03-15 08:15:19 +00:00
2023-03-25 13:32:43 -07:00
2023-02-21 18:24:12 -08:00
2023-03-06 13:26:16 -08:00
2023-03-08 23:26:03 -08:00
2023-03-31 09:42:30 +01:00
2023-03-17 13:31:16 -07:00
2023-01-25 09:51:04 +00:00
2023-03-16 16:02:55 +01:00
2023-03-16 17:23:48 -07:00
2022-11-25 13:01:55 -05:00
2023-01-05 22:12:00 -08:00
2023-03-08 23:26:51 -08:00
a1865f2e7d