iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs/afs
History
David Howells f4c79144ed afs: Fix incorrect freeing of the ACL passed to the YFS ACL store op 
The cleanup for the yfs_store_opaque_acl2_operation calls the wrong
function to destroy the ACL content buffer.  It's an afs_acl struct, not
a yfs_acl struct - and the free function for latter may pass invalid
pointers to kfree().

Fix this by using the afs_acl_put() function.  The yfs_acl_put()
function is then no longer used and can be removed.

	general protection fault, probably for non-canonical address 0x7ebde00000000: 0000 [#1] SMP PTI
	...
	RIP: 0010:compound_head+0x0/0x11
	...
	Call Trace:
	 virt_to_cache+0x8/0x51
	 kfree+0x5d/0x79
	 yfs_free_opaque_acl+0x16/0x29
	 afs_put_operation+0x60/0x114
	 __vfs_setxattr+0x67/0x72
	 __vfs_setxattr_noperm+0x66/0xe9
	 vfs_setxattr+0x67/0xce
	 setxattr+0x14e/0x184
	 __do_sys_fsetxattr+0x66/0x8f
	 do_syscall_64+0x2d/0x3a
	 entry_SYSCALL_64_after_hwframe+0x44/0xa9

Fixes: e49c7b2f6de7 ("afs: Build an abstraction around an "operation" concept")
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2020-11-03 09:53:40 -08:00
..
addr_list.c
afs: Use kfree_rcu() instead of casting kfree() to rcu_callback_t
2020-03-13 10:47:33 -07:00
afs_cm.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
afs_fs.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
afs_vl.h
afs: Implement client support for the YFSVL.GetCellName RPC op
2020-06-04 15:37:57 +01:00
afs.h
afs: Implement client support for the YFSVL.GetCellName RPC op
2020-06-04 15:37:57 +01:00
cache.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152
2019-05-30 11:26:32 -07:00
callback.c
afs: Fix the by-UUID server tree to allow servers with the same UUID
2020-06-04 15:37:57 +01:00
cell.c
afs: Fix tracing deref-before-check
2020-10-27 22:05:56 +00:00
cmservice.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
dir_edit.c
afs: Fix to take ref on page when PG_private is set
2020-10-29 13:53:04 +00:00
dir_silly.c
afs: Fix silly rename
2020-06-16 22:00:28 +01:00
dir.c
afs: Fix to take ref on page when PG_private is set
2020-10-29 13:53:04 +00:00
dynroot.c
afs: Add tracing for cell refcount and active user count
2020-10-16 14:39:21 +01:00
file.c
afs: Fix afs_invalidatepage to adjust the dirty region
2020-10-29 13:53:04 +00:00
flock.c
afs: Remove erroneous fallthough annotation
2020-08-27 14:33:01 -05:00
fs_operation.c
afs: Fix key ref leak in afs_put_operation()
2020-08-20 10:41:45 -07:00
fs_probe.c
rxrpc: Make rxrpc_kernel_get_srtt() indicate validity
2020-08-20 18:21:28 +01:00
fsclient.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
inode.c
afs: Fix deadlock between writeback and truncate
2020-10-08 10:50:55 -07:00
internal.h
afs: Fix dirty-region encoding on ppc32 with 64K pages
2020-10-29 13:53:04 +00:00
Kconfig
docs: filesystems: fix renamed references
2020-04-20 15:45:22 -06:00
main.c
afs: Fix rapid cell addition/removal by not using RCU on cells tree
2020-10-16 14:04:59 +01:00
Makefile
afs: Detect cell aliases 1 - Cells with root volumes
2020-06-04 15:37:57 +01:00
misc.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
mntpt.c
afs: Add tracing for cell refcount and active user count
2020-10-16 14:39:21 +01:00
proc.c
afs: Add tracing for cell refcount and active user count
2020-10-16 14:39:21 +01:00
protocol_uae.h
afs: Add support for the UAE error table
2019-06-28 18:37:53 +01:00
protocol_yfs.h
afs: Implement client support for the YFSVL.GetCellName RPC op
2020-06-04 15:37:57 +01:00
rotate.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
rxrpc.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
security.c
treewide: Remove uninitialized_var() usage
2020-07-16 12:35:15 -07:00
server_list.c
afs: Reorganise volume and server trees to be rooted on the cell
2020-06-04 15:37:57 +01:00
server.c
afs: Don't assert on unpurgeable server records
2020-10-16 14:39:34 +01:00
super.c
afs fixes
2020-10-16 15:22:41 -07:00
vl_alias.c
afs: Add tracing for cell refcount and active user count
2020-10-16 14:39:21 +01:00
vl_list.c
afs: Don't use VL probe running state to make decisions outside probe code
2020-08-20 18:21:28 +01:00
vl_probe.c
afs: Don't use VL probe running state to make decisions outside probe code
2020-08-20 18:21:28 +01:00
vl_rotate.c
afs: Add tracing for cell refcount and active user count
2020-10-16 14:39:21 +01:00
vlclient.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
volume.c
afs: Add tracing for cell refcount and active user count
2020-10-16 14:39:21 +01:00
write.c
afs: Fix dirty-region encoding on ppc32 with 64K pages
2020-10-29 13:53:04 +00:00
xattr.c
afs: Fix incorrect freeing of the ACL passed to the YFS ACL store op
2020-11-03 09:53:40 -08:00
xdr_fs.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 36
2019-05-24 17:27:11 +02:00
yfsclient.c
afs: Fix warning due to unadvanced marshalling pointer
2020-11-03 09:53:40 -08:00