5c80c4fced
`strncpy` is deprecated for use on NUL-terminated destination strings [1] and as such we should prefer more robust and less ambiguous string interfaces. We expect `iclock->name` to be NUL-terminated based on its use within printk: | printk(KERN_DEBUG "%s: %s %d\n", __func__, iclock->name, | iclock->pri); `iclock` is zero-initialized and as such is already NUL-padded which means strncpy is doing extra work here by eagerly NUL-padding the destination buffer. Considering the above, a suitable replacement is `strscpy` [2] due to the fact that it guarantees NUL-termination on the destination buffer without unnecessarily NUL-padding. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] Link: https://github.com/KSPP/linux/issues/90 Cc: linux-hardening@vger.kernel.org Signed-off-by: Justin Stitt <justinstitt@google.com> Reviewed-by: Kees Cook <keescook@chromium.org> Link: https://lore.kernel.org/r/20230922-strncpy-drivers-isdn-misdn-clock-c-v1-1-3ba2a5ae627a@google.com Signed-off-by: Kees Cook <keescook@chromium.org> |
||
|---|---|---|
| .. | ||
| clock.c | ||
| core.c | ||
| core.h | ||
| dsp_audio.c | ||
| dsp_biquad.h | ||
| dsp_blowfish.c | ||
| dsp_cmx.c | ||
| dsp_core.c | ||
| dsp_dtmf.c | ||
| dsp_ecdis.h | ||
| dsp_hwec.c | ||
| dsp_hwec.h | ||
| dsp_pipeline.c | ||
| dsp_tones.c | ||
| dsp.h | ||
| fsm.c | ||
| fsm.h | ||
| hwchannel.c | ||
| Kconfig | ||
| l1oip_codec.c | ||
| l1oip_core.c | ||
| l1oip.h | ||
| layer1.c | ||
| layer1.h | ||
| layer2.c | ||
| layer2.h | ||
| Makefile | ||
| socket.c | ||
| stack.c | ||
| tei.c | ||
| timerdev.c | ||