d349ab99ee
The archrandom interface was originally designed for x86, which supplies RDRAND/RDSEED for receiving random words into registers, resulting in one function to generate an int and another to generate a long. However, other architectures don't follow this. On arm64, the SMCCC TRNG interface can return between one and three longs. On s390, the CPACF TRNG interface can return arbitrary amounts, with four longs having the same cost as one. On UML, the os_getrandom() interface can return arbitrary amounts. So change the api signature to take a "max_longs" parameter designating the maximum number of longs requested, and then return the number of longs generated. Since callers need to check this return value and loop anyway, each arch implementation does not bother implementing its own loop to try again to fill the maximum number of longs. Additionally, all existing callers pass in a constant max_longs parameter. Taken together, these two things mean that the codegen doesn't really change much for one-word-at-a-time platforms, while performance is greatly improved on platforms such as s390. Acked-by: Heiko Carstens <hca@linux.ibm.com> Acked-by: Catalin Marinas <catalin.marinas@arm.com> Acked-by: Mark Rutland <mark.rutland@arm.com> Acked-by: Michael Ellerman <mpe@ellerman.id.au> Acked-by: Borislav Petkov <bp@suse.de> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
63 lines
1.5 KiB
C
63 lines
1.5 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/*
|
|
* This file is part of the Linux kernel.
|
|
*
|
|
* Copyright (c) 2011-2014, Intel Corporation
|
|
* Authors: Fenghua Yu <fenghua.yu@intel.com>,
|
|
* H. Peter Anvin <hpa@linux.intel.com>
|
|
*/
|
|
|
|
#ifndef ASM_X86_ARCHRANDOM_H
|
|
#define ASM_X86_ARCHRANDOM_H
|
|
|
|
#include <asm/processor.h>
|
|
#include <asm/cpufeature.h>
|
|
|
|
#define RDRAND_RETRY_LOOPS 10
|
|
|
|
/* Unconditional execution of RDRAND and RDSEED */
|
|
|
|
static inline bool __must_check rdrand_long(unsigned long *v)
|
|
{
|
|
bool ok;
|
|
unsigned int retry = RDRAND_RETRY_LOOPS;
|
|
do {
|
|
asm volatile("rdrand %[out]"
|
|
CC_SET(c)
|
|
: CC_OUT(c) (ok), [out] "=r" (*v));
|
|
if (ok)
|
|
return true;
|
|
} while (--retry);
|
|
return false;
|
|
}
|
|
|
|
static inline bool __must_check rdseed_long(unsigned long *v)
|
|
{
|
|
bool ok;
|
|
asm volatile("rdseed %[out]"
|
|
CC_SET(c)
|
|
: CC_OUT(c) (ok), [out] "=r" (*v));
|
|
return ok;
|
|
}
|
|
|
|
/*
|
|
* These are the generic interfaces; they must not be declared if the
|
|
* stubs in <linux/random.h> are to be invoked.
|
|
*/
|
|
|
|
static inline size_t __must_check arch_get_random_longs(unsigned long *v, size_t max_longs)
|
|
{
|
|
return max_longs && static_cpu_has(X86_FEATURE_RDRAND) && rdrand_long(v) ? 1 : 0;
|
|
}
|
|
|
|
static inline size_t __must_check arch_get_random_seed_longs(unsigned long *v, size_t max_longs)
|
|
{
|
|
return max_longs && static_cpu_has(X86_FEATURE_RDSEED) && rdseed_long(v) ? 1 : 0;
|
|
}
|
|
|
|
#ifndef CONFIG_UML
|
|
void x86_init_rdrand(struct cpuinfo_x86 *c);
|
|
#endif
|
|
|
|
#endif /* ASM_X86_ARCHRANDOM_H */
|