Eric Dumazet 424f8416bb net: skb_partial_csum_set() fix against transport header magic value ... skb->transport_header uses the special 0xFFFF value to mark if the transport header was set or not. We must prevent callers to accidentaly set skb->transport_header to 0xFFFF. Note that only fuzzers can possibly do this today. syzbot reported: WARNING: CPU: 0 PID: 2340 at include/linux/skbuff.h:2847 skb_transport_offset include/linux/skbuff.h:2956 [inline] WARNING: CPU: 0 PID: 2340 at include/linux/skbuff.h:2847 virtio_net_hdr_to_skb+0xbcc/0x10c0 include/linux/virtio_net.h:103 Modules linked in: CPU: 0 PID: 2340 Comm: syz-executor.0 Not tainted 6.3.0-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/14/2023 RIP: 0010:skb_transport_header include/linux/skbuff.h:2847 [inline] RIP: 0010:skb_transport_offset include/linux/skbuff.h:2956 [inline] RIP: 0010:virtio_net_hdr_to_skb+0xbcc/0x10c0 include/linux/virtio_net.h:103 Code: 41 39 df 0f 82 c3 04 00 00 48 8b 7c 24 10 44 89 e6 e8 08 6e 59 ff 48 85 c0 74 54 e8 ce 36 7e fc e9 37 f8 ff ff e8 c4 36 7e fc <0f> 0b e9 93 f8 ff ff 44 89 f7 44 89 e6 e8 32 38 7e fc 45 39 e6 0f RSP: 0018:ffffc90004497880 EFLAGS: 00010293 RAX: ffffffff84fea55c RBX: 000000000000ffff RCX: ffff888120be2100 RDX: 0000000000000000 RSI: 000000000000ffff RDI: 000000000000ffff RBP: ffffc90004497990 R08: ffffffff84fe9de5 R09: 0000000000000034 R10: ffffea00048ebd80 R11: 0000000000000034 R12: ffff88811dc2d9c8 R13: dffffc0000000000 R14: ffff88811dc2d9ae R15: 1ffff11023b85b35 FS: 00007f9211a59700(0000) GS:ffff8881f6c00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000000200002c0 CR3: 00000001215a5000 CR4: 00000000003506f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: <TASK> packet_snd net/packet/af_packet.c:3076 [inline] packet_sendmsg+0x4590/0x61a0 net/packet/af_packet.c:3115 sock_sendmsg_nosec net/socket.c:724 [inline] sock_sendmsg net/socket.c:747 [inline] __sys_sendto+0x472/0x630 net/socket.c:2144 __do_sys_sendto net/socket.c:2156 [inline] __se_sys_sendto net/socket.c:2152 [inline] __x64_sys_sendto+0xe5/0x100 net/socket.c:2152 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x2f/0x50 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f9210c8c169 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f9211a59168 EFLAGS: 00000246 ORIG_RAX: 000000000000002c RAX: ffffffffffffffda RBX: 00007f9210dabf80 RCX: 00007f9210c8c169 RDX: 000000000000ffed RSI: 00000000200000c0 RDI: 0000000000000003 RBP: 00007f9210ce7ca1 R08: 0000000020000540 R09: 0000000000000014 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffe135d65cf R14: 00007f9211a59300 R15: 0000000000022000 Fixes: 66e4c8d950 ("net: warn if transport header was not set") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: syzbot <syzkaller@googlegroups.com> Cc: Willem de Bruijn <willemb@google.com> Reviewed-by: Willem de Bruijn <willemb@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2023-05-07 14:55:37 +01:00
..
bpf_sk_storage.c	bpf: Teach verifier that certain helpers accept NULL pointer.	2023-04-04 16:57:16 -07:00
datagram.c	net-zerocopy: Reduce compound page head access	2023-03-22 15:34:31 +01:00
dev_addr_lists_test.c	kunit: Use KUNIT_EXPECT_MEMEQ macro	2022-10-27 02:40:14 -06:00
dev_addr_lists.c	net: extract a few internals from netdevice.h	2022-04-07 20:32:09 -07:00
dev_ioctl.c	net: dsa: replace NETDEV_PRE_CHANGE_HWTSTAMP notifier with a stub	2023-04-09 15:35:49 +01:00
dev.c	net: optimize napi_threaded_poll() vs RPS/RFS	2023-04-23 13:35:07 +01:00
dev.h	net-sysctl: factor-out rpm mask manipulation helpers	2023-02-09 17:45:55 -08:00
drop_monitor.c	net: extend drop reasons for multiple subsystems	2023-04-20 20:20:49 -07:00
dst_cache.c	wireguard: device: reset peer src endpoint when netns exits	2021-11-29 19:50:45 -08:00
dst.c	net: dst: fix missing initialization of rt_uncached	2023-04-21 20:26:56 -07:00
failover.c	net: failover: use IFF_NO_ADDRCONF flag to prevent ipv6 addrconf	2022-12-12 15:18:25 -08:00
fib_notifier.c
fib_rules.c	fib: expand fib_rule_policy	2021-12-16 07:18:35 -08:00
filter.c	bpf: minimal support for programs hooked into netfilter framework	2023-04-21 11:34:14 -07:00
flow_dissector.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-11-29 13:04:52 -08:00
flow_offload.c	net: flow_offload: add support for ARP frame matching	2022-11-14 11:24:16 +00:00
gen_estimator.c	treewide: Convert del_timer*() to timer_shutdown*()	2022-12-25 13:38:09 -08:00
gen_stats.c	net: Remove the obsolte u64_stats_fetch_*_irq() users (net).	2022-10-28 20:13:54 -07:00
gro_cells.c	net: drop the weight argument from netif_napi_add	2022-09-28 18:57:14 -07:00
gro.c	net: skbuff: update and rename __kfree_skb_defer()	2023-04-20 19:25:08 -07:00
hwbm.c
link_watch.c	net: linkwatch: only report IF_OPER_LOWERLAYERDOWN if iflink is actually down	2022-11-16 09:45:00 +00:00
lwt_bpf.c	bpf, lwt: Fix crash when using bpf_skb_set_tunnel_key() from bpf_xmit lwt hook	2022-04-22 17:45:25 +02:00
lwtunnel.c	xfrm: lwtunnel: squelch kernel warning in case XFRM encap type is not available	2022-10-12 10:45:51 +02:00
Makefile	netdev-genl: create a simple family for netdev stuff	2023-02-02 20:48:23 -08:00
neighbour.c	neighbour: switch to standard rcu, instead of rcu_bh	2023-03-21 21:32:18 -07:00
net_namespace.c	kill the last remaining user of proc_ns_fget()	2023-04-20 22:55:35 -04:00
net-procfs.c	net-sysfs: display two backlog queue len separately	2023-03-22 12:03:52 +01:00
net-sysfs.c	net: make default_rps_mask a per netns attribute	2023-02-20 11:22:54 +00:00
net-sysfs.h
net-traces.c	net: bridge: Add a tracepoint for MDB overflows	2023-02-06 08:48:25 +00:00
netclassid_cgroup.c	core: Variable type completion	2022-08-31 09:40:34 +01:00
netdev-genl-gen.c	tools: ynl: skip the explicit op array size when not needed	2023-03-21 21:45:31 -07:00
netdev-genl-gen.h	ynl: broaden the license even more	2023-03-16 21:20:32 -07:00
netdev-genl.c	netdev-genl: create a simple family for netdev stuff	2023-02-02 20:48:23 -08:00
netevent.c
netpoll.c	net: don't let netpoll invoke NAPI if in xmit context	2023-04-02 13:26:21 +01:00
netprio_cgroup.c
of_net.c	of: net: export of_get_mac_address_nvmem()	2022-11-29 10:45:53 +01:00
page_pool.c	page_pool: unlink from napi during destroy	2023-04-20 19:13:37 -07:00
pktgen.c	treewide: use get_random_u32_inclusive() when possible	2022-11-18 02:18:02 +01:00
ptp_classifier.c	ptp: Add generic PTP is_sync() function	2022-03-07 11:31:34 +00:00
request_sock.c
rtnetlink.c	bridge: Allow setting per-{Port, VLAN} neighbor suppression state	2023-04-21 08:25:50 +01:00
scm.c	net: Ensure ->msg_control_user is used for user buffers	2023-04-14 11:09:27 +01:00
secure_seq.c	tcp: Fix data-races around sysctl knobs related to SYN option.	2022-07-20 10:14:49 +01:00
selftests.c
skbuff.c	net: skb_partial_csum_set() fix against transport header magic value	2023-05-07 14:55:37 +01:00
skmsg.c	net/sock: Introduce trace_sk_data_ready()	2023-01-23 11:26:50 +00:00
sock_destructor.h
sock_diag.c	net: fix __sock_gen_cookie()	2022-11-21 20:36:30 -08:00
sock_map.c	bpf, sockmap: Revert buggy deadlock fix in the sockhash and sockmap	2023-04-13 20:36:32 +02:00
sock_reuseport.c	soreuseport: Fix socket selection for SO_INCOMING_CPU.	2022-10-25 11:35:16 +02:00
sock.c	net: make SO_BUSY_POLL available to all users	2023-04-07 20:07:07 -07:00
stream.c	net: Remove WARN_ON_ONCE(sk->sk_forward_alloc) from sk_stream_kill_queues().	2023-02-10 19:53:42 -08:00
sysctl_net_core.c	net/sysctl: Rename kvfree_rcu() to kvfree_rcu_mightsleep()	2023-04-05 13:48:04 +00:00
timestamping.c
tso.c	net: tso: inline tso_count_descs()	2022-12-12 15:04:39 -08:00
utils.c	net: core: inet[46]_pton strlen len types	2022-11-01 21:14:39 -07:00
xdp.c	bpf-next-for-netdev	2023-04-13 16:43:38 -07:00