3fd269e74f
All amba drivers return 0 in their remove callback. Together with the driver core ignoring the return value anyhow, it doesn't make sense to return a value here. Change the remove prototype to return void, which makes it explicit that returning an error value doesn't work as expected. This simplifies changing the core remove callback to return void, too. Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org> Reviewed-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Acked-by: Krzysztof Kozlowski <krzk@kernel.org> # for drivers/memory Acked-by: Mark Brown <broonie@kernel.org> Acked-by: Linus Walleij <linus.walleij@linaro.org> Acked-by: Suzuki K Poulose <suzuki.poulose@arm.com> # for hwtracing/coresight Acked-By: Vinod Koul <vkoul@kernel.org> # for dmaengine Acked-by: Guenter Roeck <linux@roeck-us.net> # for watchdog Acked-by: Wolfram Sang <wsa@kernel.org> # for I2C Acked-by: Takashi Iwai <tiwai@suse.de> # for sound Acked-by: Vladimir Zapolskiy <vz@mleia.com> # for memory/pl172 Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Link: https://lore.kernel.org/r/20210126165835.687514-5-u.kleine-koenig@pengutronix.de Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
105 lines
2.2 KiB
C
105 lines
2.2 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (C) 2013 - Virtual Open Systems
|
|
* Author: Antonios Motakis <a.motakis@virtualopensystems.com>
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/vfio.h>
|
|
#include <linux/amba/bus.h>
|
|
|
|
#include "vfio_platform_private.h"
|
|
|
|
#define DRIVER_VERSION "0.10"
|
|
#define DRIVER_AUTHOR "Antonios Motakis <a.motakis@virtualopensystems.com>"
|
|
#define DRIVER_DESC "VFIO for AMBA devices - User Level meta-driver"
|
|
|
|
/* probing devices from the AMBA bus */
|
|
|
|
static struct resource *get_amba_resource(struct vfio_platform_device *vdev,
|
|
int i)
|
|
{
|
|
struct amba_device *adev = (struct amba_device *) vdev->opaque;
|
|
|
|
if (i == 0)
|
|
return &adev->res;
|
|
|
|
return NULL;
|
|
}
|
|
|
|
static int get_amba_irq(struct vfio_platform_device *vdev, int i)
|
|
{
|
|
struct amba_device *adev = (struct amba_device *) vdev->opaque;
|
|
int ret = 0;
|
|
|
|
if (i < AMBA_NR_IRQS)
|
|
ret = adev->irq[i];
|
|
|
|
/* zero is an unset IRQ for AMBA devices */
|
|
return ret ? ret : -ENXIO;
|
|
}
|
|
|
|
static int vfio_amba_probe(struct amba_device *adev, const struct amba_id *id)
|
|
{
|
|
struct vfio_platform_device *vdev;
|
|
int ret;
|
|
|
|
vdev = kzalloc(sizeof(*vdev), GFP_KERNEL);
|
|
if (!vdev)
|
|
return -ENOMEM;
|
|
|
|
vdev->name = kasprintf(GFP_KERNEL, "vfio-amba-%08x", adev->periphid);
|
|
if (!vdev->name) {
|
|
kfree(vdev);
|
|
return -ENOMEM;
|
|
}
|
|
|
|
vdev->opaque = (void *) adev;
|
|
vdev->flags = VFIO_DEVICE_FLAGS_AMBA;
|
|
vdev->get_resource = get_amba_resource;
|
|
vdev->get_irq = get_amba_irq;
|
|
vdev->parent_module = THIS_MODULE;
|
|
vdev->reset_required = false;
|
|
|
|
ret = vfio_platform_probe_common(vdev, &adev->dev);
|
|
if (ret) {
|
|
kfree(vdev->name);
|
|
kfree(vdev);
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
static void vfio_amba_remove(struct amba_device *adev)
|
|
{
|
|
struct vfio_platform_device *vdev =
|
|
vfio_platform_remove_common(&adev->dev);
|
|
|
|
kfree(vdev->name);
|
|
kfree(vdev);
|
|
}
|
|
|
|
static const struct amba_id pl330_ids[] = {
|
|
{ 0, 0 },
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(amba, pl330_ids);
|
|
|
|
static struct amba_driver vfio_amba_driver = {
|
|
.probe = vfio_amba_probe,
|
|
.remove = vfio_amba_remove,
|
|
.id_table = pl330_ids,
|
|
.drv = {
|
|
.name = "vfio-amba",
|
|
.owner = THIS_MODULE,
|
|
},
|
|
};
|
|
|
|
module_amba_driver(vfio_amba_driver);
|
|
|
|
MODULE_VERSION(DRIVER_VERSION);
|
|
MODULE_LICENSE("GPL v2");
|
|
MODULE_AUTHOR(DRIVER_AUTHOR);
|
|
MODULE_DESCRIPTION(DRIVER_DESC);
|