899f679146
The st_magn_allocate_ring() function calls iio_triggered_buffer_setup() to
allocate a triggered buffer.
But the same can be done with devm_iio_triggered_buffer_setup() and then
the st_magn_common_remove() no longer needs to manually deallocate it.
We know that the parent of the IIO device is used to manage other instances
of the devm unwind, so it can be used in the st_magn_allocate_ring() as
well.
This change also removes some omitted st_magn_{probe,remove}_trigger()
inline hooks.
Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
Link: https://lore.kernel.org/r/20210720074642.223293-3-aardelean@deviqon.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
51 lines
1.3 KiB
C
51 lines
1.3 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* STMicroelectronics magnetometers driver
|
|
*
|
|
* Copyright 2012-2013 STMicroelectronics Inc.
|
|
*
|
|
* Denis Ciocca <denis.ciocca@st.com>
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/iio/iio.h>
|
|
#include <linux/iio/buffer.h>
|
|
#include <linux/iio/trigger.h>
|
|
#include <linux/iio/triggered_buffer.h>
|
|
|
|
#include <linux/iio/common/st_sensors.h>
|
|
#include "st_magn.h"
|
|
|
|
int st_magn_trig_set_state(struct iio_trigger *trig, bool state)
|
|
{
|
|
struct iio_dev *indio_dev = iio_trigger_get_drvdata(trig);
|
|
|
|
return st_sensors_set_dataready_irq(indio_dev, state);
|
|
}
|
|
|
|
static int st_magn_buffer_postenable(struct iio_dev *indio_dev)
|
|
{
|
|
return st_sensors_set_enable(indio_dev, true);
|
|
}
|
|
|
|
static int st_magn_buffer_predisable(struct iio_dev *indio_dev)
|
|
{
|
|
return st_sensors_set_enable(indio_dev, false);
|
|
}
|
|
|
|
static const struct iio_buffer_setup_ops st_magn_buffer_setup_ops = {
|
|
.postenable = &st_magn_buffer_postenable,
|
|
.predisable = &st_magn_buffer_predisable,
|
|
};
|
|
|
|
int st_magn_allocate_ring(struct iio_dev *indio_dev)
|
|
{
|
|
return devm_iio_triggered_buffer_setup(indio_dev->dev.parent, indio_dev,
|
|
NULL, &st_sensors_trigger_handler, &st_magn_buffer_setup_ops);
|
|
}
|
|
|
|
MODULE_AUTHOR("Denis Ciocca <denis.ciocca@st.com>");
|
|
MODULE_DESCRIPTION("STMicroelectronics magnetometers buffer");
|
|
MODULE_LICENSE("GPL v2");
|