linux

iv/linux

History

Jens Axboe f3da54ba14 Fix race with shared tag queue maps

There's a race condition in blk_queue_end_tag() for shared tag maps,
users include stex (promise supertrak thingy) and qla2xxx.  The former
at least has reported bugs in this area, not sure why we haven't seen
any for the latter.  It could be because the window is narrow and that
other conditions in the qla2xxx code hide this.  It's a real bug,
though, as the stex smp users can attest.

We need to ensure two things - the tag bit clearing needs to happen
AFTER we cleared the tag pointer, as the tag bit clearing/setting is
what protects this map.  Secondly, we need to ensure that the visibility
of the tag pointer and tag bit clear are ordered properly.

[ I removed the SMP barriers - "test_and_clear_bit()" already implies
  all the required barriers.  -- Linus ]

Also see http://bugzilla.kernel.org/show_bug.cgi?id=7842

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

2007-09-13 08:20:25 -07:00

as-iosched.c

[BLOCK] Get rid of request_queue_t typedef

2007-07-24 09:28:11 +02:00

blktrace.c

blktrace: use cpu_clock() instead of sched_clock()

2007-07-27 08:08:24 +02:00

bsg.c

[SCSI] bsg: update sg_io_v4 structure

2007-07-31 10:43:05 -05:00

cfq-iosched.c

[BLOCK] Get rid of request_queue_t typedef