b5d68f84f4
If cur_state for the powerclamp cooling device is set to the default
minimum state of 0, without setting first to cur_state > 0, this results
in NULL pointer access.
This NULL pointer access happens in the powercap core idle-inject
function idle_inject_set_duration() as there is no NULL check for
idle_inject_device pointer. This pointer must be allocated by calling
idle_inject_register() or idle_inject_register_full().
In the function powerclamp_set_cur_state(), idle_inject_device pointer
is allocated only when the cur_state > 0. But setting 0 without changing
to any other state, idle_inject_set_duration() will be called with a
NULL idle_inject_device pointer.
To address this, just return from powerclamp_set_cur_state() if the
current cooling device state is the same as the last one. Since the
power-up default cooling device state is 0, changing the state to 0
again here will return without calling idle_inject_set_duration().
Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Fixes:
|
||
|---|---|---|
| .. | ||
| int340x_thermal | ||
| intel_bxt_pmic_thermal.c | ||
| intel_hfi.c | ||
| intel_hfi.h | ||
| intel_pch_thermal.c | ||
| intel_powerclamp.c | ||
| intel_quark_dts_thermal.c | ||
| intel_soc_dts_iosf.c | ||
| intel_soc_dts_iosf.h | ||
| intel_soc_dts_thermal.c | ||
| intel_tcc_cooling.c | ||
| intel_tcc.c | ||
| Kconfig | ||
| Makefile | ||
| therm_throt.c | ||
| thermal_interrupt.h | ||
| x86_pkg_temp_thermal.c | ||