8609f5cfdc
ADF_STATUS_PF_RUNNING is (only) used and checked by adf_vf2pf_shutdown()
before calling adf_iov_putmsg()->mutex_lock(vf2pf_lock), however the
vf2pf_lock is initialized in adf_dev_init(), which can fail and when it
fail, the vf2pf_lock is either not initialized or destroyed, a subsequent
use of vf2pf_lock will cause issue.
To fix this issue, only set this flag if adf_dev_init() returns 0.
[ 7.178404] BUG: KASAN: user-memory-access in __mutex_lock.isra.0+0x1ac/0x7c0
[ 7.180345] Call Trace:
[ 7.182576] mutex_lock+0xc9/0xd0
[ 7.183257] adf_iov_putmsg+0x118/0x1a0 [intel_qat]
[ 7.183541] adf_vf2pf_shutdown+0x4d/0x7b [intel_qat]
[ 7.183834] adf_dev_shutdown+0x172/0x2b0 [intel_qat]
[ 7.184127] adf_probe+0x5e9/0x600 [qat_dh895xccvf]
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Fixes: 25c6ffb249
("crypto: qat - check if PF is running")
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
252 lines
6.3 KiB
C
252 lines
6.3 KiB
C
// SPDX-License-Identifier: (BSD-3-Clause OR GPL-2.0-only)
|
|
/* Copyright(c) 2014 - 2020 Intel Corporation */
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/pci.h>
|
|
#include <linux/init.h>
|
|
#include <linux/types.h>
|
|
#include <linux/fs.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/errno.h>
|
|
#include <linux/device.h>
|
|
#include <linux/dma-mapping.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/workqueue.h>
|
|
#include <linux/io.h>
|
|
#include <adf_accel_devices.h>
|
|
#include <adf_common_drv.h>
|
|
#include <adf_cfg.h>
|
|
#include "adf_c3xxxvf_hw_data.h"
|
|
|
|
static const struct pci_device_id adf_pci_tbl[] = {
|
|
{ PCI_VDEVICE(INTEL, PCI_DEVICE_ID_INTEL_QAT_C3XXX_VF), },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(pci, adf_pci_tbl);
|
|
|
|
static int adf_probe(struct pci_dev *dev, const struct pci_device_id *ent);
|
|
static void adf_remove(struct pci_dev *dev);
|
|
|
|
static struct pci_driver adf_driver = {
|
|
.id_table = adf_pci_tbl,
|
|
.name = ADF_C3XXXVF_DEVICE_NAME,
|
|
.probe = adf_probe,
|
|
.remove = adf_remove,
|
|
};
|
|
|
|
static void adf_cleanup_pci_dev(struct adf_accel_dev *accel_dev)
|
|
{
|
|
pci_release_regions(accel_dev->accel_pci_dev.pci_dev);
|
|
pci_disable_device(accel_dev->accel_pci_dev.pci_dev);
|
|
}
|
|
|
|
static void adf_cleanup_accel(struct adf_accel_dev *accel_dev)
|
|
{
|
|
struct adf_accel_pci *accel_pci_dev = &accel_dev->accel_pci_dev;
|
|
struct adf_accel_dev *pf;
|
|
int i;
|
|
|
|
for (i = 0; i < ADF_PCI_MAX_BARS; i++) {
|
|
struct adf_bar *bar = &accel_pci_dev->pci_bars[i];
|
|
|
|
if (bar->virt_addr)
|
|
pci_iounmap(accel_pci_dev->pci_dev, bar->virt_addr);
|
|
}
|
|
|
|
if (accel_dev->hw_device) {
|
|
switch (accel_pci_dev->pci_dev->device) {
|
|
case PCI_DEVICE_ID_INTEL_QAT_C3XXX_VF:
|
|
adf_clean_hw_data_c3xxxiov(accel_dev->hw_device);
|
|
break;
|
|
default:
|
|
break;
|
|
}
|
|
kfree(accel_dev->hw_device);
|
|
accel_dev->hw_device = NULL;
|
|
}
|
|
adf_cfg_dev_remove(accel_dev);
|
|
debugfs_remove(accel_dev->debugfs_dir);
|
|
pf = adf_devmgr_pci_to_accel_dev(accel_pci_dev->pci_dev->physfn);
|
|
adf_devmgr_rm_dev(accel_dev, pf);
|
|
}
|
|
|
|
static int adf_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
|
|
{
|
|
struct adf_accel_dev *accel_dev;
|
|
struct adf_accel_dev *pf;
|
|
struct adf_accel_pci *accel_pci_dev;
|
|
struct adf_hw_device_data *hw_data;
|
|
char name[ADF_DEVICE_NAME_LENGTH];
|
|
unsigned int i, bar_nr;
|
|
unsigned long bar_mask;
|
|
int ret;
|
|
|
|
switch (ent->device) {
|
|
case PCI_DEVICE_ID_INTEL_QAT_C3XXX_VF:
|
|
break;
|
|
default:
|
|
dev_err(&pdev->dev, "Invalid device 0x%x.\n", ent->device);
|
|
return -ENODEV;
|
|
}
|
|
|
|
accel_dev = kzalloc_node(sizeof(*accel_dev), GFP_KERNEL,
|
|
dev_to_node(&pdev->dev));
|
|
if (!accel_dev)
|
|
return -ENOMEM;
|
|
|
|
accel_dev->is_vf = true;
|
|
pf = adf_devmgr_pci_to_accel_dev(pdev->physfn);
|
|
accel_pci_dev = &accel_dev->accel_pci_dev;
|
|
accel_pci_dev->pci_dev = pdev;
|
|
|
|
/* Add accel device to accel table */
|
|
if (adf_devmgr_add_dev(accel_dev, pf)) {
|
|
dev_err(&pdev->dev, "Failed to add new accelerator device.\n");
|
|
kfree(accel_dev);
|
|
return -EFAULT;
|
|
}
|
|
INIT_LIST_HEAD(&accel_dev->crypto_list);
|
|
|
|
accel_dev->owner = THIS_MODULE;
|
|
/* Allocate and configure device configuration structure */
|
|
hw_data = kzalloc_node(sizeof(*hw_data), GFP_KERNEL,
|
|
dev_to_node(&pdev->dev));
|
|
if (!hw_data) {
|
|
ret = -ENOMEM;
|
|
goto out_err;
|
|
}
|
|
accel_dev->hw_device = hw_data;
|
|
adf_init_hw_data_c3xxxiov(accel_dev->hw_device);
|
|
|
|
/* Get Accelerators and Accelerators Engines masks */
|
|
hw_data->accel_mask = hw_data->get_accel_mask(hw_data);
|
|
hw_data->ae_mask = hw_data->get_ae_mask(hw_data);
|
|
accel_pci_dev->sku = hw_data->get_sku(hw_data);
|
|
|
|
/* Create dev top level debugfs entry */
|
|
snprintf(name, sizeof(name), "%s%s_%s", ADF_DEVICE_NAME_PREFIX,
|
|
hw_data->dev_class->name, pci_name(pdev));
|
|
|
|
accel_dev->debugfs_dir = debugfs_create_dir(name, NULL);
|
|
|
|
/* Create device configuration table */
|
|
ret = adf_cfg_dev_add(accel_dev);
|
|
if (ret)
|
|
goto out_err;
|
|
|
|
/* enable PCI device */
|
|
if (pci_enable_device(pdev)) {
|
|
ret = -EFAULT;
|
|
goto out_err;
|
|
}
|
|
|
|
/* set dma identifier */
|
|
if (pci_set_dma_mask(pdev, DMA_BIT_MASK(64))) {
|
|
if ((pci_set_dma_mask(pdev, DMA_BIT_MASK(32)))) {
|
|
dev_err(&pdev->dev, "No usable DMA configuration\n");
|
|
ret = -EFAULT;
|
|
goto out_err_disable;
|
|
} else {
|
|
pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));
|
|
}
|
|
|
|
} else {
|
|
pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(64));
|
|
}
|
|
|
|
if (pci_request_regions(pdev, ADF_C3XXXVF_DEVICE_NAME)) {
|
|
ret = -EFAULT;
|
|
goto out_err_disable;
|
|
}
|
|
|
|
/* Find and map all the device's BARS */
|
|
i = 0;
|
|
bar_mask = pci_select_bars(pdev, IORESOURCE_MEM);
|
|
for_each_set_bit(bar_nr, &bar_mask, ADF_PCI_MAX_BARS * 2) {
|
|
struct adf_bar *bar = &accel_pci_dev->pci_bars[i++];
|
|
|
|
bar->base_addr = pci_resource_start(pdev, bar_nr);
|
|
if (!bar->base_addr)
|
|
break;
|
|
bar->size = pci_resource_len(pdev, bar_nr);
|
|
bar->virt_addr = pci_iomap(accel_pci_dev->pci_dev, bar_nr, 0);
|
|
if (!bar->virt_addr) {
|
|
dev_err(&pdev->dev, "Failed to map BAR %d\n", bar_nr);
|
|
ret = -EFAULT;
|
|
goto out_err_free_reg;
|
|
}
|
|
}
|
|
pci_set_master(pdev);
|
|
/* Completion for VF2PF request/response message exchange */
|
|
init_completion(&accel_dev->vf.iov_msg_completion);
|
|
|
|
ret = qat_crypto_dev_config(accel_dev);
|
|
if (ret)
|
|
goto out_err_free_reg;
|
|
|
|
ret = adf_dev_init(accel_dev);
|
|
if (ret)
|
|
goto out_err_dev_shutdown;
|
|
|
|
set_bit(ADF_STATUS_PF_RUNNING, &accel_dev->status);
|
|
|
|
ret = adf_dev_start(accel_dev);
|
|
if (ret)
|
|
goto out_err_dev_stop;
|
|
|
|
return ret;
|
|
|
|
out_err_dev_stop:
|
|
adf_dev_stop(accel_dev);
|
|
out_err_dev_shutdown:
|
|
adf_dev_shutdown(accel_dev);
|
|
out_err_free_reg:
|
|
pci_release_regions(accel_pci_dev->pci_dev);
|
|
out_err_disable:
|
|
pci_disable_device(accel_pci_dev->pci_dev);
|
|
out_err:
|
|
adf_cleanup_accel(accel_dev);
|
|
kfree(accel_dev);
|
|
return ret;
|
|
}
|
|
|
|
static void adf_remove(struct pci_dev *pdev)
|
|
{
|
|
struct adf_accel_dev *accel_dev = adf_devmgr_pci_to_accel_dev(pdev);
|
|
|
|
if (!accel_dev) {
|
|
pr_err("QAT: Driver removal failed\n");
|
|
return;
|
|
}
|
|
adf_dev_stop(accel_dev);
|
|
adf_dev_shutdown(accel_dev);
|
|
adf_cleanup_accel(accel_dev);
|
|
adf_cleanup_pci_dev(accel_dev);
|
|
kfree(accel_dev);
|
|
}
|
|
|
|
static int __init adfdrv_init(void)
|
|
{
|
|
request_module("intel_qat");
|
|
|
|
if (pci_register_driver(&adf_driver)) {
|
|
pr_err("QAT: Driver initialization failed\n");
|
|
return -EFAULT;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
static void __exit adfdrv_release(void)
|
|
{
|
|
pci_unregister_driver(&adf_driver);
|
|
adf_clean_vf_map(true);
|
|
}
|
|
|
|
module_init(adfdrv_init);
|
|
module_exit(adfdrv_release);
|
|
|
|
MODULE_LICENSE("Dual BSD/GPL");
|
|
MODULE_AUTHOR("Intel");
|
|
MODULE_DESCRIPTION("Intel(R) QuickAssist Technology");
|
|
MODULE_VERSION(ADF_DRV_VERSION);
|