Remi Pommarel
04c5d1c5d1
mac80211: mesh: Free pending skb when destroying a mpath ...
[ Upstream commit 5e43540c2af0a0c0a18e39579b1ad49541f87506 ]
A mpath object can hold reference on a list of skb that are waiting for
mpath resolution to be sent. When destroying a mpath this skb list
should be cleaned up in order to not leak memory.
Fixing that kind of leak:
unreferenced object 0xffff0000181c9300 (size 1088):
comm "openvpn", pid 1782, jiffies 4295071698 (age 80.416s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 f9 80 36 00 00 00 00 00 ..........6.....
02 00 07 40 00 00 00 00 00 00 00 00 00 00 00 00 ...@............
backtrace:
[<000000004bc6a443>] kmem_cache_alloc+0x1a4/0x2f0
[<000000002caaef13>] sk_prot_alloc.isra.39+0x34/0x178
[<00000000ceeaa916>] sk_alloc+0x34/0x228
[<00000000ca1f1d04>] inet_create+0x198/0x518
[<0000000035626b1c>] __sock_create+0x134/0x328
[<00000000a12b3a87>] __sys_socket+0xb0/0x158
[<00000000ff859f23>] __arm64_sys_socket+0x40/0x58
[<00000000263486ec>] el0_svc_handler+0xd0/0x1a0
[<0000000005b5157d>] el0_svc+0x8/0xc
unreferenced object 0xffff000012973a40 (size 216):
comm "openvpn", pid 1782, jiffies 4295082137 (age 38.660s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 c0 06 16 00 00 ff ff 00 93 1c 18 00 00 ff ff ................
backtrace:
[<000000004bc6a443>] kmem_cache_alloc+0x1a4/0x2f0
[<0000000023c8c8f9>] __alloc_skb+0xc0/0x2b8
[<000000007ad950bb>] alloc_skb_with_frags+0x60/0x320
[<00000000ef90023a>] sock_alloc_send_pskb+0x388/0x3c0
[<00000000104fb1a3>] sock_alloc_send_skb+0x1c/0x28
[<000000006919d2dd>] __ip_append_data+0xba4/0x11f0
[<0000000083477587>] ip_make_skb+0x14c/0x1a8
[<0000000024f3d592>] udp_sendmsg+0xaf0/0xcf0
[<000000005aabe255>] inet_sendmsg+0x5c/0x80
[<000000008651ea08>] __sys_sendto+0x15c/0x218
[<000000003505c99b>] __arm64_sys_sendto+0x74/0x90
[<00000000263486ec>] el0_svc_handler+0xd0/0x1a0
[<0000000005b5157d>] el0_svc+0x8/0xc
Fixes: 2bdaf386f99c (mac80211: mesh: move path tables into if_mesh)
Signed-off-by: Remi Pommarel <repk@triplefau.lt>
Link: https://lore.kernel.org/r/20200704135419.27703-1-repk@triplefau.lt
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-08-21 11:01:51 +02:00
2020-01-29 10:24:22 +01:00
2020-08-21 11:01:48 +02:00
2020-01-12 11:24:27 +01:00
2019-12-21 10:41:45 +01:00
2019-04-27 09:34:40 +02:00
2020-07-31 16:44:06 +02:00
2020-05-20 08:15:29 +02:00
2020-06-20 10:24:14 +02:00
2020-06-03 08:16:45 +02:00
2019-05-08 07:19:07 +02:00
2019-07-10 09:55:33 +02:00
2020-06-03 08:16:41 +02:00
2020-07-31 16:44:06 +02:00
2018-09-19 22:47:15 +02:00
2020-05-20 08:15:30 +02:00
2019-12-05 15:35:12 +01:00
2018-07-22 14:27:39 +02:00
2020-04-13 10:32:53 +02:00
2020-01-12 11:24:19 +01:00
2020-04-24 07:59:02 +02:00
2020-03-20 09:07:39 +01:00
2020-07-31 16:44:06 +02:00
2020-07-31 16:44:07 +02:00
2017-05-25 15:44:41 +02:00
2018-09-15 09:43:01 +02:00
2020-01-29 10:24:26 +01:00
2019-04-17 08:36:44 +02:00
2019-09-16 08:19:32 +02:00
2020-07-22 09:10:47 +02:00
2019-06-22 08:17:22 +02:00
2020-07-22 09:10:47 +02:00
2020-08-21 11:01:51 +02:00
2018-09-09 20:01:19 +02:00
2020-05-20 08:15:30 +02:00
2016-10-20 11:23:08 -04:00
2020-07-09 09:35:57 +02:00
2020-05-20 08:15:39 +02:00
2020-07-22 09:10:48 +02:00
2020-05-02 17:23:08 +02:00
2020-03-20 09:07:40 +01:00
2019-12-21 10:42:23 +01:00
2020-01-29 10:24:35 +01:00
2019-03-23 13:19:44 +01:00
2020-06-03 08:16:29 +02:00
2020-08-21 11:01:49 +02:00
2020-01-12 11:24:23 +01:00
2019-04-03 06:24:14 +02:00
2020-07-31 16:44:06 +02:00
2020-06-30 15:38:37 -04:00
2020-06-30 15:38:39 -04:00
2018-04-29 11:32:02 +02:00
2020-06-30 15:38:45 -04:00
2016-10-19 10:58:04 -04:00
2020-05-20 08:15:30 +02:00
2019-11-28 18:28:28 +01:00
2020-06-11 09:22:21 +02:00
2020-03-20 09:07:57 +01:00
2020-08-21 11:01:50 +02:00
2020-06-03 08:16:44 +02:00
2019-01-09 16:16:41 +01:00
2020-05-27 16:42:00 +02:00
2016-10-06 09:52:23 -07:00
04c5d1c5d1