iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs/afs
History
Marc Dionne 4882a27cec afs: Don't set vnode->cb_s_break in afs_validate() 
A cb_interest record is not necessarily attached to the vnode on entry to
afs_validate(), which can cause an oops when we try to bring the vnode's
cb_s_break up to date in the default case (ie. no current callback promise
and the vnode has not been deleted).

Fix this by simply removing the line, as vnode->cb_s_break will be set when
needed by afs_register_server_cb_interest() when we next get a callback
promise from RPC call.

The oops looks something like:

    BUG: unable to handle kernel NULL pointer dereference at 0000000000000018
    ...
    RIP: 0010:afs_validate+0x66/0x250 [kafs]
    ...
    Call Trace:
     afs_d_revalidate+0x8d/0x340 [kafs]
     ? __d_lookup+0x61/0x150
     lookup_dcache+0x44/0x70
     ? lookup_dcache+0x44/0x70
     __lookup_hash+0x24/0xa0
     do_unlinkat+0x11d/0x2c0
     __x64_sys_unlink+0x23/0x30
     do_syscall_64+0x4d/0xf0
     entry_SYSCALL_64_after_hwframe+0x44/0xa9

Fixes: ae3b7361dc0e ("afs: Fix validation/callback interaction")
Signed-off-by: Marc Dionne <marc.dionne@auristor.com>
Signed-off-by: David Howells <dhowells@redhat.com>
2019-01-17 15:15:52 +00:00
..
addr_list.c
afs: Probe multiple fileservers simultaneously
2018-10-24 00:41:09 +01:00
afs_cm.h
afs: support the CB.ProbeUuid RPC op
2008-04-29 08:06:26 -07:00
afs_fs.h
afs: Prospectively look up extra files when doing a single lookup
2018-04-09 21:12:31 +01:00
afs_vl.h
afs: Make use of the YFS service upgrade to fully support IPv6
2017-11-13 15:38:19 +00:00
afs.h
afs: Expand data structure fields to support YFS
2018-10-24 00:41:08 +01:00
cache.c
afs: Increase to 64-bit volume ID and 96-bit vnode ID for YFS
2018-10-24 00:41:08 +01:00
callback.c
afs: Implement YFS support in the fs client
2018-10-24 00:41:08 +01:00
cell.c
afs: Fix TTL on VL server and address lists
2018-10-24 00:41:07 +01:00
cmservice.c
afs: Probe multiple fileservers simultaneously
2018-10-24 00:41:09 +01:00
dir_edit.c
afs: Locally edit directory data for mkdir/create/unlink/...
2018-04-09 21:54:48 +01:00
dir.c
afs: Use d_instantiate() rather than d_add() and don't d_drop()
2018-11-29 21:08:14 -05:00
dynroot.c
afs: Increase to 64-bit volume ID and 96-bit vnode ID for YFS
2018-10-24 00:41:08 +01:00
file.c
fs: don't open code lru_to_page()
2019-01-04 13:13:48 -08:00
flock.c
afs: Increase to 64-bit volume ID and 96-bit vnode ID for YFS
2018-10-24 00:41:08 +01:00
fs_probe.c
fs/: remove caller signal_pending branch predictions
2019-01-04 13:13:48 -08:00
fsclient.c
afs: Probe multiple fileservers simultaneously
2018-10-24 00:41:09 +01:00
inode.c
afs: Don't set vnode->cb_s_break in afs_validate()
2019-01-17 15:15:52 +00:00
internal.h
afs: Fix missing net error handling
2018-11-29 21:08:14 -05:00
Kconfig
afs: Allow dumping of server cursor on operation failure
2018-10-24 00:41:09 +01:00
main.c
afs: Fix cell proc list
2018-10-12 13:18:57 +02:00
Makefile
afs: Probe multiple fileservers simultaneously
2018-10-24 00:41:09 +01:00
misc.c
afs: Fix missing net error handling
2018-11-29 21:08:14 -05:00
mntpt.c
afs: Add a couple of tracepoints to log I/O errors
2018-10-24 00:41:07 +01:00
netdevices.c
afs: Implement network namespacing
2018-05-23 12:01:15 +01:00
proc.c
afs: Probe multiple fileservers simultaneously
2018-10-24 00:41:09 +01:00
protocol_yfs.h
afs: Set correct lock type for the yfs CreateFile
2019-01-10 17:12:05 +00:00
rotate.c
afs: Fix missing net error handling
2018-11-29 21:08:14 -05:00
rxrpc.c
rxrpc: Fix life check
2018-11-15 11:35:40 -08:00
security.c
afs: Fix callback handling
2018-10-24 00:41:09 +01:00
server_list.c
afs: Use struct_size() in kzalloc()
2019-01-10 17:12:05 +00:00
server.c
afs: Probe multiple fileservers simultaneously
2018-10-24 00:41:09 +01:00
super.c
afs: Increase to 64-bit volume ID and 96-bit vnode ID for YFS
2018-10-24 00:41:08 +01:00
vl_list.c
afs: Probe multiple fileservers simultaneously
2018-10-24 00:41:09 +01:00
vl_probe.c
fs/: remove caller signal_pending branch predictions
2019-01-04 13:13:48 -08:00
vl_rotate.c
afs: Fix missing net error handling
2018-11-29 21:08:14 -05:00
vlclient.c
afs: Probe multiple fileservers simultaneously
2018-10-24 00:41:09 +01:00
volume.c
afs: Probe multiple fileservers simultaneously
2018-10-24 00:41:09 +01:00
write.c
afs: Increase to 64-bit volume ID and 96-bit vnode ID for YFS
2018-10-24 00:41:08 +01:00
xattr.c
afs: Increase to 64-bit volume ID and 96-bit vnode ID for YFS
2018-10-24 00:41:08 +01:00
xdr_fs.h
afs: Adjust the directory XDR structures
2018-04-09 21:54:48 +01:00
yfsclient.c
afs: Set correct lock type for the yfs CreateFile
2019-01-10 17:12:05 +00:00