iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers
History
Douglas Anderson 908b050114 clk: qcom: rcg2: Don't crash if our parent can't be found; return an error 
When I got my clock parenting slightly wrong I ended up with a crash
that looked like this:

  Unable to handle kernel NULL pointer dereference at virtual
  address 0000000000000000
  ...
  pc : clk_hw_get_rate+0x14/0x44
  ...
  Call trace:
   clk_hw_get_rate+0x14/0x44
   _freq_tbl_determine_rate+0x94/0xfc
   clk_rcg2_determine_rate+0x2c/0x38
   clk_core_determine_round_nolock+0x4c/0x88
   clk_core_round_rate_nolock+0x6c/0xa8
   clk_core_round_rate_nolock+0x9c/0xa8
   clk_core_set_rate_nolock+0x70/0x180
   clk_set_rate+0x3c/0x6c
   of_clk_set_defaults+0x254/0x360
   platform_drv_probe+0x28/0xb0
   really_probe+0x120/0x2dc
   driver_probe_device+0x64/0xfc
   device_driver_attach+0x4c/0x6c
   __driver_attach+0xac/0xc0
   bus_for_each_dev+0x84/0xcc
   driver_attach+0x2c/0x38
   bus_add_driver+0xfc/0x1d0
   driver_register+0x64/0xf8
   __platform_driver_register+0x4c/0x58
   msm_drm_register+0x5c/0x60
   ...

It turned out that clk_hw_get_parent_by_index() was returning NULL and
we weren't checking.  Let's check it so that we don't crash.

Fixes: ac269395cdd8 ("clk: qcom: Convert to clk_hw based provider APIs")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Matthias Kaehlcke <mka@chromium.org>
Link: https://lkml.kernel.org/r/20200203103049.v4.1.I7487325fe8e701a68a07d3be8a6a4b571eca9cfa@changeid
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
2020-02-03 23:04:02 -08:00
..
accessibility
…
acpi
Additional ACPI updates for 5.5-rc1
2019-12-04 10:56:35 -08:00
amba
…
android
compat_ioctl: remove most of fs/compat_ioctl.c
2019-12-01 13:46:15 -08:00
ata
pci-v5.5-changes
2019-12-03 13:58:22 -08:00
atm
…
auxdisplay
auxdisplay: charlcd: deduplicate simple_strtoul()
2019-12-04 19:44:12 -08:00
base
ARM: SoC-related driver updates
2019-12-05 11:43:31 -08:00
bcma
…
block
xen: branch for v5.5-rc1
2019-12-07 14:49:20 -08:00
bluetooth
Bluetooth: btbcm: Use the BDADDR_PROPERTY quirk
2019-11-22 13:35:20 +01:00
bus
Few ti-sysc related fixes for v5.5 merge window
2019-12-06 08:26:50 -08:00
cdrom
cdrom: respect device capabilities during opening action
2019-11-26 13:02:24 -07:00
char
drm msm + fixes for 5.5-rc1
2019-12-06 10:28:09 -08:00
clk
clk: qcom: rcg2: Don't crash if our parent can't be found; return an error
2020-02-03 23:04:02 -08:00
clocksource
Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-12-03 12:20:25 -08:00
connector
…
counter
…
cpufreq
cpufreq: tegra: Changes for v5.5-rc1
2019-12-06 08:28:13 -08:00
cpuidle
cpuidle: minor Kconfig help text fixes
2019-11-29 11:49:32 +01:00
crypto
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2019-12-02 17:23:21 -08:00
dax
libnvdimm for 5.5
2019-12-01 18:43:25 -08:00
dca
…
devfreq
PM / devfreq: Add missing locking while setting suspend_freq
2019-11-29 12:50:34 +01:00
dio
…
dma
dmaengine: Fix Kconfig indentation
2019-11-22 11:16:26 +05:30
dma-buf
compat_ioctl: remove most of fs/compat_ioctl.c
2019-12-01 13:46:15 -08:00
edac
EDAC/altera: Use the Altera System Manager driver
2019-11-22 10:18:29 +01:00
eisa
…
extcon
Char/Misc driver patches for 5.5-rc1
2019-11-27 10:53:50 -08:00
firewire
FireWire (IEEE 1394) subsystem updates:
2019-12-02 14:13:00 -08:00
firmware
clk: zynqmp: Warn user if clock user are more than allowed
2020-01-23 13:25:25 -08:00
fpga
…
fsi
…
gnss
…
gpio
gpio: pca953x: tighten up indentation
2019-12-04 19:44:14 -08:00
gpu
clk: mux: Add support for specifying parents via DT/pointers
2020-01-06 23:10:05 -08:00
greybus
…
hid
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid
2019-12-01 18:20:54 -08:00
hsi
…
hv
Merge branch 'akpm' (patches from Andrew)
2019-12-01 20:36:41 -08:00
hwmon
compat_ioctl: remove most of fs/compat_ioctl.c
2019-12-01 13:46:15 -08:00
hwspinlock
…
hwtracing
compat_ioctl: remove most of fs/compat_ioctl.c
2019-12-01 13:46:15 -08:00
i2c
Merge branch 'i2c/for-5.5' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux
2019-12-01 18:29:36 -08:00
i3c
…
ide
compat_ioctl: remove most of fs/compat_ioctl.c
2019-12-01 13:46:15 -08:00
idle
cpuidle: Drop disabled field from struct cpuidle_state
2019-11-29 11:48:39 +01:00
iio
chrome platform changes for v5.5
2019-12-03 14:37:12 -08:00
infiniband
net: ipv6_stub: use ip6_dst_lookup_flow instead of ip6_dst_lookup
2019-12-04 12:27:13 -08:00
input
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input
2019-12-07 18:33:01 -08:00
interconnect
…
iommu
pci-v5.5-changes
2019-12-03 13:58:22 -08:00
ipack
…
irqchip
pci-v5.5-changes
2019-12-03 13:58:22 -08:00
isdn
compat_ioctl: remove most of fs/compat_ioctl.c
2019-12-01 13:46:15 -08:00
leds
Merge tag 'leds-5.5-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds
2019-12-01 16:09:28 -08:00
lightnvm
…
macintosh
powerpc updates for 5.5
2019-11-30 14:35:43 -08:00
mailbox
mailbox changes for v5.5
2019-12-01 18:42:02 -08:00
mcb
…
md
block: don't handle bio based drivers in blk_revalidate_disk_zones
2019-12-03 08:51:25 -07:00
media
compat_ioctl: remove most of fs/compat_ioctl.c
2019-12-01 13:46:15 -08:00
memory
memory: tegra: Fixes for v5.5-rc1
2019-12-06 08:28:51 -08:00
memstick
pci-v5.5-changes
2019-12-03 13:58:22 -08:00
message
…
mfd
chrome platform changes for v5.5
2019-12-03 14:37:12 -08:00
misc
lib/genalloc.c: rename addr_in_gen_pool to gen_pool_has_addr
2019-12-04 19:44:13 -08:00
mmc
Driver core patches for 5.5-rc1
2019-11-27 11:06:20 -08:00
mtd
TTY/Serial patches for 5.5-rc1
2019-12-03 14:09:14 -08:00
mux
…
net
clk: let init callback return an error code
2019-12-23 18:53:13 -08:00
nfc
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2019-11-22 16:27:24 -08:00
ntb
Add Hygon Device ID to the AMD NTB device driver
2019-12-07 18:38:17 -08:00
nubus
…
nvdimm
libnvdimm for 5.5
2019-12-01 18:43:25 -08:00
nvme
pci-v5.5-changes
2019-12-03 13:58:22 -08:00
nvmem
ARM: SoC-related driver updates
2019-12-05 11:43:31 -08:00
of
Devicetree updates for v5.5:
2019-12-02 11:41:35 -08:00
opp
…
oprofile
Printk changes for 5.5
2019-11-25 19:40:40 -08:00
parisc
…
parport
parport: daisy: use new parport device model
2019-11-13 19:09:49 +08:00
pci
pci-v5.5-changes
2019-12-03 13:58:22 -08:00
pcmcia
pcmcia: remove unused dprintk definition
2019-11-22 07:03:45 +01:00
perf
…
phy
ARM: SoC-related driver updates
2019-12-05 11:43:31 -08:00
pinctrl
Merge branch 'irq-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2019-12-03 09:29:50 -08:00
platform
chrome platform changes for v5.5
2019-12-03 14:37:12 -08:00
pnp
…
power
Additional power management updates for 5.5-rc1
2019-12-04 10:48:09 -08:00
powercap
…
pps
…
ps3
…
ptp
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2019-11-16 21:51:42 -08:00
pwm
pwm: Changes for v5.5-rc1
2019-12-05 11:28:14 -08:00
rapidio
drivers/rapidio/rio-access.c: fix missing include of <linux/rio_drv.h>
2019-12-04 19:44:13 -08:00
ras
…
regulator
Merge branch 'regulator-5.5' into regulator-next
2019-11-22 19:56:20 +00:00
remoteproc
remoteproc: stm32: fix probe error case
2019-11-18 20:35:16 -08:00
reset
ARM: SoC-related driver updates
2019-12-05 11:43:31 -08:00
rpmsg
rpmsg updates for v5.5
2019-12-01 18:39:24 -08:00
rtc
RTC for 5.5
2019-12-03 13:31:08 -08:00
s390
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2019-12-08 13:28:11 -08:00
sbus
…
scsi
SCSI misc on 20191207
2019-12-08 12:23:42 -08:00
sfi
…
sh
…
siox
…
slimbus
…
soc
ARM: SoC fixes
2019-12-06 14:19:37 -08:00
soundwire
…
spi
Merge branch 'spi-5.5' into spi-next
2019-11-22 19:56:35 +00:00
spmi
…
ssb
…
staging
pci-v5.5-changes
2019-12-03 13:58:22 -08:00
target
SCSI misc on 20191130
2019-12-02 13:37:02 -08:00
tc
…
tee
Merge mainline/master into arm/fixes
2019-12-05 13:18:54 -08:00
thermal
Merge branch 'thermal/next' of git://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux
2019-12-05 11:21:24 -08:00
thunderbolt
thunderbolt: Power cycle the router if NVM authentication fails
2019-11-19 17:35:57 +01:00
tty
TTY/Serial patches for 5.5-rc1
2019-12-03 14:09:14 -08:00
uio
uio: fix irq init with dt support & irq not defined
2019-11-14 11:49:48 +08:00
usb
usb, kcov: collect coverage from hub_event
2019-12-04 19:44:14 -08:00
vfio
VFIO updates for v5.5-rc1
2019-12-07 14:51:04 -08:00
vhost
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2019-12-08 13:28:11 -08:00
video
pci-v5.5-changes
2019-12-03 13:58:22 -08:00
virt
compat_ioctl: remove most of fs/compat_ioctl.c
2019-12-01 13:46:15 -08:00
virtio
virtio_balloon: fix shrinker count
2019-11-20 02:15:57 -05:00
visorbus
…
vlynq
…
vme
…
w1
w1: new driver. DS2430 chip
2019-11-14 13:06:33 +08:00
watchdog
linux-watchdog 5.5-rc1 tag
2019-12-01 18:01:03 -08:00
xen
xen: branch for v5.5-rc1
2019-12-07 14:49:20 -08:00
zorro
…
Kconfig
…
Makefile
…