Oliver Upton 49e5d16b6f KVM: arm64: vgic: Don't acquire its_lock before config_lock
commit f00327731131 ("KVM: arm64: Use config_lock to protect vgic
state") was meant to rectify a longstanding lock ordering issue in KVM
where the kvm->lock is taken while holding vcpu->mutex. As it so
happens, the aforementioned commit introduced yet another locking issue
by acquiring the its_lock before acquiring the config lock.

This is obviously wrong, especially considering that the lock ordering
is well documented in vgic.c. Reshuffle the locks once more to take the
config_lock before the its_lock. While at it, sprinkle in the lockdep
hinting that has become popular as of late to keep lockdep apprised of
our ordering.

Cc: stable@vger.kernel.org
Fixes: f00327731131 ("KVM: arm64: Use config_lock to protect vgic state")
Signed-off-by: Oliver Upton <oliver.upton@linux.dev>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20230412062733.988229-1-oliver.upton@linux.dev
2023-04-12 13:50:18 +01:00
..
2023-03-24 15:38:13 -07:00
2023-02-27 09:27:31 -08:00
2023-03-05 11:07:58 -08:00
2023-03-01 09:27:00 -08:00
2023-03-05 11:07:58 -08:00
2023-03-05 11:07:58 -08:00
2023-03-05 11:07:58 -08:00
2023-03-05 11:07:58 -08:00
2023-03-24 09:52:26 -07:00
2023-03-13 09:15:11 +01:00
2023-03-09 10:01:59 -08:00
2023-03-05 11:07:58 -08:00
2023-02-09 17:03:20 -08:00