iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers
History
Chris Wilson 4a0ca47a8e drm/i915/gt: Suspend tasklets before resume sanitization 
It is possible for a residual tasklet to be pending execution as we
resume (whether that's some prior test kicking off the tasklet, or if we
are in a suspend/resume stress test). As such, we do not want that
tasklet to execute in the middle of our sanitization, such that it sees
the poisoned state. For example,

<4>[  449.386553] invalid opcode: 0000 [#1] PREEMPT SMP NOPTI
<4>[  449.386555] CPU: 1 PID: 5115 Comm: i915_selftest Tainted: G     U  W         5.7.0-rc4-CI-CI_DRM_8472+ #1
<4>[  449.386556] Hardware name: Intel Corporation Ice Lake Client Platform/IceLake U DDR4 SODIMM PD RVP TLC, BIOS ICLSFWR1.R00.3183.A00.1905020411 05/02/2019
<4>[  449.386585] RIP: 0010:process_csb+0x6bf/0x830 [i915]
<4>[  449.386588] Code: 00 48 c7 c2 10 bc 4c a0 48 c7 c7 d4 75 34 a0 e8 87 0e e6 e0 bf 01 00 00 00 e8 9d e0 e5 e0 31 f6 bf 09 00 00 00 e8 e1 ba d6 e0 <0f> 0b 8b 87 10 05 00 00 85 c0 0f 85 5f f9 ff ff 48 c7 c1 70 a5 4f
<4>[  449.386591] RSP: 0018:ffffc90000170ea0 EFLAGS: 00010297
<4>[  449.386594] RAX: 0000000080000101 RBX: 0000000000000000 RCX: 0000000000000000
<4>[  449.386596] RDX: ffff88849d5bc040 RSI: 0000000000000000 RDI: 0000000000000009
<4>[  449.386598] RBP: ffffc90000170f00 R08: 0000000000000000 R09: 0000000000000000
<4>[  449.386600] R10: 0000000000000000 R11: 0000000000000000 R12: ffff88843ccea018
<4>[  449.386602] R13: ffff88843ccea658 R14: ffff88843ccea640 R15: ffff88843ccea000
<4>[  449.386605] FS:  00007f826a813300(0000) GS:ffff88849fe80000(0000) knlGS:0000000000000000
<4>[  449.386607] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
<4>[  449.386609] CR2: 0000560366b94280 CR3: 000000048ba02002 CR4: 0000000000760ee0
<4>[  449.386611] PKRU: 55555554
<4>[  449.386613] Call Trace:
<4>[  449.386616]  <IRQ>
<4>[  449.386646]  ? execlists_submission_tasklet+0xcf/0x140 [i915]
<4>[  449.386674]  execlists_submission_tasklet+0x2f/0x140 [i915]
<4>[  449.386679]  tasklet_action_common.isra.16+0x6c/0x1c0
<4>[  449.386684]  __do_softirq+0xdf/0x49e
<4>[  449.386687]  irq_exit+0xba/0xc0
<4>[  449.386690]  smp_apic_timer_interrupt+0xb7/0x280
<4>[  449.386693]  apic_timer_interrupt+0xf/0x20
<4>[  449.386695]  </IRQ>
<4>[  449.386698] RIP: 0010:_raw_spin_unlock_irqrestore+0x49/0x60
<4>[  449.386701] Code: c7 02 75 1f 53 9d e8 26 ab 75 ff bf 01 00 00 00 e8 7c a3 69 ff 65 8b 05 7d 9b 5c 7e 85 c0 74 0c 5b 5d c3 e8 09 aa 75 ff 53 9d <eb> df e8 ca 39 5b ff 5b 5d c3 0f 1f 00 66 2e 0f 1f 84 00 00 00 00
<4>[  449.386703] RSP: 0018:ffffc90000a6b950 EFLAGS: 00000202 ORIG_RAX: ffffffffffffff13
<4>[  449.386706] RAX: 0000000080000001 RBX: 0000000000000202 RCX: 0000000000000000
<4>[  449.386708] RDX: ffff88849d5bc040 RSI: ffff88849d5bc900 RDI: ffffffff82386f12
<4>[  449.386710] RBP: ffff88847d400f00 R08: ffff88849d5bc900 R09: 0000000000000000
<4>[  449.386712] R10: 0000000000000000 R11: 0000000000000000 R12: 00000000ffff0b0b
<4>[  449.386714] R13: 000000000000000c R14: ffff88847d40bf70 R15: ffff88847d40cef8
<4>[  449.386742]  reset_csb_pointers+0x59/0x140 [i915]
<4>[  449.386769]  execlists_sanitize+0x3e/0x60 [i915]
<4>[  449.386797]  gt_sanitize+0xd6/0x260 [i915]

As part of the reset preparation, engine->reset.prepare() prevents the
tasklet from running, so pull the sanitization inside the critical
section for reset.

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1812
Fixes: 23122a4d992b ("drm/i915/gt: Scrub execlists state on resume")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200513122826.27484-1-chris@chris-wilson.co.uk
2020-05-13 17:13:16 +01:00
..
accessibility
…
acpi
More ACPI updates for 5.7-rc1
2020-04-10 09:52:15 -07:00
amba
Revert "amba: Initialize dma_parms for amba devices"
2020-04-01 08:03:28 +02:00
android
Merge 5.6-rc7 into char-misc-next
2020-03-23 07:59:38 +01:00
ata
ahci: Add Intel Comet Lake PCH RAID PCI ID
2020-04-09 09:31:38 -06:00
atm
.gitignore: add SPDX License Identifier
2020-03-25 11:50:48 +01:00
auxdisplay
Merge 5.6-rc7 into char-misc-next
2020-03-23 07:59:38 +01:00
base
mm/memory_hotplug: allow to specify a default online_type
2020-04-07 10:43:41 -07:00
bcma
…
block
xen: branch for v5.7-rc1b
2020-04-10 17:20:06 -07:00
bluetooth
…
bus
ARM: driver updates
2020-04-03 15:05:35 -07:00
cdrom
…
char
drm/i915: Refactor setting dma info to a common helper
2020-04-18 07:49:11 +01:00
clk
There's not much to see in the core framework this time around. Instead the
2020-04-05 10:43:32 -07:00
clocksource
clocksource/drivers/timer-vf-pit: Add missing parenthesis
2020-04-05 09:24:58 +02:00
connector
…
counter
…
cpufreq
Additional power management updates for 5.7-rc1
2020-04-06 10:14:39 -07:00
cpuidle
Merge branch 'pm-cpuidle'
2020-04-10 11:32:22 +02:00
crypto
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2020-04-08 21:35:29 -07:00
dax
dax: Move mandatory ->zero_page_range() check in alloc_dax()
2020-04-02 19:15:03 -07:00
dca
…
devfreq
PM / devfreq: Fix handling dev_pm_qos_remove_request result
2020-03-25 08:35:03 +09:00
dio
…
dma
drivers/dma/tegra20-apb-dma.c: fix platform_get_irq.cocci warnings
2020-04-10 15:36:22 -07:00
dma-buf
A bunch of fixes to avoid null pointer dereference in fbcon, fix a return
2020-04-08 09:14:34 +10:00
edac
Merge branch 'perf-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2020-03-30 16:40:08 -07:00
eisa
.gitignore: add SPDX License Identifier
2020-03-25 11:50:48 +01:00
extcon
Char/Misc driver patches for 5.7-rc1
2020-04-03 13:22:40 -07:00
firewire
…
firmware
sound fixes for 5.7-rc1
2020-04-10 12:27:06 -07:00
fpga
…
fsi
…
gnss
…
gpio
This is the bulk of GPIO development for the v5.7 kernel cycle.
2020-04-04 10:27:00 -07:00
gpu
drm/i915/gt: Suspend tasklets before resume sanitization
2020-05-13 17:13:16 +01:00
greybus
…
hid
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid
2020-04-01 15:18:42 -07:00
hsi
…
hv
hv_balloon: don't check for memhp_auto_online manually
2020-04-07 10:43:40 -07:00
hwmon
change email address for Pali Rohár
2020-04-10 15:36:22 -07:00
hwspinlock
hwspinlock: hwspinlock_internal.h: Replace zero-length array with flexible-array member
2020-03-25 22:30:46 -07:00
hwtracing
intel_th: msu: Make stopping the trace optional
2020-03-24 13:45:24 +01:00
i2c
Merge branch 'i2c/for-5.7' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux
2020-04-02 15:54:13 -07:00
i3c
i3c: convert to use i2c_new_client_device()
2020-03-29 10:35:50 +02:00
ide
drivers/ide: Fix build regression.
2020-04-04 18:07:59 -07:00
idle
Merge branch 'perf-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2020-03-30 16:40:08 -07:00
iio
chrome platform changes for 5.7
2020-04-08 21:25:49 -07:00
infiniband
RDMA 5.7 pull request
2020-04-01 18:18:18 -07:00
input
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input
2020-04-07 20:20:12 -07:00
interconnect
…
iommu
Merge branches 'iommu/fixes', 'arm/qcom', 'arm/omap', 'arm/smmu', 'x86/amd', 'x86/vt-d', 'virtio' and 'core' into next
2020-03-27 11:33:27 +01:00
ipack
…
irqchip
Two reverts addressing regressions of the Xilinx interrupt controller
2020-04-05 11:57:12 -07:00
isdn
…
leds
leds: core: Fix warning message when init_data
2020-04-06 23:12:08 +02:00
lightnvm
for-5.7/drivers-2020-03-29
2020-03-30 11:43:51 -07:00
macintosh
Char/Misc driver patches for 5.7-rc1
2020-04-03 13:22:40 -07:00
mailbox
…
mcb
…
md
libnvdimm for 5.7
2020-04-08 21:03:40 -07:00
media
Power management updates for 5.7-rc1
2020-03-30 15:05:01 -07:00
memory
ARM: driver updates
2020-04-03 15:05:35 -07:00
memstick
…
message
scsi: message: fusion: Replace zero-length array with flexible-array member
2020-03-26 22:40:47 -04:00
mfd
mfd: intel-lpss: Fix Intel Elkhart Lake LPSS I2C input clock
2020-03-30 07:35:28 +01:00
misc
virtio: fixes, vdpa
2020-04-08 10:51:53 -07:00
mmc
MMC core:
2020-03-31 16:13:09 -07:00
most
staging: most: move core files out of the staging area
2020-03-24 13:42:44 +01:00
mtd
This pull request contains fixes for UBI and UBIFS:
2020-04-07 12:40:56 -07:00
mux
…
net
virtio: fixes, vdpa
2020-04-08 10:51:53 -07:00
nfc
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-03-25 18:58:11 -07:00
ntb
pci-v5.7-changes
2020-04-03 14:25:02 -07:00
nubus
…
nvdimm
libnvdimm for 5.7
2020-04-08 21:03:40 -07:00
nvme
block-5.7-2020-04-10
2020-04-10 10:06:54 -07:00
nvmem
nvmem: core: remove nvmem_sysfs_get_groups()
2020-03-25 19:23:49 +01:00
of
Devicetree updates for v5.7:
2020-04-02 17:32:52 -07:00
opp
…
oprofile
…
parisc
parisc: Replace setup_irq() by request_irq()
2020-04-05 22:05:23 +02:00
parport
…
pci
IOMMU Updates for Linux v5.7
2020-04-08 11:00:00 -07:00
pcmcia
pcmcia: remove some unused space characters
2020-03-31 18:48:22 +02:00
perf
arm64 updates for 5.7:
2020-03-31 10:05:01 -07:00
phy
pci-v5.7-changes
2020-04-03 14:25:02 -07:00
pinctrl
This is the bulk of GPIO development for the v5.7 kernel cycle.
2020-04-04 10:27:00 -07:00
platform
change email address for Pali Rohár
2020-04-10 15:36:22 -07:00
pnp
…
power
change email address for Pali Rohár
2020-04-10 15:36:22 -07:00
powercap
Merge branch 'perf-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
2020-03-30 16:40:08 -07:00
pps
…
ps3
powerpc/ps3: Remove an unneeded NULL check
2020-04-03 00:09:59 +11:00
ptp
ptp: Avoid deadlocks in the programmable pin code.
2020-03-30 11:16:38 -07:00
pwm
pwm: pca9685: Fix PWM/GPIO inter-operation
2020-04-03 21:41:42 +02:00
rapidio
…
ras
…
regulator
spi/regulator: Updates for v5.7
2020-03-30 14:58:26 -07:00
remoteproc
remoteproc/omap: Fix set_load call in omap_rproc_request_timer
2020-04-03 10:47:21 -07:00
reset
…
rpmsg
…
rtc
- New Drivers
2020-04-07 19:48:52 -07:00
s390
SCSI misc on 20200410
2020-04-10 12:21:11 -07:00
sbus
…
scsi
SCSI misc on 20200410
2020-04-10 12:21:11 -07:00
sfi
…
sh
…
siox
…
slimbus
…
soc
RISC-V Patches for the 5.7 Merge Window, Part 1
2020-04-09 10:51:30 -07:00
soundwire
Char/Misc driver patches for 5.7-rc1
2020-04-03 13:22:40 -07:00
spi
sound updates for 5.7-rc1
2020-04-02 15:50:04 -07:00
spmi
…
ssb
…
staging
mm/vma: introduce VM_ACCESS_FLAGS
2020-04-10 15:36:21 -07:00
target
SCSI misc on 20200410
2020-04-10 12:21:11 -07:00
tc
…
tee
ARM: driver updates
2020-04-03 15:05:35 -07:00
thermal
- Convert tsens configuration DT binding to yaml (Rajeshwari)
2020-04-07 20:00:16 -07:00
thunderbolt
Merge 5.6-rc7 into usb-next
2020-03-23 08:04:08 +01:00
tty
powerpc updates for 5.7
2020-04-05 11:12:59 -07:00
uio
…
usb
SCSI misc on 20200402
2020-04-02 17:03:53 -07:00
vdpa
vdpa: move to drivers/vdpa
2020-04-02 10:41:40 -04:00
vfio
vfio: Ignore -ENODEV when getting MSI cookie
2020-04-01 13:51:51 -06:00
vhost
vhost: introduce vDPA-based backend
2020-04-02 10:41:40 -04:00
video
drm fixes for 5.7-rc1
2020-04-07 20:24:34 -07:00
virt
…
virtio
virtio: fixes, vdpa
2020-04-08 10:51:53 -07:00
visorbus
…
vlynq
…
vme
…
w1
…
watchdog
watchdog: Add K3 RTI watchdog support
2020-04-01 11:35:23 +02:00
xen
xen: branch for v5.7-rc1b
2020-04-10 17:20:06 -07:00
zorro
SPDX patches for 5.7-rc1.
2020-04-03 13:12:26 -07:00
Kconfig
virtio: fixes, vdpa
2020-04-08 10:51:53 -07:00
Makefile
virtio: fixes, vdpa
2020-04-08 10:51:53 -07:00