iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/gpu/drm
History
Chris Wilson 4a0ca47a8e drm/i915/gt: Suspend tasklets before resume sanitization 
It is possible for a residual tasklet to be pending execution as we
resume (whether that's some prior test kicking off the tasklet, or if we
are in a suspend/resume stress test). As such, we do not want that
tasklet to execute in the middle of our sanitization, such that it sees
the poisoned state. For example,

<4>[  449.386553] invalid opcode: 0000 [#1] PREEMPT SMP NOPTI
<4>[  449.386555] CPU: 1 PID: 5115 Comm: i915_selftest Tainted: G     U  W         5.7.0-rc4-CI-CI_DRM_8472+ #1
<4>[  449.386556] Hardware name: Intel Corporation Ice Lake Client Platform/IceLake U DDR4 SODIMM PD RVP TLC, BIOS ICLSFWR1.R00.3183.A00.1905020411 05/02/2019
<4>[  449.386585] RIP: 0010:process_csb+0x6bf/0x830 [i915]
<4>[  449.386588] Code: 00 48 c7 c2 10 bc 4c a0 48 c7 c7 d4 75 34 a0 e8 87 0e e6 e0 bf 01 00 00 00 e8 9d e0 e5 e0 31 f6 bf 09 00 00 00 e8 e1 ba d6 e0 <0f> 0b 8b 87 10 05 00 00 85 c0 0f 85 5f f9 ff ff 48 c7 c1 70 a5 4f
<4>[  449.386591] RSP: 0018:ffffc90000170ea0 EFLAGS: 00010297
<4>[  449.386594] RAX: 0000000080000101 RBX: 0000000000000000 RCX: 0000000000000000
<4>[  449.386596] RDX: ffff88849d5bc040 RSI: 0000000000000000 RDI: 0000000000000009
<4>[  449.386598] RBP: ffffc90000170f00 R08: 0000000000000000 R09: 0000000000000000
<4>[  449.386600] R10: 0000000000000000 R11: 0000000000000000 R12: ffff88843ccea018
<4>[  449.386602] R13: ffff88843ccea658 R14: ffff88843ccea640 R15: ffff88843ccea000
<4>[  449.386605] FS:  00007f826a813300(0000) GS:ffff88849fe80000(0000) knlGS:0000000000000000
<4>[  449.386607] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
<4>[  449.386609] CR2: 0000560366b94280 CR3: 000000048ba02002 CR4: 0000000000760ee0
<4>[  449.386611] PKRU: 55555554
<4>[  449.386613] Call Trace:
<4>[  449.386616]  <IRQ>
<4>[  449.386646]  ? execlists_submission_tasklet+0xcf/0x140 [i915]
<4>[  449.386674]  execlists_submission_tasklet+0x2f/0x140 [i915]
<4>[  449.386679]  tasklet_action_common.isra.16+0x6c/0x1c0
<4>[  449.386684]  __do_softirq+0xdf/0x49e
<4>[  449.386687]  irq_exit+0xba/0xc0
<4>[  449.386690]  smp_apic_timer_interrupt+0xb7/0x280
<4>[  449.386693]  apic_timer_interrupt+0xf/0x20
<4>[  449.386695]  </IRQ>
<4>[  449.386698] RIP: 0010:_raw_spin_unlock_irqrestore+0x49/0x60
<4>[  449.386701] Code: c7 02 75 1f 53 9d e8 26 ab 75 ff bf 01 00 00 00 e8 7c a3 69 ff 65 8b 05 7d 9b 5c 7e 85 c0 74 0c 5b 5d c3 e8 09 aa 75 ff 53 9d <eb> df e8 ca 39 5b ff 5b 5d c3 0f 1f 00 66 2e 0f 1f 84 00 00 00 00
<4>[  449.386703] RSP: 0018:ffffc90000a6b950 EFLAGS: 00000202 ORIG_RAX: ffffffffffffff13
<4>[  449.386706] RAX: 0000000080000001 RBX: 0000000000000202 RCX: 0000000000000000
<4>[  449.386708] RDX: ffff88849d5bc040 RSI: ffff88849d5bc900 RDI: ffffffff82386f12
<4>[  449.386710] RBP: ffff88847d400f00 R08: ffff88849d5bc900 R09: 0000000000000000
<4>[  449.386712] R10: 0000000000000000 R11: 0000000000000000 R12: 00000000ffff0b0b
<4>[  449.386714] R13: 000000000000000c R14: ffff88847d40bf70 R15: ffff88847d40cef8
<4>[  449.386742]  reset_csb_pointers+0x59/0x140 [i915]
<4>[  449.386769]  execlists_sanitize+0x3e/0x60 [i915]
<4>[  449.386797]  gt_sanitize+0xd6/0x260 [i915]

As part of the reset preparation, engine->reset.prepare() prevents the
tasklet from running, so pull the sanitization inside the critical
section for reset.

Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/1812
Fixes: 23122a4d992b ("drm/i915/gt: Scrub execlists state on resume")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200513122826.27484-1-chris@chris-wilson.co.uk
2020-05-13 17:13:16 +01:00
..
amd
Topic pull request for topic/phy-compliance:
2020-04-16 14:52:59 +03:00
arc
drm/bridge: Extend bridge API to disable connector creation
2020-02-26 13:31:23 +02:00
arm
drm/komeda: mark PM functions as __maybe_unused
2020-03-06 11:25:58 +08:00
armada
drm: Remove drm_fb_helper add, add all and remove connector calls
2020-03-06 14:19:58 +01:00
aspeed
drm/aspeed: gfc_crtc: Make structure aspeed_gfx_funcs constant
2019-08-14 19:27:26 +02:00
ast
drm/ast: Use simple encoder
2020-03-02 09:22:43 +01:00
atmel-hlcdc
drm/bridge: Extend bridge API to disable connector creation
2020-02-26 13:31:23 +02:00
bochs
Linux 5.6
2020-03-31 15:15:47 +10:00
bridge
drm/bridge: analogix_dp: Split bind() into probe() and real bind()
2020-04-09 10:29:35 +02:00
cirrus
drm/cirrus: add drm_driver.release callback.
2020-02-12 10:24:08 +01:00
etnaviv
drm/etnaviv: fix TS cache flushing on GPUs with BLT engine
2020-03-20 18:40:44 +01:00
exynos
drm/bridge: analogix_dp: Split bind() into probe() and real bind()
2020-04-09 10:29:35 +02:00
fsl-dcu
drm/bridge: Extend bridge API to disable connector creation
2020-02-26 13:31:23 +02:00
gma500
drm: Remove drm_fb_helper add, add all and remove connector calls
2020-03-06 14:19:58 +01:00
hisilicon
Linux 5.6-rc5
2020-03-11 07:27:21 +10:00
i2c
drm/bridge: Extend bridge API to disable connector creation
2020-02-26 13:31:23 +02:00
i810
drm/i810: Don't include <drm/drm_pci.h>
2019-12-05 08:44:12 +01:00
i915
drm/i915/gt: Suspend tasklets before resume sanitization
2020-05-13 17:13:16 +01:00
imx
drm/bridge: Extend bridge API to disable connector creation
2020-02-26 13:31:23 +02:00
ingenic
drm/bridge: Extend bridge API to disable connector creation
2020-02-26 13:31:23 +02:00
lib
…
lima
drm-misc-next for 5.7:
2020-02-21 05:44:40 +10:00
mcde
drm/bridge: Extend bridge API to disable connector creation
2020-02-26 13:31:23 +02:00
mediatek
sound updates for 5.7-rc1
2020-04-02 15:50:04 -07:00
meson
drm/meson: Add YUV420 output support
2020-03-10 10:51:24 +01:00
mga
drm/mga: Don't include <drm/drm_pci.h>
2019-12-05 08:44:16 +01:00
mgag200
drm/mgag200: Use simple encoder
2020-03-02 09:22:49 +01:00
msm
IOMMU Updates for Linux v5.7
2020-04-08 11:00:00 -07:00
mxsfb
drm/panel: decouple connector from drm_panel
2019-12-09 22:57:26 +01:00
nouveau
drm fixes for 5.7-rc1
2020-04-07 20:24:34 -07:00
omapdrm
ARM: driver updates
2020-04-03 15:05:35 -07:00
panel
drm/panel-simple: drop use of data-mapping property
2020-03-25 21:59:22 +01:00
panfrost
drm-misc-next for 5.7:
2020-03-12 12:42:56 +10:00
pl111
drm/pl111: Support Integrator IM-PD1 module
2020-02-16 14:31:30 +01:00
qxl
drm/qxl: Use simple encoder
2020-03-02 09:22:56 +01:00
r128
drm/r128: Don't include <drm/drm_pci.h>
2019-12-05 08:44:23 +01:00
radeon
pci-v5.7-changes
2020-04-03 14:25:02 -07:00
rcar-du
drm/bridge: Extend bridge API to disable connector creation
2020-02-26 13:31:23 +02:00
rockchip
drm/bridge: analogix_dp: Split bind() into probe() and real bind()
2020-04-09 10:29:35 +02:00
savage
drm/savage: Don't include <drm/drm_pci.h>
2019-12-05 08:44:34 +01:00
scheduler
drm/scheduler: fix rare NULL ptr race
2020-03-26 10:22:36 -04:00
selftests
drm/modes: Make sure to parse valid rotation value from cmdline
2020-02-12 18:32:54 +01:00
shmobile
…
sis
drm/sis: Don't include <drm/drm_pci.h>
2019-12-05 08:44:55 +01:00
sti
drm/bridge: Extend bridge API to disable connector creation
2020-02-26 13:31:23 +02:00
stm
drm/bridge: Extend bridge API to disable connector creation
2020-02-26 13:31:23 +02:00
sun4i
Linux 5.6-rc5
2020-03-11 07:27:21 +10:00
tdfx
drm/tdfx: Don't include <drm/drm_pci.h>
2019-12-05 08:45:01 +01:00
tegra
drm/tegra: Changes for v5.7-rc1
2020-03-19 10:11:09 +10:00
tidss
drm/tidss: Drop pointless static qualifier in dispc_find_csc()
2020-02-28 14:48:58 +02:00
tilcdc
drm/bridge: Extend bridge API to disable connector creation
2020-02-26 13:31:23 +02:00
tiny
drm/tiny: fix sparse warning: incorrect type in assignment (different base types)
2020-03-14 08:31:30 +01:00
ttm
drm fixes for 5.7-rc1 (part two)
2020-04-10 12:38:28 -07:00
tve200
drm: get drm_bridge_panel connector via helper
2019-12-09 22:57:26 +01:00
udl
drm/udl: Clear struct drm_connector_funcs.dpms
2020-02-10 09:24:09 +01:00
v3d
drm/v3d: Replace wait_for macros to remove use of msleep
2020-03-04 22:15:34 -08:00
vboxvideo
drm/vboxvideo: Add missing remove_conflicting_pci_framebuffers call, v2
2020-03-26 17:03:03 +01:00
vc4
drm/vc4: Fix HDMI mode validation
2020-03-27 13:38:47 +01:00
vgem
drm/vgem: Close use-after-free race in vgem_gem_create
2020-02-06 19:04:41 +01:00
via
Merge branch 'akpm' (patches from Andrew)
2020-01-31 12:16:36 -08:00
virtio
drm/virtio: fix OOB in virtio_gpu_object_create
2020-04-06 15:10:37 +02:00
vkms
drm/vkms: Convert to CRTC VBLANK callbacks
2020-02-13 13:10:10 +01:00
vmwgfx
Merge branch 'ttm-transhuge' of git://people.freedesktop.org/~thomash/linux into drm-next
2020-04-03 09:07:49 +10:00
xen
drm/xen: fix passing zero to 'PTR_ERR' warning
2020-03-31 17:14:51 +02:00
zte
drm/zte: plane_state->fb iff plane_state->crtc
2020-01-28 15:43:58 +01:00
drm_agpsupport.c
drm: use DIV_ROUND_UP helper macro for calculations
2019-11-04 18:17:36 +01:00
drm_atomic_helper.c
drm/bridge: Add the necessary bits to support bus format negotiation
2020-01-31 16:39:53 +01:00
drm_atomic_state_helper.c
drm/atomic-helper: fix kerneldoc
2020-02-15 13:21:22 +01:00
drm_atomic_uapi.c
drm/atomic: Spell CRTC consistently
2019-12-22 11:13:00 +01:00
drm_atomic.c
drm/bridge: Fix the bridge kernel doc
2020-02-18 16:50:45 +01:00
drm_auth.c
drm/auth: Drop master_create/destroy hooks
2020-01-29 09:14:11 +01:00
drm_blend.c
drm: two planes with the same zpos have undefined ordering
2019-10-09 20:04:55 +02:00
drm_bridge_connector.c
drm: Add helper to create a connector for a chain of bridges
2020-02-26 13:31:41 +02:00
drm_bridge.c
drm: Add helper to create a connector for a chain of bridges
2020-02-26 13:31:41 +02:00
drm_bufs.c
drm: bufs: Clean up documentation
2020-03-16 09:26:18 +01:00
drm_cache.c
drm/gpu: Fix Memory barrier without comment Issue
2019-10-25 09:35:06 +02:00
drm_client_modeset.c
Linux 5.6-rc5
2020-03-11 07:27:21 +10:00
drm_client.c
drm/client: Dual licence the file in GPL-2 and MIT
2020-02-29 00:16:12 +01:00
drm_color_mgmt.c
drm: Inline drm_color_lut_extract()
2019-11-29 21:29:17 +02:00
drm_connector.c
drm/connector: Add helper to get a connector type name
2020-02-26 13:31:18 +02:00
drm_context.c
drm: context: Clean up documentation
2020-03-16 09:23:55 +01:00
drm_crtc_helper_internal.h
drm/connector: Share with non-atomic drivers the function to get the single encoder
2019-09-16 15:13:02 -07:00
drm_crtc_helper.c
drm: drop unused drm_crtc callback
2020-02-15 21:15:17 +01:00
drm_crtc_internal.h
drm: Add getfb2 ioctl
2020-01-14 16:22:17 -05:00
drm_crtc.c
…
drm_damage_helper.c
drm: damage_helper: Fix race checking plane->state->fb
2019-10-08 09:41:06 -04:00
drm_debugfs_crc.c
drm/crc: Actually allow to change the crc source
2020-01-28 16:49:22 +01:00
drm_debugfs.c
drm/debugfs: also take per device driver features into account
2020-01-25 15:49:11 +02:00
drm_dma.c
drm: fix parameters documentation style in drm_dma
2020-01-18 10:33:12 +01:00
drm_dp_aux_dev.c
drm/dp_mst: Add MST support to DP DPCD R/W functions
2020-01-09 18:07:46 -05:00
drm_dp_cec.c
drm_dp_cec: drop use of drmP.h
2019-10-08 18:29:00 +02:00
drm_dp_dual_mode_helper.c
…
drm_dp_helper.c
Topic pull request for topic/phy-compliance:
2020-04-16 14:52:59 +03:00
drm_dp_mst_topology_internal.h
drm/dp_mst: Add sideband down request tracing + selftests
2019-09-03 19:30:06 -04:00
drm_dp_mst_topology.c
Linux 5.6
2020-03-31 15:15:47 +10:00
drm_drv.c
drm: Nerf drm_global_mutex BKL for good drivers
2020-02-11 15:03:09 +01:00
drm_dsc.c
drm/dsc: Fix bogus cpu_to_be16() usage
2019-09-30 20:15:53 +03:00
drm_dumb_buffers.c
Revert "drm/gem: Rename drm_gem_dumb_map_offset() to drm_gem_map_offset()"
2019-08-07 11:56:48 -04:00
drm_edid_load.c
drm/print: add drm_debug_enabled()
2019-10-02 16:28:55 +03:00
drm_edid.c
drm/edid: Distribute switch variables for initialization
2020-03-16 10:54:08 +01:00
drm_encoder_slave.c
…
drm_encoder.c
drm/bridge: Make the bridge chain a double-linked list
2019-12-09 10:03:01 +01:00
drm_fb_cma_helper.c
drm/fb-cma-helpers: Fix include issue
2020-01-09 17:33:41 +01:00
drm_fb_helper.c
drm: Remove unused arg from drm_fb_helper_init
2020-03-06 14:19:57 +01:00
drm_file.c
drm/vmwgfx: Hook up the helpers to align buffer objects
2020-03-24 18:50:35 +01:00
drm_flip_work.c
…
drm_format_helper.c
drm/format_helper: Dual licence the file in GPL 2 and MIT
2020-02-17 10:27:13 +01:00
drm_fourcc.c
drm/fourcc: Fill out all block sizes for P210
2019-11-28 11:19:32 +01:00
drm_framebuffer.c
drm: Add getfb2 ioctl
2020-01-14 16:22:17 -05:00
drm_gem_cma_helper.c
…
drm_gem_framebuffer_helper.c
drm/gem-fb-helper: convert to drm device based logging
2019-12-19 15:55:10 +02:00
drm_gem_shmem_helper.c
drm/shmem: drop pgprot_decrypted()
2020-03-02 07:13:19 +01:00
drm_gem_ttm_helper.c
drm/ttm: fix mmap refcounting
2019-11-15 08:00:08 +01:00
drm_gem_vram_helper.c
drm/vram: Add helpers to validate a display mode's memory requirements
2020-02-06 10:32:54 +01:00
drm_gem.c
drm: Mark up racy check of drm_gem_object.handle_count
2020-03-16 10:31:35 +00:00
drm_hashtab.c
…
drm_hdcp.c
drm/hdcp: optimizing the srm handling
2020-03-04 06:33:00 +05:30
drm_internal.h
drm/hdcp: optimizing the srm handling
2020-03-04 06:33:00 +05:30
drm_ioc32.c
…
drm_ioctl.c
drm: Add getfb2 ioctl
2020-01-14 16:22:17 -05:00
drm_irq.c
drm/irq: remove check on dev->dev_private
2020-02-11 18:39:47 +02:00
drm_kms_helper_common.c
drm: fix module name in edid_firmware log message
2019-08-22 10:41:06 +03:00
drm_lease.c
drm/lease: fix WARNING in idr_destroy
2020-03-18 14:42:18 +01:00
drm_legacy_misc.c
…
drm_legacy.h
…
drm_lock.c
drm: lock: Clean up documentation
2020-03-16 09:27:09 +01:00
drm_memory.c
drm: Include prototype for drm_need_swiotlb()
2019-09-30 20:16:28 +03:00
drm_mipi_dbi.c
drm/mipi-dbi: Remove sending of vblank event
2020-01-30 09:00:45 +01:00
drm_mipi_dsi.c
drm/dsi: add helpers for DSI compression mode and PPS packets
2019-11-07 15:00:16 +02:00
drm_mm.c
drm/mm: revert "Break long searches in fragmented address spaces"
2020-03-31 17:35:56 +02:00
drm_mode_config.c
drm/modeset: Prime modeset lock vs dma_resv
2019-11-21 11:03:31 +01:00
drm_mode_object.c
drm/property: Enforce more lifetime rules
2019-11-04 18:17:36 +01:00
drm_modes.c
drm/modes: Make sure to parse valid rotation value from cmdline
2020-02-12 18:32:54 +01:00
drm_modeset_helper.c
…
drm_modeset_lock.c
…
drm_of.c
drm: of: Add drm_of_lvds_get_dual_link_pixel_order
2019-12-18 02:40:16 +02:00
drm_panel_orientation_quirks.c
…
drm_panel.c
drm/drm_panel: Fix EXPORT of drm_panel_of_backlight() one more time
2019-12-17 20:39:33 +01:00
drm_pci.c
drm: Make drm_pci_agp_init legacy
2020-03-09 09:22:50 +00:00
drm_plane_helper.c
…
drm_plane.c
…
drm_prime.c
drm/prime: fix extracting of the DMA addresses from a scatterlist
2020-04-05 10:44:12 -04:00
drm_print.c
drm/print: convert debug category macros into an enum
2019-11-14 14:08:57 +02:00
drm_probe_helper.c
drm: Stop accessing encoder->bridge directly
2019-12-09 10:02:45 +01:00
drm_property.c
drm: limit to INT_MAX in create_blob ioctl
2019-12-04 19:44:13 -08:00
drm_rect.c
drm/rect: update kerneldoc for drm_rect_clip_scaled()
2019-11-28 13:15:43 +01:00
drm_scatter.c
drm: prevent a harmless integer overflow in drm_legacy_sg_alloc()
2020-02-29 00:16:12 +01:00
drm_scdc_helper.c
…
drm_self_refresh_helper.c
drm/atomic: fix self-refresh helpers crtc state dereference
2019-11-06 13:00:21 -05:00
drm_simple_kms_helper.c
drm/simple-kms: Fix documentation for drm_simple_encoder_init()
2020-03-06 09:24:29 +01:00
drm_syncobj.c
drm/syncobj: Add documentation for timeline syncobj
2020-01-20 14:22:21 +01:00
drm_sysfs.c
drm: sysfs: Use scnprintf() for avoiding potential buffer overflow
2020-03-11 14:54:09 +01:00
drm_trace_points.c
…
drm_trace.h
drm: Add high-precision time to vblank trace event
2019-09-03 09:46:18 +02:00
drm_vblank.c
drm/vblank: Fix documentation of VBLANK timestamp helper
2020-03-06 09:24:54 +01:00
drm_vm.c
drm: vm: Clean up documentation
2020-03-16 09:25:22 +01:00
drm_vma_manager.c
…
drm_vram_helper_common.c
drm/vram: Have VRAM MM call GEM VRAM functions directly
2019-09-12 19:54:42 +02:00
drm_writeback.c
drm: Clear the fence pointer when writeback job signaled
2019-09-23 15:32:53 +08:00
Kconfig
drm: unbreak the DRM menu, broken by DRM_EXPORT_FOR_TESTS
2020-03-06 11:15:43 +00:00
Makefile
drm: Add helper to create a connector for a chain of bridges
2020-02-26 13:31:41 +02:00