David Arcari
3279decb2c
platform/x86/intel/ifs: Annotate work queue on stack so object debug does not complain ...
Object Debug results in the following warning while attempting to load
ifs firmware:
[ 220.007422] ODEBUG: object 000000003bf952db is on stack 00000000e843994b, but NOT annotated.
[ 220.007459] ------------[ cut here ]------------
[ 220.007461] WARNING: CPU: 0 PID: 11774 at lib/debugobjects.c:548 __debug_object_init.cold+0x22e/0x2d5
[ 220.137476] RIP: 0010:__debug_object_init.cold+0x22e/0x2d5
[ 220.254774] Call Trace:
[ 220.257641] <TASK>
[ 220.265606] scan_chunks_sanity_check+0x368/0x5f0 [intel_ifs]
[ 220.288292] ifs_load_firmware+0x2a3/0x400 [intel_ifs]
[ 220.332793] current_batch_store+0xea/0x160 [intel_ifs]
[ 220.357947] kernfs_fop_write_iter+0x355/0x530
[ 220.363048] new_sync_write+0x28e/0x4a0
[ 220.381226] vfs_write+0x62a/0x920
[ 220.385160] ksys_write+0xf9/0x1d0
[ 220.399421] do_syscall_64+0x59/0x90
[ 220.440635] entry_SYSCALL_64_after_hwframe+0x63/0xcd
[ 220.566845] ---[ end trace 3a01b299db142b41 ]---
Correct this by calling INIT_WORK_ONSTACK instead of INIT_WORK.
Fixes: 684ec215706d ("platform/x86/intel/ifs: Authenticate and copy to secured memory")
Signed-off-by: David Arcari <darcari@redhat.com>
Cc: Jithu Joseph <jithu.joseph@intel.com>
Cc: Ashok Raj <ashok.raj@intel.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Gross <markgross@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: linux-kernel@vger.kernel.org
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20230523105400.674152-1-darcari@redhat.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
2023-05-23 12:55:16 +02:00
2023-05-15 14:56:13 +02:00
2023-03-16 14:51:07 +01:00
2023-05-09 10:54:33 +02:00
2023-05-23 12:55:16 +02:00
2023-04-17 12:23:26 +02:00
2023-03-07 12:19:13 +01:00
2023-04-25 18:32:43 -07:00
2023-03-07 12:19:26 +01:00
2023-03-07 12:19:43 +01:00
2023-04-06 14:24:04 +02:00
2022-11-23 19:11:22 +01:00
2023-05-15 14:55:57 +02:00
2023-02-06 15:08:45 +01:00
2022-11-23 19:11:22 +01:00
2023-01-24 13:41:13 +01:00
2023-01-12 19:35:51 +01:00
2023-03-07 12:19:45 +01:00
2023-03-16 16:10:54 +01:00
2023-03-07 12:19:47 +01:00
2021-08-12 17:26:36 +02:00
2022-11-23 19:11:22 +01:00
2022-09-03 12:17:27 +02:00
2022-11-23 19:11:22 +01:00
2022-11-23 19:11:22 +01:00
2023-03-31 19:31:48 +02:00
2022-10-03 09:40:04 +02:00
2023-03-07 12:20:17 +01:00
2023-03-17 15:29:06 +01:00
2023-04-25 16:59:48 -07:00
2023-04-06 12:33:34 +02:00
2023-03-17 15:16:27 +01:00
2023-05-08 17:35:08 +02:00
2023-04-06 12:33:34 +02:00
2023-04-06 12:33:34 +02:00
2021-12-07 12:21:01 +01:00
2022-12-12 13:38:17 -08:00
2023-04-06 12:33:34 +02:00
2021-08-12 09:26:28 +02:00
2023-03-07 12:08:30 +01:00
2023-03-27 16:10:20 +02:00
2023-03-27 16:10:20 +02:00
2022-10-03 09:40:04 +02:00
2022-12-08 16:32:12 +01:00
2023-02-18 11:45:52 +01:00
2022-11-07 12:33:49 +01:00
2022-11-23 19:11:22 +01:00
2023-03-16 16:14:52 +01:00
2022-08-25 16:23:52 +02:00
2022-10-03 09:40:04 +02:00
2023-03-07 12:20:44 +01:00
2023-04-27 11:02:26 -07:00
2023-01-12 19:42:53 +01:00
2023-03-16 16:11:03 +01:00
2022-12-12 13:38:17 -08:00
2023-04-25 16:59:48 -07:00
2022-04-04 15:20:53 +02:00
2023-05-09 10:54:45 +02:00
2022-11-23 19:11:22 +01:00
2022-12-12 13:38:17 -08:00
2022-11-23 19:11:22 +01:00
2022-11-23 19:11:22 +01:00
2023-05-09 10:54:58 +02:00
2023-02-10 17:24:37 +01:00
2022-10-03 09:40:04 +02:00
2022-12-12 13:38:17 -08:00
2023-03-07 12:20:47 +01:00
2023-03-07 12:20:50 +01:00
2022-11-23 19:11:22 +01:00
3279decb2c