iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net
History
Luiz Augusto von Dentz 4bcefec363 Bluetooth: hci_sysfs: Fix attempting to call device_add multiple times 
[ Upstream commit 448a496f760664d3e2e79466aa1787e6abc922b5 ]

device_add shall not be called multiple times as stated in its
documentation:

 'Do not call this routine or device_register() more than once for
 any device structure'

Syzkaller reports a bug as follows [1]:
------------[ cut here ]------------
kernel BUG at lib/list_debug.c:33!
invalid opcode: 0000 [#1] PREEMPT SMP KASAN
[...]
Call Trace:
 <TASK>
 __list_add include/linux/list.h:69 [inline]
 list_add_tail include/linux/list.h:102 [inline]
 kobj_kset_join lib/kobject.c:164 [inline]
 kobject_add_internal+0x18f/0x8f0 lib/kobject.c:214
 kobject_add_varg lib/kobject.c:358 [inline]
 kobject_add+0x150/0x1c0 lib/kobject.c:410
 device_add+0x368/0x1e90 drivers/base/core.c:3452
 hci_conn_add_sysfs+0x9b/0x1b0 net/bluetooth/hci_sysfs.c:53
 hci_le_cis_estabilished_evt+0x57c/0xae0 net/bluetooth/hci_event.c:6799
 hci_le_meta_evt+0x2b8/0x510 net/bluetooth/hci_event.c:7110
 hci_event_func net/bluetooth/hci_event.c:7440 [inline]
 hci_event_packet+0x63d/0xfd0 net/bluetooth/hci_event.c:7495
 hci_rx_work+0xae7/0x1230 net/bluetooth/hci_core.c:4007
 process_one_work+0x991/0x1610 kernel/workqueue.c:2289
 worker_thread+0x665/0x1080 kernel/workqueue.c:2436
 kthread+0x2e4/0x3a0 kernel/kthread.c:376
 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306
 </TASK>

Link: https://syzkaller.appspot.com/bug?id=da3246e2d33afdb92d66bc166a0934c5b146404a
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Tested-by: Hawkins Jiawei <yin31149@gmail.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2022-10-26 13:15:46 +02:00
..
6lowpan
6lowpan: Off by one handling ->nexthdr
2020-01-29 10:24:22 +01:00
9p
net/9p: Initialize the iounit field during fid creation
2022-08-25 11:09:27 +02:00
802
net/802/garp: fix memleak in garp_request_join()
2021-08-04 11:58:02 +02:00
8021q
vlan: fix memory leak in vlan_dev_set_egress_priority
2020-01-12 11:24:27 +01:00
appletalk
appletalk: Fix skb allocation size in loopback case
2021-04-07 12:05:39 +02:00
atm
atm: fix a memory leak of vcc->user_back
2020-10-01 20:40:12 +02:00
ax25
ax25: Fix NULL pointer dereference in ax25_kill_by_device
2022-03-16 12:49:00 +01:00
batman-adv
batman-adv: Don't expect inter-netns unique iflink indices
2022-03-16 12:49:01 +01:00
bluetooth
Bluetooth: hci_sysfs: Fix attempting to call device_add multiple times
2022-10-26 13:15:46 +02:00
bridge
netfilter: br_netfilter: Drop dst references before setting.
2022-09-15 12:39:46 +02:00
caif
net-caif: avoid user-triggerable WARN_ON(1)
2021-09-22 11:43:09 +02:00
can
can: bcm: fix UAF of bcm op
2022-02-08 18:15:26 +01:00
ceph
libceph: clear con->out_msg on Policy::stateful_server faults
2020-11-10 10:23:59 +01:00
core
net: Fix a data-race around sysctl_net_busy_read.
2022-09-05 10:23:55 +02:00
dcb
net: dcb: disable softirqs in dcbnl_flush_dev()
2022-03-08 19:00:59 +01:00
dccp
dccp: don't duplicate ccid when cloning dccp sock
2021-09-22 11:43:09 +02:00
decnet
net: decnet: Fix sleeping inside in af_decnet
2021-07-28 09:14:27 +02:00
dns_resolver
KEYS: DNS: fix parsing multiple options
2018-07-22 14:27:39 +02:00
dsa
net: dsa: tag_brcm: Fix skb->fwd_offload_mark location
2020-04-13 10:32:53 +02:00
ethernet
net: add annotations on hh->hh_len lockless accesses
2020-01-12 11:24:19 +01:00
hsr
hsr: use netdev_err() instead of WARN_ONCE()
2021-05-22 10:40:20 +02:00
ieee802154
net/ieee802154: fix uninit value bug in dgram_sendmsg
2022-10-26 13:15:34 +02:00
ipv4
tcp: annotate data-race around tcp_md5sig_pool_populated
2022-10-26 13:15:45 +02:00
ipv6
net: ping6: Fix memleak in ipv6_renew_options().
2022-08-25 11:09:20 +02:00
ipx
ipx: call ipxitf_put() in ioctl error path
2017-05-25 15:44:41 +02:00
irda
irda: Only insert new objects into the global database via setsockopt
2018-09-15 09:43:01 +02:00
iucv
net/af_iucv: set correct sk_protocol for child sockets
2020-12-11 13:37:56 +01:00
kcm
kcm: switch order of device registration to fix a crash
2019-04-17 08:36:44 +02:00
key
af_key: Do not call xfrm_probe_algs in parallel
2022-09-05 10:23:54 +02:00
l2tp
l2tp: fix race in pppol2tp_release with session object destroy
2022-06-25 11:45:19 +02:00
l3mdev
…
lapb
net: lapb: Copy the skb before sending a packet
2021-02-10 09:09:25 +01:00
llc
llc: only change llc->dev when bind() succeeds
2022-03-28 08:06:06 +02:00
mac80211
wifi: mac80211: allow bw change during channel switch in mesh
2022-10-26 13:15:39 +02:00
mac802154
net: mac802154: Fix a condition in the receive path
2022-09-15 12:39:45 +02:00
mpls
net: avoid infinite loop in mpls_gso_segment when mpls_hlen == 0
2021-03-17 16:10:13 +01:00
ncsi
net/ncsi: Use real net-device for response handler
2021-01-12 19:49:01 +01:00
netfilter
netfilter: nf_conntrack_irc: Tighten matching on DCC message
2022-09-28 10:55:45 +02:00
netlabel
cipso,calipso: resolve a number of problems with the DOI refcounts
2022-01-27 08:47:42 +01:00
netlink
netlink: do not reset transport header in netlink_recvmsg()
2022-05-18 09:15:43 +02:00
netrom
netrom: Decrease sock refcount when sock timers expire
2021-07-28 09:14:27 +02:00
nfc
NFC: NULL out the dev->rfkill to prevent UAF
2022-06-14 16:52:31 +02:00
openvswitch
openvswitch: Fix overreporting of drops in dropwatch
2022-10-26 13:15:45 +02:00
packet
net/packet: fix packet_sock xmit return value checking
2022-04-27 13:14:10 +02:00
phonet
phonet: refcount leak in pep_sock_accep
2022-01-11 13:38:12 +01:00
qrtr
net: qrtr: fix a kernel-infoleak in qrtr_recvmsg()
2021-03-30 14:41:42 +02:00
rds
net: rds: don't hold sock lock when cancelling work from rds_tcp_reset_callbacks()
2022-10-26 13:15:40 +02:00
rfkill
rfkill: Fix incorrect check to avoid NULL pointer dereference
2020-01-12 11:24:23 +01:00
rose
rose: check NULL rose_loopback_neigh->loopback
2022-09-05 10:23:54 +02:00
rxrpc
rxrpc: Don't try to resend the request if we're receiving the reply
2022-06-14 16:52:33 +02:00
sched
sch_sfb: Also store skb len before calling child enqueue
2022-09-15 12:39:46 +02:00
sctp
sctp: read sk->sk_bound_dev_if once in sctp_rcv()
2022-06-14 16:52:32 +02:00
strparser
strparser: Fix incorrect strp->need_bytes value.
2018-04-29 11:32:02 +02:00
sunrpc
SUNRPC: use _bh spinlocking on ->transport_lock
2022-09-15 12:39:46 +02:00
switchdev
…
tipc
tipc: fix shift wrapping bug in map_get()
2022-09-15 12:39:46 +02:00
unix
af_unix: annote lockless accesses to unix_tot_inflight & gc_in_progress
2022-01-27 08:47:41 +01:00
vmw_vsock
vsock: Fix memory leak in vsock_connect()
2022-08-25 11:09:29 +02:00
wimax
…
wireless
wifi: cfg80211: debugfs: fix return type in ht40allow_map_read()
2022-09-15 12:39:44 +02:00
x25
net/x25: Fix null-ptr-deref caused by x25_disconnect
2022-04-20 09:06:38 +02:00
xfrm
xfrm: Update ipcomp_scratches with NULL when freed
2022-10-26 13:15:45 +02:00
compat.c
net: Return the correct errno code
2021-06-30 08:49:12 -04:00
Kconfig
…
Makefile
net: split out functions related to registering inflight socket files
2021-08-04 11:58:01 +02:00
socket.c
net: Fix a data-race around sysctl_somaxconn.
2022-09-05 10:23:55 +02:00
sysctl_net.c
…