iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
4d8610ee8b
linux/tools/testing/selftests/sgx
History
Tianjia Zhang 567c39047d selftests/sgx: Fix Q1 and Q2 calculation in sigstruct.c 
Q1 and Q2 are numbers with *maximum* length of 384 bytes. If the
calculated length of Q1 and Q2 is less than 384 bytes, things will
go wrong.

E.g. if Q2 is 383 bytes, then

1. The bytes of q2 are copied to sigstruct->q2 in calc_q1q2().
2. The entire sigstruct->q2 is reversed, which results it being
   256 * Q2, given that the last byte of sigstruct->q2 is added
   to before the bytes given by calc_q1q2().

Either change in key or measurement can trigger the bug. E.g. an
unmeasured heap could cause a devastating change in Q1 or Q2.

Reverse exactly the bytes of Q1 and Q2 in calc_q1q2() before returning
to the caller.

Fixes: 2adcba79e6 ("selftests/x86: Add a selftest for SGX")
Link: https://lore.kernel.org/linux-sgx/20210301051836.30738-1-tianjia.zhang@linux.alibaba.com/
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
2021-07-30 17:20:01 -06:00
..
.gitignore
call.S selftests/sgx: Rename 'eenter' and 'sgx_call_vdso' 2021-06-15 16:21:23 -06:00
defines.h selftests/sgx: Refine the test enclave to have storage 2021-06-15 16:27:23 -06:00
load.c selftests/sgx: remove checks for file execute permissions 2021-06-23 18:38:04 -06:00
main.c selftests/sgx: Refine the test enclave to have storage 2021-06-15 16:27:23 -06:00
main.h selftests/sgx: Rename 'eenter' and 'sgx_call_vdso' 2021-06-15 16:21:23 -06:00
Makefile
sign_key.pem
sign_key.S
sigstruct.c selftests/sgx: Fix Q1 and Q2 calculation in sigstruct.c 2021-07-30 17:20:01 -06:00
test_encl_bootstrap.S
test_encl.c selftests/sgx: Refine the test enclave to have storage 2021-06-15 16:27:23 -06:00
test_encl.lds selftests/sgx: Refine the test enclave to have storage 2021-06-15 16:27:23 -06:00