commit 65946690ed8d972fdb91a74ee75ac0f0f0d68321 upstream. The coreboot_table driver registers a coreboot bus while probing a "coreboot_table" device representing the coreboot table memory region. Probing this device (i.e., registering the bus) is a dependency for the module_init() functions of any driver for this bus (e.g., memconsole-coreboot.c / memconsole_driver_init()). With synchronous probe, this dependency works OK, as the link order in the Makefile ensures coreboot_table_driver_init() (and thus, coreboot_table_probe()) completes before a coreboot device driver tries to add itself to the bus. With asynchronous probe, however, coreboot_table_probe() may race with memconsole_driver_init(), and so we're liable to hit one of these two: 1. coreboot_driver_register() eventually hits "[...] the bus was not initialized.", and the memconsole driver fails to register; or 2. coreboot_driver_register() gets past #1, but still races with bus_register() and hits some other undefined/crashing behavior (e.g., in driver_find() [1]) We can resolve this by registering the bus in our initcall, and only deferring "device" work (scanning the coreboot memory region and creating sub-devices) to probe(). [1] Example failure, using 'driver_async_probe=*' kernel command line: [ 0.114217] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000010 ... [ 0.114307] CPU: 1 PID: 1 Comm: swapper/0 Not tainted 6.1.0-rc1 #63 [ 0.114316] Hardware name: Google Scarlet (DT) ... [ 0.114488] Call trace: [ 0.114494] _raw_spin_lock+0x34/0x60 [ 0.114502] kset_find_obj+0x28/0x84 [ 0.114511] driver_find+0x30/0x50 [ 0.114520] driver_register+0x64/0x10c [ 0.114528] coreboot_driver_register+0x30/0x3c [ 0.114540] memconsole_driver_init+0x24/0x30 [ 0.114550] do_one_initcall+0x154/0x2e0 [ 0.114560] do_initcall_level+0x134/0x160 [ 0.114571] do_initcalls+0x60/0xa0 [ 0.114579] do_basic_setup+0x28/0x34 [ 0.114588] kernel_init_freeable+0xf8/0x150 [ 0.114596] kernel_init+0x2c/0x12c [ 0.114607] ret_from_fork+0x10/0x20 [ 0.114624] Code: 5280002b 1100054a b900092a f9800011 (885ffc01) [ 0.114631] ---[ end trace 0000000000000000 ]--- Fixes: b81e3140e412 ("firmware: coreboot: Make bus registration symmetric") Cc: <stable@vger.kernel.org> Signed-off-by: Brian Norris <briannorris@chromium.org> Reviewed-by: Guenter Roeck <linux@roeck-us.net> Reviewed-by: Stephen Boyd <swboyd@chromium.org> Link: https://lore.kernel.org/r/20221019180934.1.If29e167d8a4771b0bf4a39c89c6946ed764817b9@changeid Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
229 lines
5.0 KiB
C
229 lines
5.0 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* coreboot_table.c
|
|
*
|
|
* Module providing coreboot table access.
|
|
*
|
|
* Copyright 2017 Google Inc.
|
|
* Copyright 2017 Samuel Holland <samuel@sholland.org>
|
|
*/
|
|
|
|
#include <linux/acpi.h>
|
|
#include <linux/device.h>
|
|
#include <linux/err.h>
|
|
#include <linux/init.h>
|
|
#include <linux/io.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/of.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/slab.h>
|
|
|
|
#include "coreboot_table.h"
|
|
|
|
#define CB_DEV(d) container_of(d, struct coreboot_device, dev)
|
|
#define CB_DRV(d) container_of(d, struct coreboot_driver, drv)
|
|
|
|
static int coreboot_bus_match(struct device *dev, struct device_driver *drv)
|
|
{
|
|
struct coreboot_device *device = CB_DEV(dev);
|
|
struct coreboot_driver *driver = CB_DRV(drv);
|
|
|
|
return device->entry.tag == driver->tag;
|
|
}
|
|
|
|
static int coreboot_bus_probe(struct device *dev)
|
|
{
|
|
int ret = -ENODEV;
|
|
struct coreboot_device *device = CB_DEV(dev);
|
|
struct coreboot_driver *driver = CB_DRV(dev->driver);
|
|
|
|
if (driver->probe)
|
|
ret = driver->probe(device);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int coreboot_bus_remove(struct device *dev)
|
|
{
|
|
int ret = 0;
|
|
struct coreboot_device *device = CB_DEV(dev);
|
|
struct coreboot_driver *driver = CB_DRV(dev->driver);
|
|
|
|
if (driver->remove)
|
|
ret = driver->remove(device);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static struct bus_type coreboot_bus_type = {
|
|
.name = "coreboot",
|
|
.match = coreboot_bus_match,
|
|
.probe = coreboot_bus_probe,
|
|
.remove = coreboot_bus_remove,
|
|
};
|
|
|
|
static void coreboot_device_release(struct device *dev)
|
|
{
|
|
struct coreboot_device *device = CB_DEV(dev);
|
|
|
|
kfree(device);
|
|
}
|
|
|
|
int coreboot_driver_register(struct coreboot_driver *driver)
|
|
{
|
|
driver->drv.bus = &coreboot_bus_type;
|
|
|
|
return driver_register(&driver->drv);
|
|
}
|
|
EXPORT_SYMBOL(coreboot_driver_register);
|
|
|
|
void coreboot_driver_unregister(struct coreboot_driver *driver)
|
|
{
|
|
driver_unregister(&driver->drv);
|
|
}
|
|
EXPORT_SYMBOL(coreboot_driver_unregister);
|
|
|
|
static int coreboot_table_populate(struct device *dev, void *ptr)
|
|
{
|
|
int i, ret;
|
|
void *ptr_entry;
|
|
struct coreboot_device *device;
|
|
struct coreboot_table_entry *entry;
|
|
struct coreboot_table_header *header = ptr;
|
|
|
|
ptr_entry = ptr + header->header_bytes;
|
|
for (i = 0; i < header->table_entries; i++) {
|
|
entry = ptr_entry;
|
|
|
|
device = kzalloc(sizeof(struct device) + entry->size, GFP_KERNEL);
|
|
if (!device)
|
|
return -ENOMEM;
|
|
|
|
dev_set_name(&device->dev, "coreboot%d", i);
|
|
device->dev.parent = dev;
|
|
device->dev.bus = &coreboot_bus_type;
|
|
device->dev.release = coreboot_device_release;
|
|
memcpy(&device->entry, ptr_entry, entry->size);
|
|
|
|
ret = device_register(&device->dev);
|
|
if (ret) {
|
|
put_device(&device->dev);
|
|
return ret;
|
|
}
|
|
|
|
ptr_entry += entry->size;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int coreboot_table_probe(struct platform_device *pdev)
|
|
{
|
|
resource_size_t len;
|
|
struct coreboot_table_header *header;
|
|
struct resource *res;
|
|
struct device *dev = &pdev->dev;
|
|
void *ptr;
|
|
int ret;
|
|
|
|
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
|
|
if (!res)
|
|
return -EINVAL;
|
|
|
|
len = resource_size(res);
|
|
if (!res->start || !len)
|
|
return -EINVAL;
|
|
|
|
/* Check just the header first to make sure things are sane */
|
|
header = memremap(res->start, sizeof(*header), MEMREMAP_WB);
|
|
if (!header)
|
|
return -ENOMEM;
|
|
|
|
len = header->header_bytes + header->table_bytes;
|
|
ret = strncmp(header->signature, "LBIO", sizeof(header->signature));
|
|
memunmap(header);
|
|
if (ret) {
|
|
dev_warn(dev, "coreboot table missing or corrupt!\n");
|
|
return -ENODEV;
|
|
}
|
|
|
|
ptr = memremap(res->start, len, MEMREMAP_WB);
|
|
if (!ptr)
|
|
return -ENOMEM;
|
|
|
|
ret = coreboot_table_populate(dev, ptr);
|
|
|
|
memunmap(ptr);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int __cb_dev_unregister(struct device *dev, void *dummy)
|
|
{
|
|
device_unregister(dev);
|
|
return 0;
|
|
}
|
|
|
|
static int coreboot_table_remove(struct platform_device *pdev)
|
|
{
|
|
bus_for_each_dev(&coreboot_bus_type, NULL, NULL, __cb_dev_unregister);
|
|
return 0;
|
|
}
|
|
|
|
#ifdef CONFIG_ACPI
|
|
static const struct acpi_device_id cros_coreboot_acpi_match[] = {
|
|
{ "GOOGCB00", 0 },
|
|
{ "BOOT0000", 0 },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(acpi, cros_coreboot_acpi_match);
|
|
#endif
|
|
|
|
#ifdef CONFIG_OF
|
|
static const struct of_device_id coreboot_of_match[] = {
|
|
{ .compatible = "coreboot" },
|
|
{}
|
|
};
|
|
MODULE_DEVICE_TABLE(of, coreboot_of_match);
|
|
#endif
|
|
|
|
static struct platform_driver coreboot_table_driver = {
|
|
.probe = coreboot_table_probe,
|
|
.remove = coreboot_table_remove,
|
|
.driver = {
|
|
.name = "coreboot_table",
|
|
.acpi_match_table = ACPI_PTR(cros_coreboot_acpi_match),
|
|
.of_match_table = of_match_ptr(coreboot_of_match),
|
|
},
|
|
};
|
|
|
|
static int __init coreboot_table_driver_init(void)
|
|
{
|
|
int ret;
|
|
|
|
ret = bus_register(&coreboot_bus_type);
|
|
if (ret)
|
|
return ret;
|
|
|
|
ret = platform_driver_register(&coreboot_table_driver);
|
|
if (ret) {
|
|
bus_unregister(&coreboot_bus_type);
|
|
return ret;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static void __exit coreboot_table_driver_exit(void)
|
|
{
|
|
platform_driver_unregister(&coreboot_table_driver);
|
|
bus_unregister(&coreboot_bus_type);
|
|
}
|
|
|
|
module_init(coreboot_table_driver_init);
|
|
module_exit(coreboot_table_driver_exit);
|
|
|
|
MODULE_AUTHOR("Google, Inc.");
|
|
MODULE_LICENSE("GPL");
|