iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/tty/serial
History
Pavel Krasavin 2ed25af15b tty: serial: meson: fix hard LOCKUP on crtscts mode 
[ Upstream commit 2a1d728f20edeee7f26dc307ed9df4e0d23947ab ]

There might be hard lockup if we set crtscts mode on port without RTS/CTS configured:

# stty -F /dev/ttyAML6 crtscts; echo 1 > /dev/ttyAML6; echo 2 > /dev/ttyAML6
[   95.890386] rcu: INFO: rcu_preempt detected stalls on CPUs/tasks:
[   95.890857] rcu:     3-...0: (201 ticks this GP) idle=e33c/1/0x4000000000000000 softirq=5844/5846 fqs=4984
[   95.900212] rcu:     (detected by 2, t=21016 jiffies, g=7753, q=296 ncpus=4)
[   95.906972] Task dump for CPU 3:
[   95.910178] task:bash            state:R  running task     stack:0     pid:205   ppid:1      flags:0x00000202
[   95.920059] Call trace:
[   95.922485]  __switch_to+0xe4/0x168
[   95.925951]  0xffffff8003477508
[   95.974379] watchdog: Watchdog detected hard LOCKUP on cpu 3
[   95.974424] Modules linked in: 88x2cs(O) rtc_meson_vrtc

Possible solution would be to not allow to setup crtscts on such port.

Tested on S905X3 based board.

Fixes: ff7693d079e5 ("ARM: meson: serial: add MesonX SoC on-chip uart driver")
Cc: stable@vger.kernel.org
Signed-off-by: Pavel Krasavin <pkrasavin@imaqliq.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Dmitry Rokosov <ddrokosov@salutedevices.com>

v6: stable tag added
v5: https://lore.kernel.org/lkml/OF43DA36FF.2BD3BB21-ON00258A47.005A8125-00258A47.005A9513@gdc.ru/
added missed Reviewed-by tags, Fixes tag added according to Dmitry and Neil notes
v4: https://lore.kernel.org/lkml/OF55521400.7512350F-ON00258A47.003F7254-00258A47.0040E15C@gdc.ru/
More correct patch subject according to Jiri's note
v3: https://lore.kernel.org/lkml/OF6CF5FFA0.CCFD0E8E-ON00258A46.00549EDF-00258A46.0054BB62@gdc.ru/
"From:" line added to the mail
v2: https://lore.kernel.org/lkml/OF950BEF72.7F425944-ON00258A46.00488A76-00258A46.00497D44@gdc.ru/
braces for single statement removed according to Dmitry's note
v1: https://lore.kernel.org/lkml/OF28B2B8C9.5BC0CD28-ON00258A46.0037688F-00258A46.0039155B@gdc.ru/
Link: https://lore.kernel.org/r/OF66360032.51C36182-ON00258A48.003F656B-00258A48.0040092C@gdc.ru

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-11-28 16:54:59 +00:00
..
8250
tty: 8250: Add support for Intashield IS-100
2023-11-08 17:30:51 +01:00
cpm_uart
serial: cpm_uart: Avoid suspicious locking
2023-09-23 11:01:08 +02:00
jsm
drivers: serial: jsm: fix some leaks in probe
2022-10-26 13:25:36 +02:00
21285.c
tty: serial: 21285: fix lockup on open
2020-10-28 13:39:14 +01:00
altera_jtaguart.c
serial: altera_jtaguart: Replace HTTP links with HTTPS ones
2020-07-21 20:04:54 +02:00
altera_uart.c
serial: altera_uart: fix locking in polling mode
2023-01-14 10:15:56 +01:00
amba-pl010.c
amba: Make the remove callback return void
2022-04-08 14:40:02 +02:00
amba-pl011.c
serial: pl011: Do not clear RX FIFO & RX interrupt in unthrottle.
2023-01-14 10:15:56 +01:00
amba-pl011.h
…
apbuart.c
…
apbuart.h
…
ar933x_uart.c
serial: ar933x: Deassert Transmit Enable on ->rs485_config()
2022-11-10 18:14:14 +01:00
arc_uart.c
serial: arc_uart: fix of_iomap leak in arc_serial_probe
2023-05-30 12:57:52 +01:00
atmel_serial.c
serial: atmel: don't enable IRQs prematurely
2023-07-27 08:44:29 +02:00
atmel_serial.h
…
bcm63xx_uart.c
Revert "tty: serial: bcm63xx: fix missing clk_put() in bcm63xx_uart"
2020-05-04 11:49:57 +02:00
clps711x.c
…
digicolor-usart.c
serial: digicolor-usart: Don't allow CS5-6
2022-06-14 18:32:33 +02:00
dz.c
…
dz.h
…
earlycon-arm-semihost.c
…
earlycon-riscv-sbi.c
…
earlycon.c
tty: serial: print earlycon info after match->setup
2020-09-16 13:16:20 +02:00
efm32-uart.c
…
fsl_linflexuart.c
…
fsl_lpuart.c
tty: serial: fsl_lpuart: Clear the error flags by writing 1 for lpuart32 platforms
2023-08-26 15:26:51 +02:00
icom.c
tty: Fix a possible resource leak in icom_probe
2022-06-14 18:32:42 +02:00
icom.h
…
ifx6x60.c
tty: serial, fix kernel-doc
2020-08-18 13:51:18 +02:00
ifx6x60.h
tty: serial: ifx6x60: Convert to GPIO descriptors
2020-03-12 10:03:54 +01:00
imx_earlycon.c
tty: serial: imx: add imx earlycon driver
2020-07-29 17:11:02 +02:00
imx.c
serial: imx: Add missing .thaw_noirq hook
2022-11-25 17:45:43 +01:00
ip22zilog.c
…
ip22zilog.h
…
Kconfig
tty: serial: imx: enable earlycon by default if IMX_SERIAL_CONSOLE is enabled
2020-11-06 17:23:49 +01:00
kgdb_nmi.c
kdb: Switch to use safer dbg_io_ops over console APIs
2020-06-26 15:40:16 +01:00
kgdboc.c
kgdboc: fix return value of __setup handler
2022-04-08 14:40:28 +02:00
lantiq.c
serial: lantiq: add missing interrupt ack
2023-06-21 15:45:38 +02:00
lpc32xx_hs.c
tty: drivers/tty/, stop using tty_schedule_flip()
2022-07-29 17:19:27 +02:00
Makefile
tty: serial: imx: add dependence and build for earlycon
2020-08-18 13:54:34 +02:00
max310x.c
serial: max310x: unregister uart driver in case of failure and abort
2021-06-03 09:00:40 +02:00
max3100.c
…
mcf.c
serial: mcf: add sysrq capability
2020-10-05 13:32:30 +02:00
men_z135_uart.c
tty: serial, fix kernel-doc
2020-08-18 13:51:18 +02:00
meson_uart.c
tty: serial: meson: fix hard LOCKUP on crtscts mode
2023-11-28 16:54:59 +00:00
milbeaut_usio.c
…
mpc52xx_uart.c
…
mps2-uart.c
…
msm_serial.c
serial: msm_serial: disable interrupts in __msm_console_write()
2022-06-14 18:32:43 +02:00
mux.c
…
mvebu-uart.c
serial: mvebu-uart: uart2 error bits clearing
2022-08-21 15:15:25 +02:00
mxs-auart.c
serial: mxs-auart: add missed iounmap() in probe failure and remove
2020-07-10 14:44:46 +02:00
omap-serial.c
serial: omap: fix rs485 half-duplex filtering
2021-05-14 09:50:21 +02:00
owl-uart.c
tty: serial: owl: Fix missing clk_disable_unprepare() in owl_uart_probe
2022-06-14 18:32:30 +02:00
pch_uart.c
serial: pch_uart: Pass correct sg to dma_unmap_sg()
2023-01-24 07:20:00 +01:00
pic32_uart.c
serial: pic32_uart: Use uart_console() helper
2020-03-12 10:00:22 +01:00
pic32_uart.h
…
pmac_zilog.c
m68k: Fix WARNING splat in pmac_zilog driver
2020-12-30 11:54:11 +01:00
pmac_zilog.h
…
pnx8xxx_uart.c
…
pxa.c
…
qcom_geni_serial.c
serial: qcom-geni: fix opp vote on shutdown
2023-09-19 12:20:03 +02:00
rda-uart.c
serial: rda-uart: Don't allow CS5-6
2022-06-14 18:32:33 +02:00
rp2.c
serial: rp2: use 'request_firmware' instead of 'request_firmware_nowait'
2021-06-03 09:00:34 +02:00
sa1100.c
drivers: tty: serial: Fix deadlock in sa1100_set_termios()
2022-06-14 18:32:42 +02:00
samsung_tty.c
tty: serial: samsung_tty: Fix a memory leak in s3c24xx_serial_getclk() when iterating clk
2023-07-27 08:44:30 +02:00
sb1250-duart.c
MIPS: Replace SIBYTE_1956_WAR by CONFIG_SB1_PASS_2_WORKAROUNDS
2020-09-07 22:24:51 +02:00
sc16is7xx.c
serial: sc16is7xx: fix bug when first setting GPIO direction
2023-09-19 12:20:03 +02:00
sccnxp.c
…
serial_core.c
serial: fixup backport of "serial: Deassert Transmit Enable on probe in driver-specific way"
2023-01-14 10:16:51 +01:00
serial_mctrl_gpio.c
…
serial_mctrl_gpio.h
…
serial_txx9.c
serial: txx9: Don't allow CS5-6
2022-06-14 18:32:33 +02:00
serial-tegra.c
serial: tegra: handle clk prepare error in tegra_uart_hw_init()
2023-09-19 12:20:19 +02:00
sh-sci.c
tty: serial: sh-sci: Fix Rx on RZ/G2L SCI
2023-04-20 12:10:23 +02:00
sh-sci.h
serial: sh-sci: Drop unused include
2020-04-16 16:13:34 +02:00
sifive.c
serial: sifive: Fix sifive_serial_console_setup() section
2023-08-11 11:57:39 +02:00
sirfsoc_uart.c
…
sirfsoc_uart.h
…
sprd_serial.c
serial: sprd: Fix DMA buffer leak issue
2023-09-19 12:20:17 +02:00
st-asc.c
serial: st-asc: Sanitize CSIZE and correct PARENB for CS7
2022-06-14 18:32:34 +02:00
stm32-usart.c
serial: stm32: Clear prev values before setting RTS delays
2022-07-21 21:20:19 +02:00
stm32-usart.h
serial: stm32: fix tx_empty condition
2021-05-14 09:50:08 +02:00
suncore.c
…
sunhv.c
Revert "serial: sunhv: Initialize lock for non-registered console"
2020-07-21 18:21:49 +02:00
sunsab.c
serial: sunsab: Fix error handling in sunsab_init()
2023-01-14 10:15:56 +01:00
sunsab.h
…
sunsu.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
sunzilog.c
treewide: Use fallthrough pseudo-keyword
2020-08-23 17:36:59 -05:00
sunzilog.h
…
tegra-tcu.c
serial: tegra-tcu: Use uart_xmit_advance(), fixes icount.tx accounting
2022-09-28 11:10:38 +02:00
timbuart.c
tty: timbuart: convert tasklets to use new tasklet_setup() API
2020-08-18 13:33:13 +02:00
timbuart.h
…
uartlite.c
tty: serial: uartlite: allow 64 bit address
2022-01-27 10:53:53 +01:00
ucc_uart.c
tty: serial: Fix refcount leak bug in ucc_uart.c
2022-08-25 11:38:18 +02:00
vr41xx_siu.c
…
vt8500_serial.c
…
xilinx_uartps.c
tty: xilinx_uartps: Fix the ignore_status
2022-10-26 13:25:32 +02:00
zs.c
…
zs.h
…