James Smart
4e57e0b9f3
lpfc: fix axchg pointer reference after free and double frees ...
The axchg structure is a structure allocated early in the
lpfc_nvme_unsol_ls_handler() to represent the newly received exchange.
Upon error, the out_fail path in the routine unconditionally frees the
pointer, yet subsequently passes the pointer to the abort routine.
Additionally, the abort routine, lpfc_nvme_unsol_ls_issue_abort(), also
has a failure path that will attempt to delete the pointer on error.
Fix these errors by:
- Removing the unconditional free so that it stays valid if passed
to the abort routine.
- Revise the abort routine to not free the pointer. Instead, return
a success/failure status. Note: if success, the later completion of
the abort frees the structure.
- Back in the unsol_ls_handler() error path, if the abort routine was
skipped (thus no possible reference) or the abort routine returned
error, free the pointer.
Fixes: 3a8070c567aa ("lpfc: Refactor NVME LS receive handling")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <jsmart2021@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
2020-05-27 07:12:41 +02:00
2020-04-10 12:21:11 -07:00
2020-04-10 12:21:11 -07:00
2020-01-03 09:42:52 +01:00
2020-04-02 17:03:53 -07:00
2019-10-24 21:22:32 -04:00
2020-03-17 13:36:09 -04:00
2019-09-30 23:59:53 -04:00
2020-03-31 22:35:02 -04:00
2020-01-06 09:45:59 +01:00
2020-01-29 18:16:16 -08:00
2019-12-27 17:28:41 -08:00
2019-12-02 13:37:02 -08:00
2019-11-07 06:43:18 -07:00
2020-03-11 23:07:59 -04:00
2020-02-04 03:05:26 +00:00
2019-09-21 10:50:15 -07:00
2020-03-17 13:36:10 -04:00
2020-04-13 13:28:13 -04:00
2020-03-11 23:07:57 -04:00
2019-12-19 22:08:54 -05:00
2020-04-02 17:03:53 -07:00
2020-04-10 12:21:11 -07:00
2020-03-26 10:28:17 -06:00
2020-05-27 07:12:41 +02:00
2020-04-02 17:03:53 -07:00
2020-03-31 22:02:37 -04:00
2020-03-11 23:07:56 -04:00
2020-03-11 23:08:01 -04:00
2020-03-17 13:57:19 -04:00
2020-03-05 17:36:24 -08:00
2020-03-26 22:38:54 -04:00
2020-04-13 13:58:18 -04:00
2019-12-19 22:08:55 -05:00
2020-03-17 13:36:13 -04:00
2020-03-11 23:07:56 -04:00
2019-12-19 22:08:54 -05:00
2020-04-10 12:21:11 -07:00
2020-03-25 11:50:48 +01:00
2019-02-25 21:37:25 -05:00
2019-03-02 11:39:54 -08:00
2019-10-23 17:23:44 +02:00
2018-10-17 21:58:51 -04:00
2019-05-24 17:36:45 +02:00
2018-08-30 07:27:22 -04:00
2019-01-08 07:58:37 -05:00
2019-05-21 10:50:45 +02:00
2019-10-18 15:01:54 +02:00
2019-05-21 10:50:45 +02:00
2020-02-18 00:39:54 -05:00
2020-03-11 23:07:58 -04:00
2019-05-21 10:50:45 +02:00
2020-03-26 21:10:53 -04:00
2018-06-19 22:02:25 -04:00
2019-05-21 10:50:45 +02:00
2019-11-12 22:21:34 -05:00
2019-11-12 22:21:35 -05:00
2020-04-02 17:03:53 -07:00
2019-06-05 17:37:11 +02:00
2019-05-21 10:50:45 +02:00
2020-02-24 14:54:25 -05:00
2020-04-01 22:03:04 -04:00
2020-03-26 22:51:18 -04:00
2019-05-24 17:36:45 +02:00
2020-03-11 23:07:59 -04:00
2020-03-11 23:07:59 -04:00
2019-12-19 22:08:51 -05:00
2019-12-19 22:08:51 -05:00
2019-07-30 12:18:24 -04:00
2019-06-18 19:46:18 -04:00
2019-07-30 12:17:28 -04:00
2019-06-18 19:46:22 -04:00
2018-09-25 20:45:53 -04:00
2020-03-11 23:08:00 -04:00
2019-01-08 21:58:35 -05:00
2020-03-17 13:36:10 -04:00
2019-01-08 21:57:42 -05:00
2019-05-30 11:25:18 -07:00
2019-01-08 21:58:35 -05:00
2019-05-21 10:50:45 +02:00
2020-02-28 20:54:52 -05:00
2019-07-11 15:14:01 -07:00
2020-03-26 22:44:41 -04:00
2019-06-18 19:46:18 -04:00
2019-06-05 17:36:37 +02:00
2019-06-05 17:36:37 +02:00
2019-07-11 15:17:41 -07:00
2019-12-19 22:08:54 -05:00
2020-04-02 17:03:53 -07:00
2020-04-02 17:03:53 -07:00
2019-09-30 22:46:40 -04:00
2018-11-06 21:31:28 -05:00
2019-06-05 17:36:37 +02:00
2020-01-15 22:48:34 -05:00
2019-05-30 11:26:37 -07:00
2019-05-21 10:50:45 +02:00
2020-04-02 17:03:53 -07:00
2020-01-06 09:45:59 +01:00
2019-07-11 15:14:01 -07:00
2020-03-26 22:48:58 -04:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2019-11-12 22:21:34 -05:00
2019-07-17 22:39:27 +09:00
2020-03-24 07:57:07 -06:00
2018-06-19 22:02:25 -04:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00
2018-12-18 23:13:12 -05:00
2019-07-11 15:17:41 -07:00
2020-03-11 23:07:56 -04:00
2020-01-06 09:45:59 +01:00
2020-01-02 21:57:44 -05:00
2020-01-06 09:45:59 +01:00
2020-01-02 21:57:44 -05:00
2020-03-11 23:08:01 -04:00
2019-05-24 17:36:45 +02:00
2019-11-19 21:37:34 -05:00
2019-06-20 15:37:02 -04:00
2018-06-19 22:02:25 -04:00
2019-10-24 21:22:32 -04:00
2019-05-24 17:39:02 +02:00
2019-10-23 17:23:44 +02:00
2020-03-11 23:07:56 -04:00
2019-06-20 15:21:33 -04:00
2019-05-30 11:26:38 -07:00
2020-01-20 18:35:55 -05:00
2020-01-15 23:09:11 -05:00
2019-03-19 17:11:37 -04:00
2018-12-18 23:19:21 -05:00
2019-08-07 21:32:53 -04:00
2019-02-13 22:07:03 -05:00
2019-06-05 17:37:17 +02:00
2019-05-24 17:36:45 +02:00
2020-03-24 07:57:08 -06:00
2019-07-30 12:42:55 -04:00
2019-05-21 06:16:21 -04:00
2020-02-04 03:05:26 +00:00
2019-05-30 11:26:35 -07:00
2020-02-28 20:54:55 -05:00
2020-01-03 09:33:18 +01:00
2020-04-22 10:47:39 -06:00
2019-09-30 23:07:16 -04:00
2019-12-19 22:08:54 -05:00
2019-05-30 11:26:35 -07:00
2019-09-12 07:11:58 -06:00
2020-02-28 20:54:55 -05:00
2020-02-04 03:05:26 +00:00
2020-02-28 20:54:55 -05:00
2019-05-30 11:29:53 -07:00
2020-03-17 13:36:12 -04:00
2020-03-16 22:08:36 -04:00
2019-07-11 15:14:01 -07:00
2020-03-31 21:39:58 -04:00
2019-11-21 21:12:39 -05:00
2019-05-30 11:26:35 -07:00
2019-06-19 17:09:56 +02:00
2020-02-28 20:54:55 -05:00
2018-06-19 22:02:25 -04:00
2020-03-24 07:57:08 -06:00
2019-06-05 17:37:14 +02:00
2020-02-24 12:50:32 -05:00
2020-03-30 11:20:13 -07:00
2019-12-08 12:23:42 -08:00
2019-07-11 15:14:01 -07:00
2020-04-13 21:58:48 -04:00
2018-12-18 23:19:21 -05:00
2019-05-24 17:36:45 +02:00
2020-01-06 09:45:59 +01:00
2018-08-02 15:22:13 -06:00
2020-02-24 14:59:01 -05:00
2020-05-04 10:13:42 -06:00
2020-02-24 15:01:57 -05:00
2020-03-16 22:08:34 -04:00
2020-03-11 23:07:56 -04:00
2020-01-15 23:02:24 -05:00
2019-11-12 22:21:34 -05:00
2020-01-06 09:45:59 +01:00
2019-05-21 10:50:45 +02:00
2020-02-10 22:46:55 -05:00
2019-12-19 22:42:44 -05:00
2019-08-07 21:35:59 -04:00
2019-05-24 17:39:02 +02:00
2019-07-11 15:14:01 -07:00
2018-11-15 14:27:08 -05:00
2018-12-18 23:13:12 -05:00
2020-01-06 09:45:59 +01:00
2019-05-21 10:50:45 +02:00
2020-02-12 22:56:47 -05:00
4e57e0b9f3