iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net
History
Abhishek Pandit-Subedi 4e8c36c3b0 Bluetooth: Fix suspend notifier race 
Unregister from suspend notifications and cancel suspend preparations
before running hci_dev_do_close. Otherwise, the suspend notifier may
race with unregister and cause cmd_timeout even after hdev has been
freed.

Below is the trace from when this panic was seen:

[  832.578518] Bluetooth: hci_core.c:hci_cmd_timeout() hci0: command 0x0c05 tx timeout
[  832.586200] BUG: kernel NULL pointer dereference, address: 0000000000000000
[  832.586203] #PF: supervisor read access in kernel mode
[  832.586205] #PF: error_code(0x0000) - not-present page
[  832.586206] PGD 0 P4D 0
[  832.586210] PM: suspend exit
[  832.608870] Oops: 0000 [#1] PREEMPT SMP NOPTI
[  832.613232] CPU: 3 PID: 10755 Comm: kworker/3:7 Not tainted 5.4.44-04894-g1e9dbb96a161 #1
[  832.630036] Workqueue: events hci_cmd_timeout [bluetooth]
[  832.630046] RIP: 0010:__queue_work+0xf0/0x374
[  832.630051] RSP: 0018:ffff9b5285f1fdf8 EFLAGS: 00010046
[  832.674033] RAX: ffff8a97681bac00 RBX: 0000000000000000 RCX: ffff8a976a000600
[  832.681162] RDX: 0000000000000000 RSI: 0000000000000009 RDI: ffff8a976a000748
[  832.688289] RBP: ffff9b5285f1fe38 R08: 0000000000000000 R09: ffff8a97681bac00
[  832.695418] R10: 0000000000000002 R11: ffff8a976a0006d8 R12: ffff8a9745107600
[  832.698045] usb 1-6: new full-speed USB device number 119 using xhci_hcd
[  832.702547] R13: ffff8a9673658850 R14: 0000000000000040 R15: 000000000000001e
[  832.702549] FS:  0000000000000000(0000) GS:ffff8a976af80000(0000) knlGS:0000000000000000
[  832.702550] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[  832.702550] CR2: 0000000000000000 CR3: 000000010415a000 CR4: 00000000003406e0
[  832.702551] Call Trace:
[  832.702558]  queue_work_on+0x3f/0x68
[  832.702562]  process_one_work+0x1db/0x396
[  832.747397]  worker_thread+0x216/0x375
[  832.751147]  kthread+0x138/0x140
[  832.754377]  ? pr_cont_work+0x58/0x58
[  832.758037]  ? kthread_blkcg+0x2e/0x2e
[  832.761787]  ret_from_fork+0x22/0x40
[  832.846191] ---[ end trace fa93f466da517212 ]---

Fixes: 9952d90ea2885 ("Bluetooth: Handle PM_SUSPEND_PREPARE and PM_POST_SUSPEND")
Signed-off-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
2020-07-28 20:27:14 +02:00
..
6lowpan
…
9p
9pnet: allow making incomplete read requests
2020-03-27 09:29:56 +00:00
802
net: 802: psnap.c: Use built-in RCU list checking
2020-02-24 13:02:53 -08:00
8021q
netpoll: accept NULL np argument in netpoll_send_skb()
2020-05-07 18:11:07 -07:00
appletalk
ipv4,appletalk: move SIOCADDRT and SIOCDELRT handling into ->compat_ioctl
2020-05-18 17:35:02 -07:00
atm
atm: switch do_atmif_sioc() to direct use of atm_dev_ioctl()
2020-05-20 20:31:36 -04:00
ax25
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-05-24 13:47:27 -07:00
batman-adv
This cleanup patchset includes the following patches:
2020-05-26 15:19:29 -07:00
bluetooth
Bluetooth: Fix suspend notifier race
2020-07-28 20:27:14 +02:00
bpf
bpf: Fix too large copy from user in bpf_test_init
2020-05-19 17:56:34 +02:00
bpfilter
SPDX patches for 5.7-rc1.
2020-04-03 13:12:26 -07:00
bridge
bridge: mrp: Add support for role MRA
2020-06-01 11:56:11 -07:00
caif
net: caif: Fix use correct return type for ndo_start_xmit()
2020-04-30 12:13:07 -07:00
can
can: j1939: j1939_sk_bind(): take priv after lock is held
2019-12-08 11:52:02 +01:00
ceph
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-05-31 17:48:46 -07:00
core
bpf: Add csum_level helper for fixing up csum levels
2020-06-02 11:50:23 -07:00
dcb
…
dccp
ipv6: move SIOCADDRT and SIOCDELRT handling into ->compat_ioctl
2020-05-18 17:35:02 -07:00
decnet
Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next
2020-05-01 17:02:27 -07:00
dns_resolver
docs: networking: convert dns_resolver.txt to ReST
2020-04-28 14:39:46 -07:00
dsa
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-05-31 17:48:46 -07:00
ethernet
net: move devres helpers into a separate source file
2020-05-23 16:56:17 -07:00
ethtool
net: ethtool: cabletest: Make ethnl_act_cable_test_tdr_cfg static
2020-05-29 17:28:30 -07:00
hsr
hsr: remove WARN_ONCE() in hsr_fill_frame_info()
2020-05-07 17:40:02 -07:00
ieee802154
ieee802154: 6lowpan: remove unnecessary comparison
2020-05-08 22:25:10 -07:00
ife
…
ipv4
net: Make locking in sock_bindtoindex optional
2020-06-01 14:57:14 -07:00
ipv6
Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next
2020-06-01 15:53:08 -07:00
iucv
net/af_iucv: clean up function prototypes
2020-05-19 12:50:14 -07:00
kcm
net: kcm: kcmproc.c: Fix RCU list suspicious usage warning
2020-03-16 17:14:02 -07:00
key
…
l2tp
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-05-31 17:48:46 -07:00
l3mdev
…
lapb
docs: networking: convert lapb-module.txt to ReST
2020-04-30 12:56:35 -07:00
llc
af_llc: fix if-statement empty body warning
2020-02-26 20:38:13 -08:00
mac80211
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-05-31 17:48:46 -07:00
mac802154
…
mpls
net: Make mpls_entry_encode() available for generic users
2020-05-29 21:20:20 -07:00
mptcp
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-05-31 17:48:46 -07:00
ncsi
net/ncsi: Support for multi host mellanox card
2020-01-09 18:36:22 -08:00
netfilter
Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf-next
2020-06-01 11:46:30 -07:00
netlabel
netlabel: cope with NULL catmap
2020-05-12 18:12:40 -07:00
netlink
bpf: Enable bpf_iter targets registering ctx argument types
2020-05-13 12:30:50 -07:00
netrom
net: partially revert dynamic lockdep key changes
2020-05-04 12:05:56 -07:00
nfc
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-03-12 22:34:48 -07:00
nsh
…
openvswitch
net: openvswitch: use div_u64() for 64-by-32 divisions
2020-04-25 20:48:21 -07:00
packet
net/packet: tpacket_rcv: avoid a producer race condition
2020-03-15 00:25:25 -07:00
phonet
sysctl: pass kernel pointers to ->proc_handler
2020-04-27 02:07:40 -04:00
psample
net: psample: fix build error when CONFIG_INET is not enabled
2020-05-23 16:36:05 -07:00
qrtr
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-05-31 17:48:46 -07:00
rds
tcp: add tcp_sock_set_keepcnt
2020-05-28 11:11:45 -07:00
rfkill
rfkill: Fix incorrect check to avoid NULL pointer dereference
2019-12-16 10:15:49 +01:00
rose
net: partially revert dynamic lockdep key changes
2020-05-04 12:05:56 -07:00
rxrpc
rxrpc: add rxrpc_sock_set_min_security_level
2020-05-28 11:11:46 -07:00
sched
cls_flower: remove mpls_opts_policy
2020-06-01 12:01:05 -07:00
sctp
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-05-31 17:48:46 -07:00
smc
net/smc: pre-fetch send buffer outside of send_lock
2020-05-30 18:12:25 -07:00
strparser
…
sunrpc
ipv6: add ip6_sock_set_recvpktinfo
2020-05-28 11:11:46 -07:00
switchdev
net: switchdev: do not propagate bridge updates across bridges
2020-02-26 20:58:33 -08:00
tipc
Revert "tipc: Fix potential tipc_aead refcnt leak in tipc_crypto_rcv"
2020-06-02 15:13:47 -07:00
tls
bpf: Fix running sk_skb program types with ktls
2020-06-01 14:48:32 -07:00
unix
net: datagram: drop 'destructor' argument from several helpers
2020-02-28 12:12:53 -08:00
vmw_vsock
virtio_vsock: Fix race condition in virtio_transport_recv_pkt
2020-05-30 17:44:01 -07:00
wimax
…
wireless
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-05-31 17:48:46 -07:00
x25
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-05-06 22:10:13 -07:00
xdp
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-05-31 17:48:46 -07:00
xfrm
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2020-05-31 17:48:46 -07:00
compat.c
switch cmsghdr_from_user_compat_to_kern() to copy_from_user()
2020-06-01 12:05:45 -07:00
devres.c
net: devres: provide devm_register_netdev()
2020-05-23 16:56:17 -07:00
Kconfig
net: ethtool: netlink: Add support for triggering a cable test
2020-05-10 12:28:41 -07:00
Makefile
net: move devres helpers into a separate source file
2020-05-23 16:56:17 -07:00
socket.c
net: remove kernel_setsockopt
2020-05-29 13:10:39 -07:00
sysctl_net.c
…