Fugang Duan
4ec236c7c5
net: stmmac: free tx skb buffer in stmmac_resume() ...
When do suspend/resume test, there have WARN_ON() log dump from
stmmac_xmit() funciton, the code logic:
entry = tx_q->cur_tx;
first_entry = entry;
WARN_ON(tx_q->tx_skbuff[first_entry]);
In normal case, tx_q->tx_skbuff[txq->cur_tx] should be NULL because
the skb should be handled and freed in stmmac_tx_clean().
But stmmac_resume() reset queue parameters like below, skb buffers
may not be freed.
tx_q->cur_tx = 0;
tx_q->dirty_tx = 0;
So free tx skb buffer in stmmac_resume() to avoid warning and
memory leak.
log:
[ 46.139824] ------------[ cut here ]------------
[ 46.144453] WARNING: CPU: 0 PID: 0 at drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:3235 stmmac_xmit+0x7a0/0x9d0
[ 46.154969] Modules linked in: crct10dif_ce vvcam(O) flexcan can_dev
[ 46.161328] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G O 5.4.24-2.1.0+g2ad925d15481 #1
[ 46.170369] Hardware name: NXP i.MX8MPlus EVK board (DT)
[ 46.175677] pstate: 80000005 (Nzcv daif -PAN -UAO)
[ 46.180465] pc : stmmac_xmit+0x7a0/0x9d0
[ 46.184387] lr : dev_hard_start_xmit+0x94/0x158
[ 46.188913] sp : ffff800010003cc0
[ 46.192224] x29: ffff800010003cc0 x28: ffff000177e2a100
[ 46.197533] x27: ffff000176ef0840 x26: ffff000176ef0090
[ 46.202842] x25: 0000000000000000 x24: 0000000000000000
[ 46.208151] x23: 0000000000000003 x22: ffff8000119ddd30
[ 46.213460] x21: ffff00017636f000 x20: ffff000176ef0cc0
[ 46.218769] x19: 0000000000000003 x18: 0000000000000000
[ 46.224078] x17: 0000000000000000 x16: 0000000000000000
[ 46.229386] x15: 0000000000000079 x14: 0000000000000000
[ 46.234695] x13: 0000000000000003 x12: 0000000000000003
[ 46.240003] x11: 0000000000000010 x10: 0000000000000010
[ 46.245312] x9 : ffff00017002b140 x8 : 0000000000000000
[ 46.250621] x7 : ffff00017636f000 x6 : 0000000000000010
[ 46.255930] x5 : 0000000000000001 x4 : ffff000176ef0000
[ 46.261238] x3 : 0000000000000003 x2 : 00000000ffffffff
[ 46.266547] x1 : ffff000177e2a000 x0 : 0000000000000000
[ 46.271856] Call trace:
[ 46.274302] stmmac_xmit+0x7a0/0x9d0
[ 46.277874] dev_hard_start_xmit+0x94/0x158
[ 46.282056] sch_direct_xmit+0x11c/0x338
[ 46.285976] __qdisc_run+0x118/0x5f0
[ 46.289549] net_tx_action+0x110/0x198
[ 46.293297] __do_softirq+0x120/0x23c
[ 46.296958] irq_exit+0xb8/0xd8
[ 46.300098] __handle_domain_irq+0x64/0xb8
[ 46.304191] gic_handle_irq+0x5c/0x148
[ 46.307936] el1_irq+0xb8/0x180
[ 46.311076] cpuidle_enter_state+0x84/0x360
[ 46.315256] cpuidle_enter+0x34/0x48
[ 46.318829] call_cpuidle+0x18/0x38
[ 46.322314] do_idle+0x1e0/0x280
[ 46.325539] cpu_startup_entry+0x24/0x40
[ 46.329460] rest_init+0xd4/0xe0
[ 46.332687] arch_call_rest_init+0xc/0x14
[ 46.336695] start_kernel+0x420/0x44c
[ 46.340353] ---[ end trace bc1ee695123cbacd ]---
Fixes: 47dd7a540b8a0 ("net: add support for STMicroelectronics Ethernet controllers.")
Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2020-12-08 14:52:29 -08:00
2020-10-15 18:42:13 -07:00
2020-10-01 19:08:46 -07:00
2020-08-24 17:33:11 -07:00
2020-12-04 14:42:21 -08:00
2020-08-23 17:36:59 -05:00
2020-09-23 17:33:52 -07:00
2020-09-14 13:02:37 -07:00
2020-11-24 16:07:13 -08:00
2020-10-15 18:42:13 -07:00
2020-08-27 06:55:50 -07:00
2020-11-24 10:59:17 -08:00
2020-09-25 16:29:00 -07:00
2020-11-18 11:02:15 -08:00
2020-12-01 11:44:02 -08:00
2020-10-03 17:33:23 -07:00
2020-12-04 14:42:21 -08:00
2020-09-25 16:29:00 -07:00
2020-10-10 10:34:03 -07:00
2020-12-05 12:56:21 -08:00
2020-08-18 12:54:47 -07:00
2020-10-20 10:28:21 -07:00
2020-09-25 16:29:00 -07:00
2020-08-23 17:36:59 -05:00
2020-09-25 16:29:00 -07:00
2020-09-14 13:02:37 -07:00
2020-08-23 17:36:59 -05:00
2020-12-04 14:42:21 -08:00
2020-12-07 17:57:19 -08:00
2020-10-30 16:57:41 -05:00
2020-12-06 23:38:33 -08:00
2020-10-05 18:40:01 -07:00
2020-09-25 06:20:45 +02:00
2020-12-01 10:09:04 -08:00
2020-11-23 16:52:59 -08:00
2020-12-05 14:04:55 -08:00
2020-11-12 17:58:37 -08:00
2020-12-04 14:42:21 -08:00
2020-10-03 17:33:23 -07:00
2020-12-04 14:42:21 -08:00
2020-12-05 15:41:34 -08:00
2020-09-10 13:08:46 -07:00
2020-09-29 14:02:54 -07:00
2020-09-29 14:02:54 -07:00
2020-12-04 14:42:21 -08:00
2020-09-14 13:02:38 -07:00
2020-12-04 14:42:21 -08:00
2020-09-25 16:29:00 -07:00
2020-09-25 16:29:00 -07:00
2020-12-02 18:03:58 -08:00
2020-11-05 09:58:25 -08:00
2020-11-17 16:35:32 -08:00
2020-11-16 16:34:49 -08:00
2020-07-20 17:49:50 -07:00
2020-11-07 12:14:35 -08:00
2020-10-27 17:14:33 -07:00
2020-12-04 14:42:21 -08:00
2020-09-25 16:29:00 -07:00
2020-09-25 06:20:45 +02:00
2020-10-20 21:22:23 -07:00
2020-08-03 16:00:26 -07:00
2020-09-14 13:02:38 -07:00
2020-09-25 16:29:00 -07:00
2020-09-14 13:02:38 -07:00
2020-10-20 15:59:43 -07:00
2020-12-08 14:52:29 -08:00
2020-10-15 18:42:13 -07:00
2020-09-25 16:29:00 -07:00
2020-09-25 16:29:00 -07:00
2020-11-16 15:37:28 -08:00
2020-09-08 20:16:19 -07:00
2020-10-05 18:40:01 -07:00
2020-09-25 16:29:00 -07:00
2020-08-23 17:36:59 -05:00
2020-09-25 16:29:00 -07:00
2020-09-25 16:29:00 -07:00
2020-07-20 18:32:49 -07:00
2020-09-14 13:02:37 -07:00
2020-10-19 17:00:00 -07:00
2020-09-23 18:01:03 -07:00
4ec236c7c5