Following the introduction of the generic ECC engine infrastructure, it was necessary to reorganize the code and move the ECC configuration in the ->attach_chip() hook. Failing to do that properly lead to a first series of fixes supposed to stabilize the situation. Unfortunately, this only fixed the use of software ECC engines, preventing any other kind of engine to be used, including on-die ones. It is now time to (finally) fix the situation by ensuring that we still provide a default (eg. software ECC) but will still support different ECC engines such as on-die ECC engines if properly described in the device tree. There are no changes needed on the core side in order to do this, but we just need to leverage the logic there which allows: 1- a subsystem default (set to Host engines in the raw NAND world) 2- a driver specific default (here set to software ECC engines) 3- any type of engine requested by the user (ie. described in the DT) As the raw NAND subsystem has not yet been fully converted to the ECC engine infrastructure, in order to provide a default ECC engine for this driver we need to set chip->ecc.engine_type *before* calling nand_scan(). During the initialization step, the core will consider this entry as the default engine for this driver. This value may of course be overloaded by the user if the usual DT properties are provided. Fixes: 8fc6f1f042b2 ("mtd: rawnand: pasemi: Move the ECC initialization to ->attach_chip()") Cc: stable@vger.kernel.org Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Link: https://lore.kernel.org/linux-mtd/20210928222258.199726-7-miquel.raynal@bootlin.com
243 lines
5.2 KiB
C
243 lines
5.2 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (C) 2006-2007 PA Semi, Inc
|
|
*
|
|
* Author: Egor Martovetsky <egor@pasemi.com>
|
|
* Maintained by: Olof Johansson <olof@lixom.net>
|
|
*
|
|
* Driver for the PWRficient onchip NAND flash interface
|
|
*/
|
|
|
|
#undef DEBUG
|
|
|
|
#include <linux/slab.h>
|
|
#include <linux/module.h>
|
|
#include <linux/mtd/mtd.h>
|
|
#include <linux/mtd/rawnand.h>
|
|
#include <linux/of_address.h>
|
|
#include <linux/of_irq.h>
|
|
#include <linux/of_platform.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/pci.h>
|
|
|
|
#include <asm/io.h>
|
|
|
|
#define LBICTRL_LPCCTL_NR 0x00004000
|
|
#define CLE_PIN_CTL 15
|
|
#define ALE_PIN_CTL 14
|
|
|
|
static unsigned int lpcctl;
|
|
static struct mtd_info *pasemi_nand_mtd;
|
|
static struct nand_controller controller;
|
|
static const char driver_name[] = "pasemi-nand";
|
|
|
|
static void pasemi_read_buf(struct nand_chip *chip, u_char *buf, int len)
|
|
{
|
|
while (len > 0x800) {
|
|
memcpy_fromio(buf, chip->legacy.IO_ADDR_R, 0x800);
|
|
buf += 0x800;
|
|
len -= 0x800;
|
|
}
|
|
memcpy_fromio(buf, chip->legacy.IO_ADDR_R, len);
|
|
}
|
|
|
|
static void pasemi_write_buf(struct nand_chip *chip, const u_char *buf,
|
|
int len)
|
|
{
|
|
while (len > 0x800) {
|
|
memcpy_toio(chip->legacy.IO_ADDR_R, buf, 0x800);
|
|
buf += 0x800;
|
|
len -= 0x800;
|
|
}
|
|
memcpy_toio(chip->legacy.IO_ADDR_R, buf, len);
|
|
}
|
|
|
|
static void pasemi_hwcontrol(struct nand_chip *chip, int cmd,
|
|
unsigned int ctrl)
|
|
{
|
|
if (cmd == NAND_CMD_NONE)
|
|
return;
|
|
|
|
if (ctrl & NAND_CLE)
|
|
out_8(chip->legacy.IO_ADDR_W + (1 << CLE_PIN_CTL), cmd);
|
|
else
|
|
out_8(chip->legacy.IO_ADDR_W + (1 << ALE_PIN_CTL), cmd);
|
|
|
|
/* Push out posted writes */
|
|
eieio();
|
|
inl(lpcctl);
|
|
}
|
|
|
|
static int pasemi_device_ready(struct nand_chip *chip)
|
|
{
|
|
return !!(inl(lpcctl) & LBICTRL_LPCCTL_NR);
|
|
}
|
|
|
|
static int pasemi_attach_chip(struct nand_chip *chip)
|
|
{
|
|
if (chip->ecc.engine_type == NAND_ECC_ENGINE_TYPE_SOFT &&
|
|
chip->ecc.algo == NAND_ECC_ALGO_UNKNOWN)
|
|
chip->ecc.algo = NAND_ECC_ALGO_HAMMING;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct nand_controller_ops pasemi_ops = {
|
|
.attach_chip = pasemi_attach_chip,
|
|
};
|
|
|
|
static int pasemi_nand_probe(struct platform_device *ofdev)
|
|
{
|
|
struct device *dev = &ofdev->dev;
|
|
struct pci_dev *pdev;
|
|
struct device_node *np = dev->of_node;
|
|
struct resource res;
|
|
struct nand_chip *chip;
|
|
int err = 0;
|
|
|
|
err = of_address_to_resource(np, 0, &res);
|
|
|
|
if (err)
|
|
return -EINVAL;
|
|
|
|
/* We only support one device at the moment */
|
|
if (pasemi_nand_mtd)
|
|
return -ENODEV;
|
|
|
|
dev_dbg(dev, "pasemi_nand at %pR\n", &res);
|
|
|
|
/* Allocate memory for MTD device structure and private data */
|
|
chip = kzalloc(sizeof(struct nand_chip), GFP_KERNEL);
|
|
if (!chip) {
|
|
err = -ENOMEM;
|
|
goto out;
|
|
}
|
|
|
|
controller.ops = &pasemi_ops;
|
|
nand_controller_init(&controller);
|
|
chip->controller = &controller;
|
|
|
|
pasemi_nand_mtd = nand_to_mtd(chip);
|
|
|
|
/* Link the private data with the MTD structure */
|
|
pasemi_nand_mtd->dev.parent = dev;
|
|
|
|
chip->legacy.IO_ADDR_R = of_iomap(np, 0);
|
|
chip->legacy.IO_ADDR_W = chip->legacy.IO_ADDR_R;
|
|
|
|
if (!chip->legacy.IO_ADDR_R) {
|
|
err = -EIO;
|
|
goto out_mtd;
|
|
}
|
|
|
|
pdev = pci_get_device(PCI_VENDOR_ID_PASEMI, 0xa008, NULL);
|
|
if (!pdev) {
|
|
err = -ENODEV;
|
|
goto out_ior;
|
|
}
|
|
|
|
lpcctl = pci_resource_start(pdev, 0);
|
|
pci_dev_put(pdev);
|
|
|
|
if (!request_region(lpcctl, 4, driver_name)) {
|
|
err = -EBUSY;
|
|
goto out_ior;
|
|
}
|
|
|
|
chip->legacy.cmd_ctrl = pasemi_hwcontrol;
|
|
chip->legacy.dev_ready = pasemi_device_ready;
|
|
chip->legacy.read_buf = pasemi_read_buf;
|
|
chip->legacy.write_buf = pasemi_write_buf;
|
|
chip->legacy.chip_delay = 0;
|
|
|
|
/* Enable the following for a flash based bad block table */
|
|
chip->bbt_options = NAND_BBT_USE_FLASH;
|
|
|
|
/*
|
|
* This driver assumes that the default ECC engine should be TYPE_SOFT.
|
|
* Set ->engine_type before registering the NAND devices in order to
|
|
* provide a driver specific default value.
|
|
*/
|
|
chip->ecc.engine_type = NAND_ECC_ENGINE_TYPE_SOFT;
|
|
|
|
/* Scan to find existence of the device */
|
|
err = nand_scan(chip, 1);
|
|
if (err)
|
|
goto out_lpc;
|
|
|
|
if (mtd_device_register(pasemi_nand_mtd, NULL, 0)) {
|
|
dev_err(dev, "Unable to register MTD device\n");
|
|
err = -ENODEV;
|
|
goto out_cleanup_nand;
|
|
}
|
|
|
|
dev_info(dev, "PA Semi NAND flash at %pR, control at I/O %x\n", &res,
|
|
lpcctl);
|
|
|
|
return 0;
|
|
|
|
out_cleanup_nand:
|
|
nand_cleanup(chip);
|
|
out_lpc:
|
|
release_region(lpcctl, 4);
|
|
out_ior:
|
|
iounmap(chip->legacy.IO_ADDR_R);
|
|
out_mtd:
|
|
kfree(chip);
|
|
out:
|
|
return err;
|
|
}
|
|
|
|
static int pasemi_nand_remove(struct platform_device *ofdev)
|
|
{
|
|
struct nand_chip *chip;
|
|
int ret;
|
|
|
|
if (!pasemi_nand_mtd)
|
|
return 0;
|
|
|
|
chip = mtd_to_nand(pasemi_nand_mtd);
|
|
|
|
/* Release resources, unregister device */
|
|
ret = mtd_device_unregister(pasemi_nand_mtd);
|
|
WARN_ON(ret);
|
|
nand_cleanup(chip);
|
|
|
|
release_region(lpcctl, 4);
|
|
|
|
iounmap(chip->legacy.IO_ADDR_R);
|
|
|
|
/* Free the MTD device structure */
|
|
kfree(chip);
|
|
|
|
pasemi_nand_mtd = NULL;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const struct of_device_id pasemi_nand_match[] =
|
|
{
|
|
{
|
|
.compatible = "pasemi,localbus-nand",
|
|
},
|
|
{},
|
|
};
|
|
|
|
MODULE_DEVICE_TABLE(of, pasemi_nand_match);
|
|
|
|
static struct platform_driver pasemi_nand_driver =
|
|
{
|
|
.driver = {
|
|
.name = driver_name,
|
|
.of_match_table = pasemi_nand_match,
|
|
},
|
|
.probe = pasemi_nand_probe,
|
|
.remove = pasemi_nand_remove,
|
|
};
|
|
|
|
module_platform_driver(pasemi_nand_driver);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_AUTHOR("Egor Martovetsky <egor@pasemi.com>");
|
|
MODULE_DESCRIPTION("NAND flash interface driver for PA Semi PWRficient");
|