Julia Lawall f25c80a4b2 arch/um/drivers: remove duplicate structure field initialization
There are two initializations of ndo_set_mac_address, one to a local
function that is not used otherwise and one to a function that is defined
elsewhere.

The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
identifier I, s, fld;
position p0,p;
expression E;
@@

struct I s =@p0 { ... .fld@p = E, ...};

@s@
identifier I, s, r.fld;
position r.p0,p;
expression E;
@@

struct I s =@p0 { ... .fld@p = E, ...};

@script:python@
p0 << r.p0;
fld << r.fld;
ps << s.p;
pr << r.p;
@@

if int(ps[0].line)<int(pr[0].line) or int(ps[0].column)<int(pr[0].column):
  cocci.print_main(fld,p0)
// </smpl>

akpm:

- Use the standard eth_mac_addr() in uml_net_set_mac()

- Remove unneeded and racy local set_ether_mac()

- Remove duplicated (and incorrect)
  uml_netdev_ops.ndo_set_mac_address initializer.

Fixes 8bb95b39a16ed55226810596f92216c53329d2fe ("uml: convert network
device to netdevice ops").

[akpm@linux-foundation.org: rework as above]
Signed-off-by: Julia Lawall <julia@diku.dk>
Cc: Stephen Hemminger <shemminger@vyatta.com>
Cc: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
2010-07-21 11:16:09 -07:00
..
2008-04-28 08:58:28 -07:00
2008-05-13 08:02:22 -07:00
2007-10-16 09:43:09 -07:00
2007-10-16 09:43:08 -07:00
2008-05-13 08:02:22 -07:00
2007-10-16 09:43:08 -07:00
2010-05-17 05:27:03 +02:00
2008-05-13 08:02:22 -07:00
2007-10-20 01:23:03 +02:00
2008-05-21 16:55:57 -07:00
2009-04-01 08:59:17 -07:00
2009-04-01 08:59:17 -07:00
2008-05-13 08:02:22 -07:00
2009-10-14 15:35:51 +02:00
2009-06-25 11:22:13 -07:00
2006-09-27 08:26:15 -07:00
2009-06-25 11:22:13 -07:00
2008-02-05 09:44:30 -08:00
2006-09-27 08:26:15 -07:00
2008-02-05 09:44:26 -08:00
2009-04-01 08:59:17 -07:00
2007-10-20 01:23:03 +02:00
2009-04-01 08:59:17 -07:00
2008-05-13 08:02:22 -07:00
2008-02-05 09:44:26 -08:00
2007-10-16 09:43:05 -07:00
2007-07-16 09:05:38 -07:00
2008-05-13 08:02:22 -07:00
2009-04-01 08:59:17 -07:00