5030c80790
which caused gcc 4.6 to warn about variable 'XYZ' set but not used. sbp2.c, unit_characteristics: The underlying problem which was spotted here --- an incomplete implementation --- is already 50% fixed in drivers/firewire/sbp2.c which observes mgt_ORB_timeout but not yet ORB_size. raw1394.c, length_conflict; dv1394.c, ts_off: Impossible to tell why these variables are there. We can safely remove them though because we don't need a compiler warning to realize that we are dealing with (at least stylistically) flawed code here. dv1394.c, packet_time: This was used in debug macro that is only compiled in with DV1394_DEBUG_LEVEL >= 2 defined at compile-time. Just drop it since nobody debugs dv1394 anymore. Avoids noise in regular kernel builds. dv1394.c, ohci; eth1394.c, priv: These variables clearly can go away. Somebody wanted to use them but then didn't (or not anymore). Note, all of this code is considered to be at its end of life and is thus not really meant to receive janitorial updates anymore. But if we can easily remove noisy warnings from kernel builds, we should. Reported-by: Justin P. Mattock <justinmattock@gmail.com> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de> |
||
---|---|---|
.. | ||
config_roms.c | ||
config_roms.h | ||
csr1212.c | ||
csr1212.h | ||
csr.c | ||
csr.h | ||
dma.c | ||
dma.h | ||
dv1394-private.h | ||
dv1394.c | ||
dv1394.h | ||
eth1394.c | ||
eth1394.h | ||
highlevel.c | ||
highlevel.h | ||
hosts.c | ||
hosts.h | ||
ieee1394_core.c | ||
ieee1394_core.h | ||
ieee1394_hotplug.h | ||
ieee1394_transactions.c | ||
ieee1394_transactions.h | ||
ieee1394_types.h | ||
ieee1394-ioctl.h | ||
ieee1394.h | ||
init_ohci1394_dma.c | ||
iso.c | ||
iso.h | ||
Kconfig | ||
Makefile | ||
nodemgr.c | ||
nodemgr.h | ||
ohci1394.c | ||
ohci1394.h | ||
pcilynx.c | ||
pcilynx.h | ||
raw1394-private.h | ||
raw1394.c | ||
raw1394.h | ||
sbp2.c | ||
sbp2.h | ||
video1394.c | ||
video1394.h |