linux

iv/linux

History

Masahiro Yamada 5066743e4c modpost: change mod->gpl_compatible to bool type

Currently, mod->gpl_compatible is tristate; it is set to -1 by default,
then to 1 or 0 when MODULE_LICENSE() is found.

Maybe, -1 was chosen to represent the 'unknown' license, but it is not
useful.

The current code:

    if (!mod->gpl_compatible)
            check_for_gpl_usage(exp->export, basename, exp->name);

... only cares whether gpl_compatible is zero or not.

Change it to a bool type with the initial value 'true', which has no
functional change.

The default value should be 'true' instead of 'false'.

Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() into
error"), unknown module license is an error.

The error message, "missing MODULE_LICENSE()" is enough to explain the
issue. It is not sensible to show another message, "GPL-incompatible
module ... uses GPL-only symbol".

Add comments to explain this.

While I was here, I renamed gpl_compatible to is_gpl_compatible for
clarification, and also slightly refactored the code.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

2022-05-08 03:17:00 +09:00

.gitignore

.gitignore: prefix local generated files with a slash

2021-05-02 00:43:35 +09:00

devicetable-offsets.c

HID: intel-ish-hid: add support for MODULE_DEVICE_TABLE()

2021-11-09 11:41:46 +01:00

empty.c

Linux-2.6.12-rc2

2005-04-16 15:20:36 -07:00

file2alias.c

HID: intel-ish-hid: add support for MODULE_DEVICE_TABLE()