Dmitry Torokhov 510cccb5b0 tty/vt/keyboard: fix OOB access in do_compute_shiftstate()
The size of individual keymap in drivers/tty/vt/keyboard.c is NR_KEYS,
which is currently 256, whereas number of keys/buttons in input device (and
therefor in key_down) is much larger - KEY_CNT - 768, and that can cause
out-of-bound access when we do

	sym = U(key_maps[0][k]);

with large 'k'.

To fix it we should not attempt iterating beyond smaller of NR_KEYS and
KEY_CNT.

Also while at it let's switch to for_each_set_bit() instead of open-coding
it.

Reported-by: Sasha Levin <sasha.levin@oracle.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Cc: stable@vger.kernel.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
2016-07-20 17:50:23 -07:00
..
2016-03-22 12:55:17 -07:00
2016-01-28 14:13:44 -08:00
2016-01-28 14:13:44 -08:00
2016-01-28 14:13:44 -08:00
2016-01-28 14:13:44 -08:00
2016-01-28 14:19:12 -08:00
2016-01-28 14:13:44 -08:00
2016-01-28 14:13:44 -08:00
2016-03-07 16:11:14 -08:00
2016-01-28 14:13:44 -08:00
2016-02-14 14:36:04 -08:00
2016-01-28 14:19:12 -08:00