iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs/ext4
History
Ye Bin 51ae846cff ext4: fix warning in ext4_iomap_begin as race between bmap and write 
We got issue as follows:
------------[ cut here ]------------
WARNING: CPU: 3 PID: 9310 at fs/ext4/inode.c:3441 ext4_iomap_begin+0x182/0x5d0
RIP: 0010:ext4_iomap_begin+0x182/0x5d0
RSP: 0018:ffff88812460fa08 EFLAGS: 00010293
RAX: ffff88811f168000 RBX: 0000000000000000 RCX: ffffffff97793c12
RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000003
RBP: ffff88812c669160 R08: ffff88811f168000 R09: ffffed10258cd20f
R10: ffff88812c669077 R11: ffffed10258cd20e R12: 0000000000000001
R13: 00000000000000a4 R14: 000000000000000c R15: ffff88812c6691ee
FS:  00007fd0d6ff3740(0000) GS:ffff8883af180000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007fd0d6dda290 CR3: 0000000104a62000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
 iomap_apply+0x119/0x570
 iomap_bmap+0x124/0x150
 ext4_bmap+0x14f/0x250
 bmap+0x55/0x80
 do_vfs_ioctl+0x952/0xbd0
 __x64_sys_ioctl+0xc6/0x170
 do_syscall_64+0x33/0x40
 entry_SYSCALL_64_after_hwframe+0x44/0xa9

Above issue may happen as follows:
          bmap                    write
bmap
  ext4_bmap
    iomap_bmap
      ext4_iomap_begin
                            ext4_file_write_iter
			      ext4_buffered_write_iter
			        generic_perform_write
				  ext4_da_write_begin
				    ext4_da_write_inline_data_begin
				      ext4_prepare_inline_data
				        ext4_create_inline_data
					  ext4_set_inode_flag(inode,
						EXT4_INODE_INLINE_DATA);
      if (WARN_ON_ONCE(ext4_has_inline_data(inode))) ->trigger bug_on

To solved above issue hold inode lock in ext4_bamp.

Signed-off-by: Ye Bin <yebin10@huawei.com>
Link: https://lore.kernel.org/r/20220617013935.397596-1-yebin10@huawei.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
2022-08-02 23:56:02 -04:00
..
.kunitconfig
ext4: add .kunitconfig fragment to enable ext4-specific tests
2021-02-11 23:16:30 -05:00
acl.c
fs/ext4: fix comments mentioning i_mutex
2022-02-03 10:57:53 -05:00
acl.h
vfs: add rcu argument to ->get_acl() callback
2021-08-18 22:08:24 +02:00
balloc.c
ext4: use ext4_debug() instead of jbd_debug()
2022-08-02 23:52:19 -04:00
bitmap.c
…
block_validity.c
ext4: add ext4_sb_block_valid() refactored out of ext4_inode_block_valid()
2022-02-25 21:34:56 -05:00
crypto.c
ext4: refactor and move ext4_ioctl_get_encryption_pwsalt()
2022-05-21 22:24:24 -04:00
dir.c
ext4: fix spelling errors in comments
2022-05-11 15:19:06 -04:00
ext4_extents.h
ext4: fix sparse warnings
2021-08-30 23:36:50 -04:00
ext4_jbd2.c
ext4: use ext4_debug() instead of jbd_debug()
2022-08-02 23:52:19 -04:00
ext4_jbd2.h
fs/ext4: fix comments mentioning i_mutex
2022-02-03 10:57:53 -05:00
ext4.h
ext4: update the s_overhead_clusters in the backup sb's when resizing
2022-08-02 23:52:19 -04:00
extents_status.c
ext4: correct the cache_nr in tracepoint ext4_es_shrink_exit
2021-06-22 21:34:17 -04:00
extents_status.h
ext4: fix extent_status trace points
2020-01-25 02:03:03 -05:00
extents.c
ext4: fix bug_on in __es_tree_search
2022-05-24 15:34:17 -04:00
fast_commit.c
ext4: use ext4_debug() instead of jbd_debug()
2022-08-02 23:52:19 -04:00
fast_commit.h
flexible-array transformations for 5.18-rc1
2022-03-24 11:39:32 -07:00
file.c
iomap: add per-iomap_iter private data
2022-05-16 17:17:32 +02:00
fsmap.c
treewide: Change list_sort to use const pointers
2021-04-08 16:04:22 -07:00
fsmap.h
ext4: fsmap: fix the block/inode bitmap comment
2021-06-24 09:48:29 -04:00
fsync.c
block: use an on-stack bio in blkdev_issue_flush
2021-01-27 09:51:48 -07:00
hash.c
unicode: clean up the Kconfig symbol confusion
2022-01-20 19:57:24 -05:00
ialloc.c
ext4: Support for checksumming from journal triggers
2021-08-30 23:36:50 -04:00
indirect.c
ext4: use ext4_debug() instead of jbd_debug()
2022-08-02 23:52:19 -04:00
inline.c
ext4: correct max_inline_xattr_value_size computing
2022-08-02 23:52:44 -04:00
inode-test.c
fs: ext4: Modify inode-test.c to use KUnit parameterized testing feature
2020-12-02 16:07:25 -07:00
inode.c
ext4: fix warning in ext4_iomap_begin as race between bmap and write
2022-08-02 23:56:02 -04:00
ioctl.c
ext4: update the s_overhead_clusters in the backup sb's when resizing
2022-08-02 23:52:19 -04:00
Kconfig
ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it
2021-02-11 23:12:59 -05:00
Makefile
ext4: move ext4 crypto code to its own file crypto.c
2022-05-21 22:24:24 -04:00
mballoc.c
ext4: reuse order and buddy in mb_mark_used when buddy split
2022-08-02 23:52:19 -04:00
mballoc.h
ext4: fix various seppling typos
2021-04-09 23:14:59 -04:00
migrate.c
ext4: fix a doubled word "need" in a comment
2022-06-18 19:36:20 -04:00
mmp.c
ext4: remove unnecessary type castings
2022-05-11 15:19:06 -04:00
move_extent.c
ext4: Convert ext4 to read_folio
2022-05-09 16:21:45 -04:00
namei.c
ext4: make variable "count" signed
2022-06-18 19:35:57 -04:00
orphan.c
ext4: use ext4_debug() instead of jbd_debug()
2022-08-02 23:52:19 -04:00
page-io.c
ext4: fix incorrect comment in ext4_bio_write_page()
2022-06-16 11:03:16 -04:00
readpage.c
fs: Convert block_read_full_page() to block_read_full_folio()
2022-05-09 16:21:44 -04:00
resize.c
ext4: update the s_overhead_clusters in the backup sb's when resizing
2022-08-02 23:52:19 -04:00
super.c
ext4: use ext4_debug() instead of jbd_debug()
2022-08-02 23:52:19 -04:00
symlink.c
ext4: fix reading leftover inlined symlinks
2022-08-02 23:37:50 -04:00
sysfs.c
unicode: clean up the Kconfig symbol confusion
2022-01-20 19:57:24 -05:00
truncate.h
ext4: Convert to use mapping->invalidate_lock
2021-07-13 14:29:00 +02:00
verity.c
ext4: Call aops write_begin() and write_end() directly
2022-05-08 14:45:56 -04:00
xattr_hurd.c
acl: handle idmapped mounts
2021-01-24 14:27:17 +01:00
xattr_security.c
acl: handle idmapped mounts
2021-01-24 14:27:17 +01:00
xattr_trusted.c
acl: handle idmapped mounts
2021-01-24 14:27:17 +01:00
xattr_user.c
acl: handle idmapped mounts
2021-01-24 14:27:17 +01:00
xattr.c
ext4: fix use-after-free in ext4_xattr_set_entry
2022-08-02 23:52:34 -04:00
xattr.h
ext4: add EXT4_INODE_HAS_XATTR_SPACE macro in xattr.h
2022-08-02 23:52:34 -04:00