John Fastabend 1e203c1a2c net: sched: suspicious RCU usage in qdisc_watchdog ...

Suspicious RCU usage in qdisc_watchdog call needs to be done inside
rcu_read_lock/rcu_read_unlock. And then Qdisc destroy operations
need to ensure timer is cancelled before removing qdisc structure.

[ 3992.191339] ===============================
[ 3992.191340] [ INFO: suspicious RCU usage. ]
[ 3992.191343] 3.17.0-rc6net-next+ #72 Not tainted
[ 3992.191345] -------------------------------
[ 3992.191347] include/net/sch_generic.h:272 suspicious rcu_dereference_check() usage!
[ 3992.191348]
[ 3992.191348] other info that might help us debug this:
[ 3992.191348]
[ 3992.191351]
[ 3992.191351] rcu_scheduler_active = 1, debug_locks = 1
[ 3992.191353] no locks held by swapper/1/0.
[ 3992.191355]
[ 3992.191355] stack backtrace:
[ 3992.191358] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 3.17.0-rc6net-next+ #72
[ 3992.191360] Hardware name:                  /DZ77RE-75K, BIOS GAZ7711H.86A.0060.2012.1115.1750 11/15/2012
[ 3992.191362]  0000000000000001 ffff880235803e48 ffffffff8178f92c 0000000000000000
[ 3992.191366]  ffff8802322224a0 ffff880235803e78 ffffffff810c9966 ffff8800a5fe3000
[ 3992.191370]  ffff880235803f30 ffff8802359cd768 ffff8802359cd6e0 ffff880235803e98
[ 3992.191374] Call Trace:
[ 3992.191376]  <IRQ>  [<ffffffff8178f92c>] dump_stack+0x4e/0x68
[ 3992.191387]  [<ffffffff810c9966>] lockdep_rcu_suspicious+0xe6/0x130
[ 3992.191392]  [<ffffffff8167213a>] qdisc_watchdog+0x8a/0xb0
[ 3992.191396]  [<ffffffff810f93f2>] __run_hrtimer+0x72/0x420
[ 3992.191399]  [<ffffffff810f9bcd>] ? hrtimer_interrupt+0x7d/0x240
[ 3992.191403]  [<ffffffff816720b0>] ? tc_classify+0xc0/0xc0
[ 3992.191406]  [<ffffffff810f9c4f>] hrtimer_interrupt+0xff/0x240
[ 3992.191410]  [<ffffffff8109e4a5>] ? __atomic_notifier_call_chain+0x5/0x140
[ 3992.191415]  [<ffffffff8103577b>] local_apic_timer_interrupt+0x3b/0x60
[ 3992.191419]  [<ffffffff8179c2b5>] smp_apic_timer_interrupt+0x45/0x60
[ 3992.191422]  [<ffffffff8179a6bf>] apic_timer_interrupt+0x6f/0x80
[ 3992.191424]  <EOI>  [<ffffffff815ed233>] ? cpuidle_enter_state+0x73/0x2e0
[ 3992.191432]  [<ffffffff815ed22e>] ? cpuidle_enter_state+0x6e/0x2e0
[ 3992.191437]  [<ffffffff815ed567>] cpuidle_enter+0x17/0x20
[ 3992.191441]  [<ffffffff810c0741>] cpu_startup_entry+0x3d1/0x4a0
[ 3992.191445]  [<ffffffff81106fc6>] ? clockevents_config_and_register+0x26/0x30
[ 3992.191448]  [<ffffffff81033c16>] start_secondary+0x1b6/0x260

Fixes: b26b0d1e8b1 ("net: qdisc: use rcu prefix and silence sparse warnings")
Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Acked-by: Cong Wang <cwang@twopensource.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

2014-10-04 20:45:54 -04:00

..

act_api.c

net: sched: enable per cpu qstats

2014-09-30 01:02:26 -04:00

act_csum.c

net_sched: act: move tcf_hashinfo_init() into tcf_register_action()

2014-02-12 19:23:32 -05:00

act_gact.c

net_sched: act: move tcf_hashinfo_init() into tcf_register_action()

2014-02-12 19:23:32 -05:00

act_ipt.c

net_sched: act: move tcf_hashinfo_init() into tcf_register_action()

2014-02-12 19:23:32 -05:00

act_mirred.c

net_sched: hold tcf_lock in netdevice notifier

2014-07-20 20:31:42 -07:00

act_nat.c

net_sched: act: move tcf_hashinfo_init() into tcf_register_action()

2014-02-12 19:23:32 -05:00

act_pedit.c

net_sched: act: move tcf_hashinfo_init() into tcf_register_action()

2014-02-12 19:23:32 -05:00

act_police.c

net: sched: make bstats per cpu and estimator RCU safe

2014-09-30 01:02:26 -04:00

act_simple.c

net_sched: act: move tcf_hashinfo_init() into tcf_register_action()

2014-02-12 19:23:32 -05:00

act_skbedit.c

net_sched: act: move tcf_hashinfo_init() into tcf_register_action()

2014-02-12 19:23:32 -05:00

cls_api.c

net_sched: remove the first parameter from tcf_exts_destroy()

2014-09-28 17:29:01 -04:00

cls_basic.c

net_sched: remove the first parameter from tcf_exts_destroy()

2014-09-28 17:29:01 -04:00

cls_bpf.c

net_sched: remove the first parameter from tcf_exts_destroy()

2014-09-28 17:29:01 -04:00

cls_cgroup.c

net_sched: remove the first parameter from tcf_exts_destroy()

2014-09-28 17:29:01 -04:00

cls_flow.c

net_sched: remove the first parameter from tcf_exts_destroy()

2014-09-28 17:29:01 -04:00

cls_fw.c

net_sched: remove the first parameter from tcf_exts_destroy()

2014-09-28 17:29:01 -04:00

cls_route.c

net_sched: remove the first parameter from tcf_exts_destroy()

2014-09-28 17:29:01 -04:00

cls_rsvp6.c

…

cls_rsvp.c

…

cls_rsvp.h

net: sched: cls_rcvp, complete rcu conversion

2014-09-29 00:04:55 -04:00

cls_tcindex.c

net_sched: fix another crash in cls_tcindex

2014-10-01 22:00:42 -04:00

cls_u32.c

net_sched: avoid calling tcf_unbind_filter() in call_rcu callback

2014-10-01 22:00:42 -04:00

em_canid.c

net: em_canid: remove useless statements from em_canid_change

2014-06-21 15:40:22 -07:00

em_cmp.c

net_sched: cleanups

2011-01-19 23:31:12 -08:00

em_ipset.c

em_ipset: use dev_net() accessor

2013-10-18 16:23:06 -04:00

em_meta.c

net: Change skb_get_rxhash to skb_get_hash

2013-12-17 16:36:21 -05:00

em_nbyte.c

net_sched: cleanups

2011-01-19 23:31:12 -08:00

em_text.c

net_sched: cleanups

2011-01-19 23:31:12 -08:00

em_u32.c

net_sched: cleanups

2011-01-19 23:31:12 -08:00

ematch.c

ematch: Fix matching of inverted containers.

2014-09-29 15:31:29 -04:00

Kconfig

net: pkt_sched: PIE AQM scheme

2014-01-06 15:13:01 -05:00

Makefile

net: pkt_sched: PIE AQM scheme

2014-01-06 15:13:01 -05:00

sch_api.c

net: sched: suspicious RCU usage in qdisc_watchdog

2014-10-04 20:45:54 -04:00

sch_atm.c

net: sched: enable per cpu qstats

2014-09-30 01:02:26 -04:00

sch_blackhole.c

…

sch_cbq.c

net: sched: enable per cpu qstats

2014-09-30 01:02:26 -04:00

sch_choke.c

net: sched: implement qstat helper routines

2014-09-30 01:02:26 -04:00

sch_codel.c

net: sched: implement qstat helper routines

2014-09-30 01:02:26 -04:00

sch_drr.c

net: sched: enable per cpu qstats

2014-09-30 01:02:26 -04:00

sch_dsmark.c

net: sched: implement qstat helper routines

2014-09-30 01:02:26 -04:00

sch_fifo.c

net: sched: implement qstat helper routines

2014-09-30 01:02:26 -04:00

sch_fq_codel.c

net: sched: enable per cpu qstats

2014-09-30 01:02:26 -04:00

sch_fq.c

net: sched: implement qstat helper routines

2014-09-30 01:02:26 -04:00

sch_generic.c

qdisc: validate skb without holding lock

2014-10-03 15:36:11 -07:00

sch_gred.c

net: sched: implement qstat helper routines

2014-09-30 01:02:26 -04:00

sch_hfsc.c

net: sched: enable per cpu qstats

2014-09-30 01:02:26 -04:00

sch_hhf.c

net: sched: implement qstat helper routines

2014-09-30 01:02:26 -04:00

sch_htb.c

net: sched: enable per cpu qstats

2014-09-30 01:02:26 -04:00

sch_ingress.c

net: sched: implement qstat helper routines

2014-09-30 01:02:26 -04:00

sch_mq.c

net: sched: enable per cpu qstats

2014-09-30 01:02:26 -04:00

sch_mqprio.c

net: sched: enable per cpu qstats

2014-09-30 01:02:26 -04:00

sch_multiq.c

net: sched: enable per cpu qstats

2014-09-30 01:02:26 -04:00

sch_netem.c

net: sched: implement qstat helper routines

2014-09-30 01:02:26 -04:00

sch_pie.c

net: sched: implement qstat helper routines

2014-09-30 01:02:26 -04:00

sch_plug.c

net_sched: sch_plug: plug_qdisc_ops is static

2012-02-13 16:04:40 -05:00

sch_prio.c

net: sched: enable per cpu qstats

2014-09-30 01:02:26 -04:00

sch_qfq.c

net: sched: enable per cpu qstats

2014-09-30 01:02:26 -04:00

sch_red.c

net: sched: implement qstat helper routines

2014-09-30 01:02:26 -04:00

sch_sfb.c

net: sched: implement qstat helper routines

2014-09-30 01:02:26 -04:00

sch_sfq.c

net: sched: enable per cpu qstats

2014-09-30 01:02:26 -04:00

sch_tbf.c

net: sched: implement qstat helper routines

2014-09-30 01:02:26 -04:00

sch_teql.c

net: qdisc: use rcu prefix and silence sparse warnings

2014-09-13 12:30:25 -04:00