Andrey Ryabinin
79b25b1a58
stackdepot: respect __GFP_NOLOCKDEP allocation flag
...
commit 6fe60465e1d53ea321ee909be26d97529e8f746c upstream.
If stack_depot_save_flags() allocates memory it always drops
__GFP_NOLOCKDEP flag. So when KASAN tries to track __GFP_NOLOCKDEP
allocation we may end up with lockdep splat like bellow:
======================================================
WARNING: possible circular locking dependency detected
6.9.0-rc3+ #49 Not tainted
------------------------------------------------------
kswapd0/149 is trying to acquire lock:
ffff88811346a920
(&xfs_nondir_ilock_class){++++}-{4:4}, at: xfs_reclaim_inode+0x3ac/0x590
[xfs]
but task is already holding lock:
ffffffff8bb33100 (fs_reclaim){+.+.}-{0:0}, at:
balance_pgdat+0x5d9/0xad0
which lock already depends on the new lock.
the existing dependency chain (in reverse order) is:
-> #1 (fs_reclaim){+.+.}-{0:0}:
__lock_acquire+0x7da/0x1030
lock_acquire+0x15d/0x400
fs_reclaim_acquire+0xb5/0x100
prepare_alloc_pages.constprop.0+0xc5/0x230
__alloc_pages+0x12a/0x3f0
alloc_pages_mpol+0x175/0x340
stack_depot_save_flags+0x4c5/0x510
kasan_save_stack+0x30/0x40
kasan_save_track+0x10/0x30
__kasan_slab_alloc+0x83/0x90
kmem_cache_alloc+0x15e/0x4a0
__alloc_object+0x35/0x370
__create_object+0x22/0x90
__kmalloc_node_track_caller+0x477/0x5b0
krealloc+0x5f/0x110
xfs_iext_insert_raw+0x4b2/0x6e0 [xfs]
xfs_iext_insert+0x2e/0x130 [xfs]
xfs_iread_bmbt_block+0x1a9/0x4d0 [xfs]
xfs_btree_visit_block+0xfb/0x290 [xfs]
xfs_btree_visit_blocks+0x215/0x2c0 [xfs]
xfs_iread_extents+0x1a2/0x2e0 [xfs]
xfs_buffered_write_iomap_begin+0x376/0x10a0 [xfs]
iomap_iter+0x1d1/0x2d0
iomap_file_buffered_write+0x120/0x1a0
xfs_file_buffered_write+0x128/0x4b0 [xfs]
vfs_write+0x675/0x890
ksys_write+0xc3/0x160
do_syscall_64+0x94/0x170
entry_SYSCALL_64_after_hwframe+0x71/0x79
Always preserve __GFP_NOLOCKDEP to fix this.
Link: https://lkml.kernel.org/r/20240418141133.22950-1-ryabinin.a.a@gmail.com
Fixes: cd11016e5f52 ("mm, kasan: stackdepot implementation. Enable stackdepot for SLAB")
Signed-off-by: Andrey Ryabinin <ryabinin.a.a@gmail.com>
Reported-by: Xiubo Li <xiubli@redhat.com>
Closes: https://lore.kernel.org/all/a0caa289-ca02-48eb-9bf2-d86fd47b71f4@redhat.com/
Reported-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Closes: https://lore.kernel.org/all/f9ff999a-e170-b66b-7caf-293f2b147ac2@opensource.wdc.com/
Suggested-by: Dave Chinner <david@fromorbit.com>
Tested-by: Xiubo Li <xiubli@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Alexander Potapenko <glider@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-05-02 16:17:13 +02:00
..
2017-11-02 11:10:55 +01:00
2022-06-25 11:48:58 +02:00
2020-11-10 12:35:57 +01:00
2017-10-03 17:54:25 -07:00
2017-11-02 11:10:55 +01:00
2023-09-23 10:48:15 +02:00
2022-04-15 14:14:54 +02:00
2019-07-26 09:14:12 +02:00
2021-11-26 11:36:06 +01:00
2020-06-25 15:33:02 +02:00
2018-03-26 02:01:27 +09:00
2018-08-22 10:52:48 -07:00
2018-06-12 16:19:22 -07:00
2017-12-01 13:09:40 -08:00
2017-12-01 13:09:40 -08:00
2017-12-08 15:13:27 +00:00
2022-06-06 08:24:20 +02:00
2017-07-14 15:05:13 -07:00
2018-06-21 14:25:21 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-10-12 09:17:46 +02:00
2019-12-01 09:17:08 +01:00
2019-04-05 22:33:08 +02:00
2018-03-14 16:55:29 -07:00
2018-08-16 12:14:42 -07:00
2021-05-22 10:59:35 +02:00
2017-11-02 11:10:55 +01:00
2019-11-20 18:47:11 +01:00
2017-11-02 11:10:55 +01:00
2023-08-30 16:31:55 +02:00
2017-11-02 11:10:55 +01:00
2017-09-08 18:26:49 -07:00
2017-12-01 13:09:40 -08:00
2017-11-02 11:10:55 +01:00
2023-06-14 10:57:13 +02:00
2018-02-06 18:32:44 -08:00
2017-09-26 15:01:20 -06:00
2017-09-26 15:01:20 -06:00
2020-10-30 10:38:21 +01:00
2018-07-27 19:04:33 +08:00
2020-11-10 12:35:57 +01:00
2018-08-22 10:52:48 -07:00
2018-01-08 10:08:33 +00:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-11-13 11:08:20 -08:00
2023-08-11 11:45:24 +02:00
2018-06-12 23:33:24 +02:00
2018-07-27 19:16:38 +08:00
2017-11-02 11:10:55 +01:00
2021-07-20 16:16:10 +02:00
2021-11-26 11:36:06 +01:00
2017-11-02 11:10:55 +01:00
2020-05-10 10:30:11 +02:00
2017-10-12 17:16:40 +01:00
2019-04-20 09:16:05 +02:00
2019-11-12 19:20:37 +01:00
2023-06-09 10:24:02 +02:00
2017-11-15 11:56:19 -08:00
2018-01-12 17:33:38 -08:00
2018-04-27 08:51:26 -04:00
2017-07-10 16:32:35 -07:00
2017-08-10 15:54:06 -07:00
2018-05-11 17:28:45 -07:00
2020-04-17 10:48:43 +02:00
2017-11-02 11:10:55 +01:00
2017-10-07 10:45:14 -06:00
2018-07-27 19:04:33 +08:00
2018-08-22 10:52:48 -07:00
2021-01-12 20:10:16 +01:00
2017-02-24 17:46:57 -08:00
2017-02-24 17:46:57 -08:00
2022-05-12 12:20:20 +02:00
2017-11-02 11:10:55 +01:00
2023-09-23 10:48:14 +02:00
2017-11-02 11:10:55 +01:00
2019-01-22 21:40:34 +01:00
2018-06-12 16:19:22 -07:00
2017-11-02 11:10:55 +01:00
2018-05-09 06:55:44 +02:00
2018-07-04 21:37:08 +02:00
2022-02-23 11:58:41 +01:00
2017-11-02 11:10:55 +01:00
2017-03-02 08:42:38 +01:00
2017-11-02 11:10:55 +01:00
2022-03-23 09:10:41 +01:00
2022-12-08 11:18:34 +01:00
2018-07-26 19:38:03 -07:00
2017-05-16 08:44:22 -03:00
2018-08-10 20:19:58 -07:00
2020-01-27 14:51:08 +01:00
2018-07-02 16:20:23 -04:00
2021-05-22 10:59:47 +02:00
2023-11-08 11:22:17 +01:00
2021-07-20 16:15:45 +02:00
2021-07-20 16:15:45 +02:00
2018-03-26 15:09:38 +02:00
2022-08-25 11:15:45 +02:00
2017-11-02 11:10:55 +01:00
2017-10-25 11:01:08 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2018-07-03 09:44:36 +02:00
2018-04-12 09:41:19 -07:00
2021-03-17 16:43:46 +01:00
2018-06-12 16:19:22 -07:00
2017-12-01 13:09:40 -08:00
2022-06-25 11:48:58 +02:00
2017-11-02 11:10:55 +01:00
2017-12-01 13:09:40 -08:00
2017-11-02 11:10:55 +01:00
2021-05-22 10:59:44 +02:00
2018-07-09 14:10:40 +02:00
2022-06-14 16:59:38 +02:00
2023-01-18 11:30:06 +01:00
2017-11-02 11:10:55 +01:00
2017-12-08 15:13:28 +00:00
2022-10-26 13:19:26 +02:00
2017-02-03 16:35:42 -05:00
2016-12-06 10:17:03 +02:00
2018-01-26 11:45:16 -06:00
2018-08-30 12:56:40 +02:00
2018-03-19 10:09:44 -07:00
2017-03-02 08:42:27 +01:00
2017-01-23 09:17:12 +01:00
2023-08-11 11:45:01 +02:00
2022-06-25 11:49:08 +02:00
2022-09-05 10:26:30 +02:00
2017-11-02 11:10:55 +01:00
2018-06-12 16:19:22 -07:00
2017-12-14 16:00:48 -08:00
2018-07-07 01:45:31 +02:00
2018-07-17 09:27:43 +02:00
2019-04-03 06:26:17 +02:00
2019-05-31 06:46:00 -07:00
2020-11-05 11:08:45 +01:00
2021-07-20 16:16:05 +02:00
2022-06-25 11:48:58 +02:00
2018-04-13 17:10:28 -07:00
2017-02-22 16:41:30 -08:00
2022-06-25 11:49:11 +02:00
2018-01-05 15:24:00 +01:00
2017-11-02 11:10:55 +01:00
2024-05-02 16:17:13 +02:00
2017-09-13 18:53:16 -07:00
2021-02-13 13:51:15 +01:00
2020-06-22 09:04:59 +02:00
2020-06-22 09:04:59 +02:00
2017-11-02 11:10:55 +01:00
2018-06-27 18:58:49 +03:00
2018-05-18 17:17:12 -07:00
2021-09-22 11:48:04 +02:00
2019-01-13 09:51:10 +01:00
2023-08-30 16:31:50 +02:00
2018-12-08 12:59:06 +01:00
2018-10-15 16:31:29 -04:00
2020-02-11 04:33:57 -08:00
2022-04-15 14:14:53 +02:00
2017-11-17 16:10:01 -08:00
2019-08-06 19:06:51 +02:00
2017-02-26 11:03:38 -05:00
2018-06-25 13:44:20 +02:00
2019-02-12 19:47:21 +01:00
2017-01-09 13:58:57 -05:00
2018-02-06 18:32:45 -08:00
2019-08-06 19:06:51 +02:00
2017-07-12 16:26:00 -07:00
2018-04-11 10:28:35 -07:00
2018-03-26 15:55:57 +02:00
2017-07-21 09:38:30 +02:00
2019-10-29 09:19:35 +01:00
2021-10-09 14:11:04 +02:00
2023-08-11 11:45:07 +02:00
2017-10-22 03:14:07 +01:00
2017-10-22 03:14:07 +01:00
2019-05-10 17:54:04 +02:00
2018-02-06 18:32:46 -08:00
2018-04-23 16:39:35 +01:00
2018-06-07 17:34:39 -07:00
2023-02-25 11:51:51 +01:00
2017-12-11 15:03:08 -07:00
2022-06-25 11:49:08 +02:00
2017-11-02 11:10:55 +01:00
2017-08-15 09:02:07 -07:00