iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/fs
History
Baokun Li 52ba0ab4f0 jffs2: fix memory leak in jffs2_scan_medium 
commit 9cdd3128874f5fe759e2c4e1360ab7fb96a8d1df upstream.

If an error is returned in jffs2_scan_eraseblock() and some memory
has been added to the jffs2_summary *s, we can observe the following
kmemleak report:

--------------------------------------------
unreferenced object 0xffff88812b889c40 (size 64):
  comm "mount", pid 692, jiffies 4294838325 (age 34.288s)
  hex dump (first 32 bytes):
    40 48 b5 14 81 88 ff ff 01 e0 31 00 00 00 50 00  @H........1...P.
    00 00 01 00 00 00 01 00 00 00 02 00 00 00 09 08  ................
  backtrace:
    [<ffffffffae93a3a3>] __kmalloc+0x613/0x910
    [<ffffffffaf423b9c>] jffs2_sum_add_dirent_mem+0x5c/0xa0
    [<ffffffffb0f3afa8>] jffs2_scan_medium.cold+0x36e5/0x4794
    [<ffffffffb0f3dbe1>] jffs2_do_mount_fs.cold+0xa7/0x2267
    [<ffffffffaf40acf3>] jffs2_do_fill_super+0x383/0xc30
    [<ffffffffaf40c00a>] jffs2_fill_super+0x2ea/0x4c0
    [<ffffffffb0315d64>] mtd_get_sb+0x254/0x400
    [<ffffffffb0315f5f>] mtd_get_sb_by_nr+0x4f/0xd0
    [<ffffffffb0316478>] get_tree_mtd+0x498/0x840
    [<ffffffffaf40bd15>] jffs2_get_tree+0x25/0x30
    [<ffffffffae9f358d>] vfs_get_tree+0x8d/0x2e0
    [<ffffffffaea7a98f>] path_mount+0x50f/0x1e50
    [<ffffffffaea7c3d7>] do_mount+0x107/0x130
    [<ffffffffaea7c5c5>] __se_sys_mount+0x1c5/0x2f0
    [<ffffffffaea7c917>] __x64_sys_mount+0xc7/0x160
    [<ffffffffb10142f5>] do_syscall_64+0x45/0x70
unreferenced object 0xffff888114b54840 (size 32):
  comm "mount", pid 692, jiffies 4294838325 (age 34.288s)
  hex dump (first 32 bytes):
    c0 75 b5 14 81 88 ff ff 02 e0 02 00 00 00 02 00  .u..............
    00 00 84 00 00 00 44 00 00 00 6b 6b 6b 6b 6b a5  ......D...kkkkk.
  backtrace:
    [<ffffffffae93be24>] kmem_cache_alloc_trace+0x584/0x880
    [<ffffffffaf423b04>] jffs2_sum_add_inode_mem+0x54/0x90
    [<ffffffffb0f3bd44>] jffs2_scan_medium.cold+0x4481/0x4794
    [...]
unreferenced object 0xffff888114b57280 (size 32):
  comm "mount", pid 692, jiffies 4294838393 (age 34.357s)
  hex dump (first 32 bytes):
    10 d5 6c 11 81 88 ff ff 08 e0 05 00 00 00 01 00  ..l.............
    00 00 38 02 00 00 28 00 00 00 6b 6b 6b 6b 6b a5  ..8...(...kkkkk.
  backtrace:
    [<ffffffffae93be24>] kmem_cache_alloc_trace+0x584/0x880
    [<ffffffffaf423c34>] jffs2_sum_add_xattr_mem+0x54/0x90
    [<ffffffffb0f3a24f>] jffs2_scan_medium.cold+0x298c/0x4794
    [...]
unreferenced object 0xffff8881116cd510 (size 16):
  comm "mount", pid 692, jiffies 4294838395 (age 34.355s)
  hex dump (first 16 bytes):
    00 00 00 00 00 00 00 00 09 e0 60 02 00 00 6b a5  ..........`...k.
  backtrace:
    [<ffffffffae93be24>] kmem_cache_alloc_trace+0x584/0x880
    [<ffffffffaf423cc4>] jffs2_sum_add_xref_mem+0x54/0x90
    [<ffffffffb0f3b2e3>] jffs2_scan_medium.cold+0x3a20/0x4794
    [...]
--------------------------------------------

Therefore, we should call jffs2_sum_reset_collected(s) on exit to
release the memory added in s. In addition, a new tag "out_buf" is
added to prevent the NULL pointer reference caused by s being NULL.
(thanks to Zhang Yi for this analysis)

Fixes: e631ddba5887 ("[JFFS2] Add erase block summary support (mount time improvement)")
Cc: stable@vger.kernel.org
Co-developed-with: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Baokun Li <libaokun1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2022-04-08 14:22:53 +02:00
..
9p
Revert "fs/9p: search open fids first"
2022-02-08 18:34:04 +01:00
adfs
mm: require ->set_page_dirty to be explicitly wired up
2021-06-29 10:53:48 -07:00
affs
mm: require ->set_page_dirty to be explicitly wired up
2021-06-29 10:53:48 -07:00
afs
afs: Fix mmap
2021-12-22 09:32:45 +01:00
autofs
autofs: fix wait name hash calculation in autofs_wait()
2021-10-20 21:09:02 -04:00
befs
isystem: ship and use stdarg.h
2021-08-19 09:02:55 +09:00
bfs
mm: require ->set_page_dirty to be explicitly wired up
2021-06-29 10:53:48 -07:00
btrfs
btrfs: skip reserved bytes warning on unmount after log cleanup failure
2022-03-23 09:16:43 +01:00
cachefiles
cachefiles: Change %p in format strings to something else
2021-08-27 13:34:02 +01:00
ceph
ceph: put the requests/sessions when it fails to alloc memory
2022-02-01 17:27:14 +01:00
cifs
cifs: we do not need a spinlock around the tree access during umount
2022-04-08 14:22:51 +02:00
coda
…
configfs
configfs: fix a race in configfs_{,un}register_subsystem()
2022-03-02 11:48:02 +01:00
cramfs
…
crypto
fscrypt: allow 256-bit master keys with AES-256-XTS
2021-11-18 19:16:11 +01:00
debugfs
debugfs: lockdown: Allow reading debugfs files that are not world readable
2022-01-27 11:03:55 +01:00
devpts
fsnotify: fix fsnotify hooks in pseudo filesystems
2022-02-01 17:27:01 +01:00
dlm
fs: dlm: filter user dlm messages for kernel locks
2022-01-27 11:04:23 +01:00
ecryptfs
mm: require ->set_page_dirty to be explicitly wired up
2021-06-29 10:53:48 -07:00
efivarfs
…
efs
…
erofs
erofs: fix deadlock when shrink erofs slab
2021-12-01 09:04:50 +01:00
exfat
exfat: fix i_blocks for files truncated over 4 GiB
2022-03-08 19:12:32 +01:00
exportfs
…
ext2
ext2: fix sleeping in atomic bugs on error
2021-09-22 13:05:23 +02:00
ext4
ext4: fast commit may miss file actions
2022-03-08 19:12:32 +01:00
f2fs
f2fs: fix to do sanity check on .cp_pack_total_block_count
2022-04-08 14:22:52 +02:00
fat
linux-kselftest-kunit-5.15-rc1
2021-09-02 12:32:12 -07:00
freevxfs
…
fscache
fscache: Remove an unused static variable
2021-10-04 22:13:12 +01:00
fuse
fuse: fix pipe buffer lifetime for direct_io
2022-03-16 14:23:42 +01:00
gfs2
gfs2: Fix gfs2_release for non-writers regression
2022-02-16 12:56:18 +01:00
hfs
hfs: add lock nesting notation to hfs_find_init
2021-07-15 10:13:49 -07:00
hfsplus
hfsplus: report create_date to kstat.btime
2021-07-01 11:06:06 -07:00
hostfs
hostfs: support splice_write
2021-08-26 22:28:02 +02:00
hpfs
hpfs: use iomap_fiemap to implement ->fiemap
2021-07-27 11:00:36 +02:00
hugetlbfs
hugetlbfs: fix off-by-one error in hugetlb_vmdelete_list()
2022-03-08 19:12:38 +01:00
iomap
iomap: Fix inline extent handling in iomap_readpage
2021-12-01 09:04:44 +01:00
isofs
isofs: Fix out of bound access for corrupted isofs image
2021-11-12 15:05:50 +01:00
jbd2
ext4: fast commit may not fallback for ineligible commit
2022-03-08 19:12:32 +01:00
jffs2
jffs2: fix memory leak in jffs2_scan_medium
2022-04-08 14:22:53 +02:00
jfs
JFS: fix memleak in jfs_mount
2021-11-18 19:16:48 +01:00
kernfs
kernfs: don't create a negative dentry if inactive node exists
2021-10-04 10:27:18 +02:00
ksmbd
ksmbd: don't align last entry offset in smb2 query directory
2022-02-23 12:03:18 +01:00
lockd
lockd: fix failure to cleanup client locks
2022-02-05 12:38:57 +01:00
minix
mm: require ->set_page_dirty to be explicitly wired up
2021-06-29 10:53:48 -07:00
netfs
netfs: fix parameter of cleanup()
2021-12-29 12:28:59 +01:00
nfs
NFS: NFSv2/v3 clients should never be setting NFS_CAP_XATTR
2022-04-08 14:22:52 +02:00
nfs_common
nfs: Fix kerneldoc warning shown up by W=1
2021-10-04 22:02:17 +01:00
nfsd
NFSD: prevent underflow in nfssvc_decode_writeargs()
2022-04-08 14:22:52 +02:00
nilfs2
Merge branch 'akpm' (patches from Andrew)
2021-09-08 12:55:35 -07:00
nls
…
notify
fanotify: Fix stale file descriptor in copy_event_to_user()
2022-02-05 12:38:59 +01:00
ntfs
Merge branch 'work.iov_iter' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2021-07-03 11:30:04 -07:00
ntfs3
Fixed xfstests generic/016 generic/021 generic/022 generic/041 generic/274 generic/423,
2021-10-15 09:58:11 -04:00
ocfs2
ocfs2: fix crash when initialize filecheck kobj fails
2022-03-23 09:16:40 +01:00
omfs
mm: require ->set_page_dirty to be explicitly wired up
2021-06-29 10:53:48 -07:00
openpromfs
…
orangefs
orangefs: Fix the size of a memory allocation in orangefs_bufmap_alloc()
2022-01-20 09:13:13 +01:00
overlayfs
ovl: fix NULL pointer dereference in copy up warning
2022-02-05 12:38:59 +01:00
proc
proc: fix documentation and description of pagemap
2022-03-08 19:12:54 +01:00
pstore
pstore/blk: Use "%lu" to format unsigned long
2021-11-25 09:48:42 +01:00
qnx4
qnx4: work around gcc false positive warning bug
2021-09-21 08:36:48 -07:00
qnx6
…
quota
quota: make dquot_quota_sync return errors from ->sync_fs
2022-02-23 12:03:06 +01:00
ramfs
fs: move ramfs_aops to libfs
2021-06-29 10:53:48 -07:00
reiserfs
Kbuild updates for v5.15
2021-09-03 15:33:47 -07:00
romfs
…
smbfs_common
cifs: Fix crash on unload of cifs_arc4.ko
2021-12-14 10:57:12 +01:00
squashfs
squashfs: use bvec_virt
2021-08-16 10:50:32 -06:00
sysfs
sysfs: Allow deferred execution of iomem_get_mapping()
2021-08-06 13:05:28 +02:00
sysv
mm: require ->set_page_dirty to be explicitly wired up
2021-06-29 10:53:48 -07:00
tracefs
tracefs: Set the group ownership in apply_options() not parse_options()
2022-03-02 11:48:05 +01:00
ubifs
ubifs: Error path in ubifs_remount_rw() seems to wrongly free write buffers
2022-01-27 11:05:07 +01:00
udf
udf: Fix NULL ptr deref when converting from inline format
2022-02-01 17:27:00 +01:00
ufs
isystem: ship and use stdarg.h
2021-08-19 09:02:55 +09:00
unicode
…
vboxsf
vboxfs: fix broken legacy mount signature checking
2021-09-27 11:26:21 -07:00
verity
fs-verity: fix signed integer overflow with i_size near S64_MAX
2021-09-22 10:56:34 -07:00
xfs
xfs: map unwritten blocks in XFS_IOC_{ALLOC,FREE}SP just like fallocate
2022-01-11 15:35:16 +01:00
zonefs
zonefs: add MODULE_ALIAS_FS
2021-12-22 09:32:48 +01:00
aio.c
aio: Fix incorrect usage of eventfd_signal_allowed()
2021-12-14 10:57:22 +01:00
anon_inodes.c
…
attr.c
fs: handle circular mappings correctly
2021-11-25 09:48:46 +01:00
bad_inode.c
vfs: add rcu argument to ->get_acl() callback
2021-08-18 22:08:24 +02:00
binfmt_aout.c
binfmt: a.out: Fix bogus semicolon
2021-09-05 10:15:05 -07:00
binfmt_elf_fdpic.c
binfmt: remove in-tree usage of MAP_DENYWRITE
2021-09-03 18:42:01 +02:00
binfmt_elf.c
elf: don't use MAP_FIXED_NOREPLACE for elf interpreter mappings
2021-10-03 14:02:58 -07:00
binfmt_flat.c
binfmt: remove in-tree usage of MAP_EXECUTABLE
2021-06-29 10:53:50 -07:00
binfmt_misc.c
…
binfmt_script.c
…
buffer.c
mm: fs: invalidate bh_lrus for only cold path
2021-09-24 16:13:35 -07:00
char_dev.c
…
compat_binfmt_elf.c
…
coredump.c
coredump: fix memleak in dump_vma_snapshot()
2021-09-08 11:50:27 -07:00
d_path.c
d_path: make 'prepend()' fill up the buffer exactly on overflow
2021-09-02 10:07:29 -07:00
dax.c
New code for 5.15:
2021-08-31 11:13:35 -07:00
dcache.c
…
direct-io.c
…
drop_caches.c
fs: drop_caches: fix skipping over shadow cache inodes
2021-09-03 09:58:10 -07:00
eventfd.c
eventfd: Export eventfd_wake_count to modules
2021-09-06 07:20:56 -04:00
eventpoll.c
ARM development updates for 5.15:
2021-09-09 13:25:49 -07:00
exec.c
signal: Replace force_sigsegv(SIGSEGV) with force_fatal_sig(SIGSEGV)
2021-11-25 09:49:06 +01:00
fcntl.c
Merge branch 'akpm' (patches from Andrew)
2021-09-03 10:08:28 -07:00
fhandle.c
…
file_table.c
…
file.c
fget: clarify and improve __fget_files() implementation
2022-01-16 09:12:42 +01:00
filesystems.c
fs: simplify get_filesystem_list / get_all_fs_names
2021-08-23 01:25:40 -04:00
fs_context.c
vfs: fs_context: fix up param length parsing in legacy_parse_param
2022-01-20 09:13:14 +01:00
fs_parser.c
namei: Standardize callers of filename_lookup()
2021-09-07 16:07:47 -04:00
fs_pin.c
…
fs_struct.c
…
fs_types.c
…
fs-writeback.c
Merge branch 'akpm' (patches from Andrew)
2021-09-03 10:08:28 -07:00
fsopen.c
…
init.c
…
inode.c
fs: export an inode_update_time helper
2021-11-25 09:49:08 +01:00
internal.h
block: move fs/block_dev.c to block/bdev.c
2021-09-07 08:39:40 -06:00
io_uring.c
io_uring: fix no lock protection for ctx->cq_extra
2022-03-08 19:12:33 +01:00
io-wq.c
io-wq: drop wqe lock before creating new worker
2021-12-22 09:32:51 +01:00
io-wq.h
io-wq: provide a way to limit max number of workers
2021-08-29 07:55:55 -06:00
ioctl.c
New code for 5.15:
2021-08-31 11:06:32 -07:00
Kconfig
4 cifs/smb3 fixes, one for DFS reconnect, and one to begin creating common headers for server and client and the other two to rename the cifs_common directory to smbfs_common to be more consistent ie change use of the name cifs to smb which is more accurate
2021-09-12 10:10:21 -07:00
Kconfig.binfmt
binfmt: remove support for em86 (alpha only)
2021-07-25 22:33:03 -07:00
kernel_read_file.c
vfs: check fd has read access in kernel_read_file_from_fd()
2021-10-18 20:22:03 -10:00
libfs.c
fs: remove noop_set_page_dirty()
2021-06-29 10:53:48 -07:00
locks.c
Revert "memcg: enable accounting for file lock caches"
2021-09-07 11:21:48 -07:00
Makefile
4 cifs/smb3 fixes, one for DFS reconnect, and one to begin creating common headers for server and client and the other two to rename the cifs_common directory to smbfs_common to be more consistent ie change use of the name cifs to smb which is more accurate
2021-09-12 10:10:21 -07:00
mbcache.c
…
mount.h
…
mpage.c
…
namei.c
fsnotify: invalidate dcache before IN_DELETE event
2022-02-01 17:27:15 +01:00
namespace.c
fs/mount_setattr: always cleanup mount_kattr
2022-01-05 12:42:39 +01:00
no-block.c
…
nsfs.c
…
open.c
mm, thp: fix incorrect unmap behavior for private pages
2021-11-18 19:17:17 +01:00
pipe.c
watch_queue: Fix lack of barrier/sync/lock between post and read
2022-03-16 14:23:44 +01:00
pnode.c
…
pnode.h
…
posix_acl.c
ovl: enable RCU'd ->get_acl()
2021-08-18 22:08:24 +02:00
proc_namespace.c
…
read_write.c
fs: clean up after mandatory file locking support removal
2021-08-24 07:52:45 -04:00
readdir.c
…
remap_range.c
fs: remove mandatory file locking support
2021-08-23 06:15:36 -04:00
select.c
select: Fix indefinitely sleeping task in poll_schedule_timeout()
2022-01-29 10:58:25 +01:00
seq_file.c
seq_file: disallow extremely large seq buffer allocations
2021-07-19 17:18:48 -07:00
signalfd.c
signalfd: use wake_up_pollfree()
2021-12-14 10:57:15 +01:00
splice.c
…
stack.c
…
stat.c
fs: add generic helper for filling statx attribute flags
2021-08-17 11:47:43 +02:00
statfs.c
…
super.c
vfs: make freeze_super abort when sync_filesystem returns error
2022-02-23 12:03:05 +01:00
sync.c
…
timerfd.c
timerfd: Provide timerfd_resume()
2021-08-10 17:57:22 +02:00
userfaultfd.c
userfaultfd: fix a race between writeprotect and exit_mmap()
2021-10-18 20:22:02 -10:00
utimes.c
…
xattr.c
…