Eric Dumazet d198b27762 Revert "Revert "ipv4: fix memory leaks in ip_cmsg_send() callers""
This reverts commit d7807a9adf4856171f8441f13078c33941df48ab.

As mentioned in https://lkml.org/lkml/2021/9/13/1819
5 years old commit 919483096bfe ("ipv4: fix memory leaks in ip_cmsg_send() callers")
was a correct fix.

  ip_cmsg_send() can loop over multiple cmsghdr()

  If IP_RETOPTS has been successful, but following cmsghdr generates an error,
  we do not free ipc.ok

  If IP_RETOPTS is not successful, we have freed the allocated temporary space,
  not the one currently in ipc.opt.

Sure, code could be refactored, but let's not bring back old bugs.

Fixes: d7807a9adf48 ("Revert "ipv4: fix memory leaks in ip_cmsg_send() callers"")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Yajun Deng <yajun.deng@linux.dev>
Signed-off-by: David S. Miller <davem@davemloft.net>
2021-09-14 14:24:31 +01:00
..
2021-06-02 14:01:55 -07:00
2021-07-27 20:11:45 +01:00
2021-08-03 11:21:39 +01:00
2021-09-03 15:33:47 -07:00
2021-08-05 13:27:50 +01:00
2021-06-30 15:51:09 -07:00
2021-09-01 11:48:05 +01:00
2021-06-29 11:28:21 -07:00
2021-05-26 07:03:39 +02:00
2021-08-05 13:27:50 +01:00
2021-08-13 14:09:19 -07:00
2021-09-04 10:25:26 -07:00
2021-06-03 15:13:56 -07:00
2021-07-29 15:06:49 +01:00
2021-07-29 15:06:49 +01:00
2021-08-31 16:43:06 -07:00