Eric Dumazet
3900f9268a
net: add annotations on hh->hh_len lockless accesses ...
[ Upstream commit c305c6ae79e2ce20c22660ceda94f0d86d639a82 ]
KCSAN reported a data-race [1]
While we can use READ_ONCE() on the read sides,
we need to make sure hh->hh_len is written last.
[1]
BUG: KCSAN: data-race in eth_header_cache / neigh_resolve_output
write to 0xffff8880b9dedcb8 of 4 bytes by task 29760 on cpu 0:
eth_header_cache+0xa9/0xd0 net/ethernet/eth.c:247
neigh_hh_init net/core/neighbour.c:1463 [inline]
neigh_resolve_output net/core/neighbour.c:1480 [inline]
neigh_resolve_output+0x415/0x470 net/core/neighbour.c:1470
neigh_output include/net/neighbour.h:511 [inline]
ip6_finish_output2+0x7a2/0xec0 net/ipv6/ip6_output.c:116
__ip6_finish_output net/ipv6/ip6_output.c:142 [inline]
__ip6_finish_output+0x2d7/0x330 net/ipv6/ip6_output.c:127
ip6_finish_output+0x41/0x160 net/ipv6/ip6_output.c:152
NF_HOOK_COND include/linux/netfilter.h:294 [inline]
ip6_output+0xf2/0x280 net/ipv6/ip6_output.c:175
dst_output include/net/dst.h:436 [inline]
NF_HOOK include/linux/netfilter.h:305 [inline]
ndisc_send_skb+0x459/0x5f0 net/ipv6/ndisc.c:505
ndisc_send_ns+0x207/0x430 net/ipv6/ndisc.c:647
rt6_probe_deferred+0x98/0xf0 net/ipv6/route.c:615
process_one_work+0x3d4/0x890 kernel/workqueue.c:2269
worker_thread+0xa0/0x800 kernel/workqueue.c:2415
kthread+0x1d4/0x200 drivers/block/aoe/aoecmd.c:1253
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:352
read to 0xffff8880b9dedcb8 of 4 bytes by task 29572 on cpu 1:
neigh_resolve_output net/core/neighbour.c:1479 [inline]
neigh_resolve_output+0x113/0x470 net/core/neighbour.c:1470
neigh_output include/net/neighbour.h:511 [inline]
ip6_finish_output2+0x7a2/0xec0 net/ipv6/ip6_output.c:116
__ip6_finish_output net/ipv6/ip6_output.c:142 [inline]
__ip6_finish_output+0x2d7/0x330 net/ipv6/ip6_output.c:127
ip6_finish_output+0x41/0x160 net/ipv6/ip6_output.c:152
NF_HOOK_COND include/linux/netfilter.h:294 [inline]
ip6_output+0xf2/0x280 net/ipv6/ip6_output.c:175
dst_output include/net/dst.h:436 [inline]
NF_HOOK include/linux/netfilter.h:305 [inline]
ndisc_send_skb+0x459/0x5f0 net/ipv6/ndisc.c:505
ndisc_send_ns+0x207/0x430 net/ipv6/ndisc.c:647
rt6_probe_deferred+0x98/0xf0 net/ipv6/route.c:615
process_one_work+0x3d4/0x890 kernel/workqueue.c:2269
worker_thread+0xa0/0x800 kernel/workqueue.c:2415
kthread+0x1d4/0x200 drivers/block/aoe/aoecmd.c:1253
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:352
Reported by Kernel Concurrency Sanitizer on:
CPU: 1 PID: 29572 Comm: kworker/1:4 Not tainted 5.4.0-rc6+ #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: events rt6_probe_deferred
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2020-01-09 10:20:06 +01:00
2019-07-06 12:50:01 +02:00
2019-09-27 15:10:34 -07:00
2019-06-19 17:09:55 +02:00
2019-10-24 14:53:49 -07:00
2019-09-24 16:37:18 +02:00
2019-11-18 17:08:20 -08:00
2019-09-24 16:37:18 +02:00
2019-10-28 16:39:07 -07:00
2020-01-09 10:20:04 +01:00
2019-07-25 18:00:41 -07:00
2019-07-12 16:03:16 -07:00
2020-01-04 19:18:58 +01:00
2019-10-28 13:33:41 -07:00
2019-12-31 16:45:56 +01:00
2019-09-16 12:06:25 +02:00
2020-01-09 10:20:06 +01:00
2019-05-30 11:29:52 -07:00
2019-12-18 16:08:40 +01:00
2020-01-04 19:18:58 +01:00
2019-07-10 18:43:43 -07:00
2019-11-16 12:23:53 -08:00
2020-01-09 10:20:06 +01:00
2019-12-18 16:08:54 +01:00
2019-10-24 14:53:48 -07:00
2019-09-26 08:56:17 +02:00
2020-01-09 10:19:54 +01:00
2020-01-04 19:19:17 +01:00
2019-07-29 10:26:14 -07:00
2019-09-27 10:27:14 +02:00
2019-07-08 19:48:57 -07:00
2019-12-18 16:08:40 +01:00
2019-06-23 13:24:17 -07:00
2019-06-17 20:20:36 -07:00
2019-10-09 21:42:59 -07:00
2019-12-31 16:45:44 +01:00
2019-05-30 11:26:41 -07:00
2019-12-18 16:08:42 +01:00
2019-09-19 18:04:40 -07:00
2020-01-09 10:20:03 +01:00
2019-09-01 11:45:02 -07:00
2019-06-14 19:50:33 -07:00
2019-10-24 14:53:48 -07:00
2019-12-31 16:41:23 +01:00
2019-06-19 17:09:55 +02:00
2019-12-18 16:08:56 +01:00
2019-12-31 16:41:12 +01:00
2019-10-28 13:33:41 -07:00
2019-12-04 22:30:54 +01:00
2019-09-21 18:45:46 -07:00
2019-11-16 12:59:08 -08:00
2019-12-13 08:43:18 +01:00
2019-10-24 14:53:48 -07:00
2019-10-31 12:23:09 -07:00
2020-01-09 10:20:02 +01:00
2020-01-04 19:18:58 +01:00
2020-01-04 19:18:37 +01:00
2019-06-22 08:59:24 -04:00
2020-01-09 10:20:01 +01:00
2019-05-30 11:26:32 -07:00
2019-12-18 16:08:42 +01:00
2019-12-18 16:08:31 +01:00
2019-10-28 13:33:41 -07:00
2019-11-08 12:17:50 -08:00
2019-08-10 15:25:47 -07:00
2019-10-30 10:11:18 +01:00
2019-10-09 21:42:59 -07:00
2019-10-23 20:22:11 -07:00
2019-11-12 08:24:38 +01:00
2019-05-31 15:30:03 -06:00
2019-08-17 12:40:08 -07:00
2020-01-09 10:19:47 +01:00
2019-05-21 10:50:45 +02:00
3900f9268a