iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/drivers/scsi
History
Michal Hocko 537b604c8b scsi: fix scsi_error_handler vs. scsi_host_dev_release race 
b9d5c6b7ef57 ("[SCSI] cleanup setting task state in
scsi_error_handler()") has introduced a race between scsi_error_handler
and scsi_host_dev_release resulting in the hang when the device goes
away because scsi_error_handler might miss a wake up:

CPU0					CPU1
scsi_error_handler			scsi_host_dev_release
  					  kthread_stop()
  kthread_should_stop()
    test_bit(KTHREAD_SHOULD_STOP)
					    set_bit(KTHREAD_SHOULD_STOP)
					    wake_up_process()
					    wait_for_completion()

  set_current_state(TASK_INTERRUPTIBLE)
  schedule()

The most straightforward solution seems to be to invert the ordering of
the set_current_state and kthread_should_stop.

The issue has been noticed during reboot test on a 3.0 based kernel but
the current code seems to be affected in the same way.

[jejb: additional comment added]
Cc: <stable@vger.kernel.org> # 3.6+
Reported-and-debugged-by: Mike Mayer <Mike.Meyer@teradata.com>
Signed-off-by: Michal Hocko <mhocko@suse.com>
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: James Bottomley <JBottomley@Odin.com>
2015-09-06 12:05:45 -07:00
..
aacraid
aacraid: aac_src_intr_message() can be static
2015-05-25 08:46:25 -07:00
aic7xxx
aic7xxx: replace kmalloc/memset by kzalloc
2015-04-09 13:22:10 -07:00
aic94xx
aic94xx: Skip reading user settings if flash is not found
2015-08-28 13:14:54 -07:00
arcmsr
scsi: drop reason argument from ->change_queue_depth
2014-11-24 14:45:27 +01:00
arm
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
be2iscsi
be2iscsi : Bump the driver version
2015-05-25 08:57:53 -07:00
bfa
bfa: Fix incorrect de-reference of pointer
2015-09-06 11:39:53 -07:00
bnx2fc
Merge remote-tracking branch 'scsi-queue/drivers-for-3.19' into for-linus
2014-12-18 05:56:29 -08:00
bnx2i
bnx2i: Fix call trace while device reset
2015-06-02 17:15:24 -07:00
csiostor
csiostor: fix an error code in csio_hw_init()
2015-05-25 08:46:26 -07:00
cxgbi
libcxgbi: use kvfree() in cxgbi_free_big_mem()
2015-06-30 19:45:00 -07:00
cxlflash
cxlflash: Remove unused variable from queuecommand
2015-08-26 18:08:47 -07:00
device_handler
scsi_dh: kill struct scsi_dh_data
2015-08-28 13:14:57 -07:00
dpt
…
esas2r
SCSI misc on 20150209
2015-02-11 10:28:45 -08:00
fcoe
fcoe: Convert use of __constant_htons to htons
2015-09-06 11:59:20 -07:00
fnic
x86/mm: Decouple <linux/vmalloc.h> from <asm/io.h>
2015-06-03 12:02:00 +02:00
ibmvscsi
IB/srp: Add 64-bit LUN support
2015-05-18 13:35:56 -04:00
isci
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
libfc
libfc: Fix a typo in a source code comment
2015-08-12 11:21:43 -07:00
libsas
Merge branch 'for-4.0-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/libata
2015-03-24 17:08:29 -07:00
lpfc
lpfc: Fix possible use-after-free and double free in lpfc_mbx_cmpl_rdp_page_a2()
2015-09-06 11:51:39 -07:00
megaraid
megaraid_sas: fix whitespace errors
2015-08-26 07:36:51 -07:00
mpt2sas
mpt2sas: setpci reset kernel oops fix
2015-09-06 11:57:25 -07:00
mpt3sas
mpt3sas : Bump mpt3sas driver version to 9.100.00.00
2015-08-27 11:08:31 -07:00
mvsas
mvsas: always iounmap resources
2015-08-12 11:18:47 -07:00
osd
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
2015-04-14 09:50:27 -07:00
pcmcia
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
pm8001
pm80xx: Don't override ts->stat on IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY
2015-09-06 11:53:31 -07:00
qla2xxx
qla2xxx: Update driver version to 8.07.00.26-k
2015-08-26 17:51:01 -07:00
qla4xxx
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
2015-06-24 16:49:49 -07:00
snic
snic: driver for Cisco SCSI HBA
2015-06-19 16:57:51 -07:00
sym53c8xx_2
scsi: drop reason argument from ->change_queue_depth
2014-11-24 14:45:27 +01:00
ufs
SCSI misc on 20150622
2015-06-23 15:55:44 -07:00
.gitignore
…
3w-9xxx.c
3w-9xxx: fix command completion race
2015-04-27 10:10:19 -07:00
3w-9xxx.h
3w-9xxx: fix command completion race
2015-04-27 10:10:19 -07:00
3w-sas.c
3w-sas: fix command completion race
2015-04-27 10:04:39 -07:00
3w-sas.h
3w-sas: fix command completion race
2015-04-27 10:04:39 -07:00
3w-xxxx.c
3w-xxxx: fix command completion race
2015-04-27 10:05:55 -07:00
3w-xxxx.h
3w-xxxx: fix command completion race
2015-04-27 10:05:55 -07:00
53c700_d.h_shipped
…
53c700.c
scsi: remove scsi_set_tag_type
2014-12-04 09:57:13 +01:00
53c700.h
…
53c700.scr
…
a100u2w.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
a100u2w.h
…
a2091.c
zorro: ZTWO_VADDR() should return "void __iomem *"
2013-11-26 11:09:07 +01:00
a2091.h
…
a3000.c
scsi: drop owner assignment from platform_drivers
2014-10-20 16:21:33 +02:00
a3000.h
…
a4000t.c
scsi: drop owner assignment from platform_drivers
2014-10-20 16:21:33 +02:00
advansys.c
advansys: fix compilation errors and warnings when CONFIG_PCI is not set
2015-06-13 08:42:36 -07:00
aha152x.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
aha152x.h
…
aha1542.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
aha1542.h
aha1542: fix include guard and remove useless changelog
2015-04-09 18:08:31 -07:00
aha1740.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
aha1740.h
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
am53c974.c
am53c974: Fix crash during modprobe
2015-04-17 10:13:56 -07:00
atari_NCR5380.c
ncr5380: Harmonize jiffies conversion with msecs_to_jiffies
2015-03-09 10:45:26 -04:00
atari_scsi.c
ncr5380: Drop owner assignment from platform_drivers
2015-03-09 07:18:14 -04:00
atp870u.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
atp870u.h
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
BusLogic.c
scsi: replace seq_printf with seq_puts
2015-02-02 09:57:45 -08:00
BusLogic.h
[SCSI] BusLogic: Port driver to 64-bit.
2013-06-26 18:32:47 -07:00
bvme6000_scsi.c
scsi: drop owner assignment from platform_drivers
2014-10-20 16:21:33 +02:00
ch.c
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial
2015-04-14 09:50:27 -07:00
constants.c
scsi: Conditionally compile in constants.c
2015-01-09 15:44:31 +01:00
dc395x.c
scsi: print single-character strings with seq_putc
2015-02-02 09:57:46 -08:00
dc395x.h
…
dmx3191d.c
dmx3191d: Use NO_IRQ
2014-11-20 09:11:11 +01:00
dpt_i2o.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
dpti.h
scsi: use 64-bit LUNs
2014-07-17 22:07:37 +02:00
dtc.c
ncr5380: Drop legacy scsi.h include
2014-11-20 09:11:10 +01:00
dtc.h
ncr5380: Remove *_RELEASE macros
2014-11-20 09:11:10 +01:00
eata_generic.h
…
eata_pio.c
scsi: replace seq_printf with seq_puts
2015-02-02 09:57:45 -08:00
eata_pio.h
…
eata.c
scsi: drop reason argument from ->change_queue_depth
2014-11-24 14:45:27 +01:00
esp_scsi.c
esp_scsi: remove check for ESP_MAX_TAGS
2015-01-09 15:44:23 +01:00
esp_scsi.h
esp_scsi: correctly detect am53c974
2014-11-24 16:13:16 +01:00
fdomain.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
fdomain.h
…
FlashPoint.c
[SCSI] BusLogic: Port driver to 64-bit.
2013-06-26 18:32:47 -07:00
g_NCR5380_mmio.c
…
g_NCR5380.c
ncr5380: Harmonize jiffies conversion with msecs_to_jiffies
2015-03-09 10:45:26 -04:00
g_NCR5380.h
ncr5380: Remove *_RELEASE macros
2014-11-20 09:11:10 +01:00
gdth_ioctl.h
…
gdth_proc.c
scsi: replace seq_printf with seq_puts
2015-02-02 09:57:45 -08:00
gdth_proc.h
…
gdth.c
scsi: rename SERVICE_ACTION_IN to SERVICE_ACTION_IN_16
2014-11-24 20:01:40 +01:00
gdth.h
…
gvp11.c
zorro: ZTWO_VADDR() should return "void __iomem *"
2013-11-26 11:09:07 +01:00
gvp11.h
…
hosts.c
scsi: remove ordered_tag host template field
2014-11-12 11:19:41 +01:00
hpsa_cmd.h
hpsa: add in new offline mode
2015-08-26 16:28:48 -07:00
hpsa.c
hpsa: fix rmmod issues
2015-08-26 16:29:49 -07:00
hpsa.h
Change how controllers in mixed mode are handled.
2015-08-26 16:28:15 -07:00
hptiop.c
hptiop: Support HighPoint RR36xx HBAs and Support SAS tape and SAS media changer
2015-08-12 13:14:57 -07:00
hptiop.h
hptiop: Support HighPoint RR36xx HBAs and Support SAS tape and SAS media changer
2015-08-12 13:14:57 -07:00
imm.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
imm.h
…
in2000.c
scsi: print single-character strings with seq_putc
2015-02-02 09:57:46 -08:00
in2000.h
…
initio.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
initio.h
…
ipr.c
ipr: Enable SIS pipe commands for SIS-32 devices.
2015-08-28 13:14:53 -07:00
ipr.h
ipr: Driver version 2.6.2
2015-07-30 12:41:47 -07:00
ips.c
ips: remove pointless #warning
2015-06-02 17:24:54 -07:00
ips.h
…
iscsi_boot_sysfs.c
[SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()
2014-03-15 10:19:19 -07:00
iscsi_tcp.c
scsi: drop reason argument from ->change_queue_depth
2014-11-24 14:45:27 +01:00
iscsi_tcp.h
net: Fix use after free by removing length arg from sk_data_ready callbacks.
2014-04-11 16:15:36 -04:00
jazz_esp.c
scsi: drop owner assignment from platform_drivers
2014-10-20 16:21:33 +02:00
Kconfig
cxlflash: Base support for IBM CXL Flash Adapter
2015-07-30 21:02:01 -07:00
lasi700.c
…
libiscsi_tcp.c
[SCSI] libiscsi: Reduce locking contention in fast path
2014-03-15 10:19:18 -07:00
libiscsi.c
scsi: drop reason argument from ->change_queue_depth
2014-11-24 14:45:27 +01:00
mac53c94.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
mac53c94.h
…
mac_esp.c
scsi: drop owner assignment from platform_drivers
2014-10-20 16:21:33 +02:00
mac_scsi.c
ncr5380: Drop owner assignment from platform_drivers
2015-03-09 07:18:14 -04:00
Makefile
scsi_dh: integrate into the core SCSI code
2015-08-28 13:14:56 -07:00
megaraid.c
megaraid : use dev_printk when possible
2015-08-26 07:23:04 -07:00
megaraid.h
[SCSI] megaraid: simplify internal command handling
2014-03-27 08:26:31 -07:00
mesh.c
powerpc: Move Power Macintosh drivers to generic byteswappers
2015-03-23 14:29:40 +11:00
mesh.h
…
mvme16x_scsi.c
scsi: drop owner assignment from platform_drivers
2014-10-20 16:21:33 +02:00
mvme147.c
…
mvme147.h
…
mvumi.c
PCI: Remove DEFINE_PCI_DEVICE_TABLE macro use
2014-08-12 12:15:14 -06:00
mvumi.h
…
ncr53c8xx.c
scsi: drop reason argument from ->change_queue_depth
2014-11-24 14:45:27 +01:00
ncr53c8xx.h
scsi: Remove CONFIG_SCSI_MULTI_LUN
2014-07-17 22:07:35 +02:00
NCR53c406a.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
NCR5380.c
ncr5380: Harmonize jiffies conversion with msecs_to_jiffies
2015-03-09 10:45:26 -04:00
NCR5380.h
atari_NCR5380: Move static co-routine variables to host data
2014-11-20 09:11:20 +01:00
NCR_D700.c
…
NCR_D700.h
…
NCR_Q720.c
…
NCR_Q720.h
…
nsp32_debug.c
…
nsp32_io.h
…
nsp32.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
nsp32.h
…
osst_detect.h
…
osst_options.h
…
osst.c
scsi: remove scsi_driver owner field
2014-11-24 20:01:28 +01:00
osst.h
…
pas16.c
ncr5380: Drop legacy scsi.h include
2014-11-20 09:11:10 +01:00
pas16.h
ncr5380: Remove *_RELEASE macros
2014-11-20 09:11:10 +01:00
pmcraid.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
2015-02-10 20:01:30 -08:00
pmcraid.h
…
ppa.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
ppa.h
…
ps3rom.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
qla1280.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
qla1280.h
…
qlogicfas408.c
…
qlogicfas408.h
…
qlogicfas.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
qlogicpti.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
qlogicpti.h
…
raid_class.c
…
script_asm.pl
…
scsi_common.c
Move code that is used both by initiator and target drivers
2015-06-01 07:32:43 -07:00
scsi_debug.c
scsi_debug: resp_request: remove unused variable
2015-09-06 11:03:14 -07:00
scsi_devinfo.c
SCSI: add 1024 max sectors black list flag
2015-04-27 09:38:06 -07:00
scsi_dh.c
scsi_dh: return SCSI_DH_NOTCONN in scsi_dh_activate()
2015-08-28 13:14:58 -07:00
scsi_error.c
scsi: fix scsi_error_handler vs. scsi_host_dev_release race
2015-09-06 12:05:45 -07:00
scsi_ioctl.c
scsi: return EAGAIN when resetting a device under EH
2014-11-12 11:16:12 +01:00
scsi_lib_dma.c
…
scsi_lib.c
scsi_dh: kill struct scsi_dh_data
2015-08-28 13:14:57 -07:00
scsi_logging.c
scsi_logging: return void for dev_printk() functions
2015-02-04 08:00:24 -08:00
scsi_logging.h
scsi: simplify scsi_log_(send|completion)
2014-11-12 11:16:05 +01:00
scsi_module.c
…
scsi_netlink.c
net: Use netlink_ns_capable to verify the permisions of netlink messages
2014-04-24 13:44:54 -04:00
scsi_pm.c
SCSI / PM: Replace CONFIG_PM_RUNTIME with CONFIG_PM
2014-12-15 15:11:06 +01:00
scsi_priv.h
scsi_dh: integrate into the core SCSI code
2015-08-28 13:14:56 -07:00
scsi_proc.c
scsi: print single-character strings with seq_putc
2015-02-02 09:57:46 -08:00
scsi_sas_internal.h
…
scsi_scan.c
Move code that is used both by initiator and target drivers
2015-06-01 07:32:43 -07:00
scsi_sysctl.c
scsi: convert use of typedef ctl_table to struct ctl_table
2014-06-06 16:08:16 -07:00
scsi_sysfs.c
scsi_dh: integrate into the core SCSI code
2015-08-28 13:14:56 -07:00
scsi_trace.c
scsi: print single-character strings with seq_putc
2015-02-02 09:57:46 -08:00
scsi_transport_api.h
…
scsi_transport_fc.c
scsi_transport_fc: Add support for 25Gbit speed
2015-04-10 07:40:32 -07:00
scsi_transport_iscsi.c
iSCSI: let session recovery_tmo sysfs writes persist across recovery
2015-07-30 12:43:00 -07:00
scsi_transport_sas.c
scsi_transport_sas: Remove check for SAS expander when querying bay/enclosure IDs.
2015-09-06 11:13:41 -07:00
scsi_transport_spi.c
scsi: remove MSG_*_TAG defines
2014-12-04 09:58:33 +01:00
scsi_transport_srp.c
scsi_transport_srp: Reduce failover time
2015-05-18 13:35:55 -04:00
scsi_typedefs.h
…
scsi.c
Move code that is used both by initiator and target drivers
2015-06-01 07:32:43 -07:00
scsi.h
…
scsicam.c
scsi: PC partition tables are little endian
2014-11-12 11:15:54 +01:00
sd_dif.c
sd: Fix missing ATO tag check
2015-04-16 10:37:12 -07:00
sd.c
sd: fix an error return in probe()
2015-05-25 08:46:24 -07:00
sd.h
scsi: introduce sdev_prefix_printk()
2014-11-12 11:15:57 +01:00
ses.c
ses: Add power_status to SES device slot
2015-01-09 15:44:19 +01:00
sg.c
sg_start_req(): use import_iovec()
2015-04-11 22:27:14 -04:00
sgiwd93.c
scsi: drop owner assignment from platform_drivers
2014-10-20 16:21:33 +02:00
sim710.c
…
sni_53c710.c
scsi: drop owner assignment from platform_drivers
2014-10-20 16:21:33 +02:00
sr_ioctl.c
sr: reduce debug noise in sr_do_ioctl
2015-01-20 19:43:24 +01:00
sr_vendor.c
scsi: Implement sr_printk()
2014-07-17 22:07:39 +02:00
sr.c
scsi: remove scsi_driver owner field
2014-11-24 20:01:28 +01:00
sr.h
scsi: introduce sdev_prefix_printk()
2014-11-12 11:15:57 +01:00
st_options.h
…
st.c
st: Destroy st_index_idr on module exit
2015-08-26 07:45:25 -07:00
st.h
st: implement tape statistics
2015-06-02 08:03:25 -07:00
stex.c
scsi: don't force tagged_supported in drivers
2014-11-12 11:19:44 +01:00
storvsc_drv.c
storvsc: Set the error code correctly in failure conditions
2015-08-26 22:41:36 -07:00
sun3_scsi_vme.c
scsi/NCR5380: merge sun3_scsi_vme.c into sun3_scsi.c
2014-05-28 12:16:28 +02:00
sun3_scsi.c
ncr5380: Drop owner assignment from platform_drivers
2015-03-09 07:18:14 -04:00
sun3_scsi.h
sun3_scsi: Move macro definitions
2014-11-20 09:11:15 +01:00
sun3x_esp.c
scsi: drop owner assignment from platform_drivers
2014-10-20 16:21:33 +02:00
sun_esp.c
scsi: drop owner assignment from platform_drivers
2014-10-20 16:21:33 +02:00
sym53c416.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
sym53c416.h
…
t128.c
ncr5380: Drop legacy scsi.h include
2014-11-20 09:11:10 +01:00
t128.h
ncr5380: Remove *_RELEASE macros
2014-11-20 09:11:10 +01:00
u14-34f.c
scsi: drop reason argument from ->change_queue_depth
2014-11-24 14:45:27 +01:00
ultrastor.c
…
ultrastor.h
…
virtio_scsi.c
virtio_scsi: don't select CONFIG_BLK_DEV_INTEGRITY
2015-05-25 09:14:47 -07:00
vmw_pvscsi.c
vmw_pscsi: simplify ->change_queue_depth
2014-11-24 14:45:28 +01:00
vmw_pvscsi.h
PCI: Move PCI_VENDOR_ID_VMWARE to pci_ids.h
2014-09-24 11:52:09 -06:00
wd33c93.c
scsi: print single-character strings with seq_putc
2015-02-02 09:57:46 -08:00
wd33c93.h
…
wd719x.c
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
wd719x.h
scsi: Do not set cmd_per_lun to 1 in the host template
2015-05-31 18:06:28 -07:00
wd7000.c
scsi: replace seq_printf with seq_puts
2015-02-02 09:57:45 -08:00
xen-scsifront.c
xenbus_client: Extend interface to support multi-page ring
2015-04-15 10:56:47 +01:00
zalon.c
…
zorro7xx.c
zorro: ZTWO_VADDR() should return "void __iomem *"
2013-11-26 11:09:07 +01:00