iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/crypto
History
Mao Wenan 9060cb719e net: crypto set sk to NULL when af_alg_release. 
KASAN has found use-after-free in sockfs_setattr.
The existed commit 6d8c50dcb029 ("socket: close race condition between sock_close()
and sockfs_setattr()") is to fix this simillar issue, but it seems to ignore
that crypto module forgets to set the sk to NULL after af_alg_release.

KASAN report details as below:
BUG: KASAN: use-after-free in sockfs_setattr+0x120/0x150
Write of size 4 at addr ffff88837b956128 by task syz-executor0/4186

CPU: 2 PID: 4186 Comm: syz-executor0 Not tainted xxx + #1
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS
1.10.2-1ubuntu1 04/01/2014
Call Trace:
 dump_stack+0xca/0x13e
 print_address_description+0x79/0x330
 ? vprintk_func+0x5e/0xf0
 kasan_report+0x18a/0x2e0
 ? sockfs_setattr+0x120/0x150
 sockfs_setattr+0x120/0x150
 ? sock_register+0x2d0/0x2d0
 notify_change+0x90c/0xd40
 ? chown_common+0x2ef/0x510
 chown_common+0x2ef/0x510
 ? chmod_common+0x3b0/0x3b0
 ? __lock_is_held+0xbc/0x160
 ? __sb_start_write+0x13d/0x2b0
 ? __mnt_want_write+0x19a/0x250
 do_fchownat+0x15c/0x190
 ? __ia32_sys_chmod+0x80/0x80
 ? trace_hardirqs_on_thunk+0x1a/0x1c
 __x64_sys_fchownat+0xbf/0x160
 ? lockdep_hardirqs_on+0x39a/0x5e0
 do_syscall_64+0xc8/0x580
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x462589
Code: f7 d8 64 89 02 b8 ff ff ff ff c3 66 0f 1f 44 00 00 48 89 f8 48 89
f7 48 89 d6 48 89
ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3
48 c7 c1 bc ff ff
ff f7 d8 64 89 01 48
RSP: 002b:00007fb4b2c83c58 EFLAGS: 00000246 ORIG_RAX: 0000000000000104
RAX: ffffffffffffffda RBX: 000000000072bfa0 RCX: 0000000000462589
RDX: 0000000000000000 RSI: 00000000200000c0 RDI: 0000000000000007
RBP: 0000000000000005 R08: 0000000000001000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 00007fb4b2c846bc
R13: 00000000004bc733 R14: 00000000006f5138 R15: 00000000ffffffff

Allocated by task 4185:
 kasan_kmalloc+0xa0/0xd0
 __kmalloc+0x14a/0x350
 sk_prot_alloc+0xf6/0x290
 sk_alloc+0x3d/0xc00
 af_alg_accept+0x9e/0x670
 hash_accept+0x4a3/0x650
 __sys_accept4+0x306/0x5c0
 __x64_sys_accept4+0x98/0x100
 do_syscall_64+0xc8/0x580
 entry_SYSCALL_64_after_hwframe+0x49/0xbe

Freed by task 4184:
 __kasan_slab_free+0x12e/0x180
 kfree+0xeb/0x2f0
 __sk_destruct+0x4e6/0x6a0
 sk_destruct+0x48/0x70
 __sk_free+0xa9/0x270
 sk_free+0x2a/0x30
 af_alg_release+0x5c/0x70
 __sock_release+0xd3/0x280
 sock_close+0x1a/0x20
 __fput+0x27f/0x7f0
 task_work_run+0x136/0x1b0
 exit_to_usermode_loop+0x1a7/0x1d0
 do_syscall_64+0x461/0x580
 entry_SYSCALL_64_after_hwframe+0x49/0xbe

Syzkaller reproducer:
r0 = perf_event_open(&(0x7f0000000000)={0x0, 0x70, 0x0, 0x0, 0x0, 0x0,
0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, @perf_config_ext}, 0x0, 0x0,
0xffffffffffffffff, 0x0)
r1 = socket$alg(0x26, 0x5, 0x0)
getrusage(0x0, 0x0)
bind(r1, &(0x7f00000001c0)=@alg={0x26, 'hash\x00', 0x0, 0x0,
'sha256-ssse3\x00'}, 0x80)
r2 = accept(r1, 0x0, 0x0)
r3 = accept4$unix(r2, 0x0, 0x0, 0x0)
r4 = dup3(r3, r0, 0x0)
fchownat(r4, &(0x7f00000000c0)='\x00', 0x0, 0x0, 0x1000)

Fixes: 6d8c50dcb029 ("socket: close race condition between sock_close() and sockfs_setattr()")
Signed-off-by: Mao Wenan <maowenan@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2019-02-18 12:01:24 -08:00
..
asymmetric_keys
KEYS: asym_tpm: Add support for the sign operation [ver #2]
2018-10-26 09:30:47 +01:00
async_tx
async_pq: Remove VLA usage
2018-06-18 20:17:38 +05:30
842.c
crypto: acomp - add support for 842 via scomp
2016-10-25 11:08:33 +08:00
ablkcipher.c
crypto: skcipher - remove remnants of internal IV generators
2018-12-23 11:52:45 +08:00
acompress.c
crypto: user - clean up report structure copying
2018-11-09 17:41:39 +08:00
adiantum.c
crypto: adiantum - initialize crypto_spawn::inst
2019-01-10 21:37:31 +08:00
aead.c
crypto: user - clean up report structure copying
2018-11-09 17:41:39 +08:00
aegis128.c
crypto: aead - remove useless setting of type flags
2018-07-09 00:30:26 +08:00
aegis128l.c
crypto: aead - remove useless setting of type flags
2018-07-09 00:30:26 +08:00
aegis256.c
crypto: aead - remove useless setting of type flags
2018-07-09 00:30:26 +08:00
aegis.h
crypto: aegis/generic - fix for big endian systems
2018-10-08 13:44:53 +08:00
aes_generic.c
crypto: arm/aes - add some hardening against cache-timing attacks
2018-11-09 17:36:48 +08:00
aes_ti.c
crypto: aes_ti - disable interrupts while accessing S-box
2018-11-09 17:36:48 +08:00
af_alg.c
net: crypto set sk to NULL when af_alg_release.
2019-02-18 12:01:24 -08:00
ahash.c
crypto: user - fix use_after_free of struct xxx_request
2018-12-07 14:15:00 +08:00
akcipher.c
crypto: user - clean up report structure copying
2018-11-09 17:41:39 +08:00
algapi.c
crypto: user - Add crypto_stats_init
2018-12-07 14:15:00 +08:00
algboss.c
crypto: api - Introduce notifier for new crypto algorithms
2018-09-04 11:37:04 +08:00
algif_aead.c
crypto: null - Remove VLA usage of skcipher
2018-09-28 12:46:08 +08:00
algif_hash.c
crypto: hash - Remove VLA usage
2018-09-04 11:35:03 +08:00
algif_rng.c
net: remove sock_no_poll
2018-05-26 09:16:44 +02:00
algif_skcipher.c
Revert changes to convert to ->poll_mask() and aio IOCB_CMD_POLL
2018-06-28 10:40:47 -07:00
ansi_cprng.c
crypto: ansi_cprng - Convert to new rng interface
2015-04-22 09:30:18 +08:00
anubis.c
crypto: prefix module autoloading with "crypto-"
2014-11-24 22:43:57 +08:00
api.c
evm: Don't deadlock if a crypto algorithm is unavailable
2018-07-18 07:27:22 -04:00
arc4.c
crypto: prefix module autoloading with "crypto-"
2014-11-24 22:43:57 +08:00
authenc.c
crypto: authenc - fix parsing key with misaligned rta_len
2019-01-10 21:37:31 +08:00
authencesn.c
crypto: authencesn - Avoid twice completion call in decrypt path
2019-01-10 21:37:31 +08:00
blkcipher.c
crypto: skcipher - remove remnants of internal IV generators
2018-12-23 11:52:45 +08:00
blowfish_common.c
…
blowfish_generic.c
crypto: add missing crypto module aliases
2015-01-13 22:29:11 +11:00
camellia_generic.c
crypto: replace FSF address with web source in license notices
2017-11-29 17:33:25 +11:00
cast5_generic.c
crypto: replace FSF address with web source in license notices
2017-11-29 17:33:25 +11:00
cast6_generic.c
crypto: replace FSF address with web source in license notices
2017-11-29 17:33:25 +11:00
cast_common.c
…
cbc.c
crypto: do not free algorithm before using
2018-11-29 14:53:59 +08:00
ccm.c
crypto: ccm - Remove VLA usage
2018-09-04 11:35:03 +08:00
cfb.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2018-12-07 13:59:10 +08:00
chacha20poly1305.c
crypto: chacha20-generic - refactor to allow varying number of rounds
2018-11-20 14:26:55 +08:00
chacha_generic.c
crypto: chacha - add XChaCha12 support
2018-11-20 14:26:55 +08:00
cipher.c
crypto: remove several VLAs
2018-04-21 00:58:34 +08:00
cmac.c
crypto: algapi - make crypto_xor() and crypto_inc() alignment agnostic
2017-02-11 17:52:28 +08:00
compress.c
crypto: api - Remove no-op exit_ops code
2016-10-21 11:03:42 +08:00
crc32_generic.c
crypto: crc32-generic - remove __crc32_le()
2018-05-27 00:12:09 +08:00
crc32c_generic.c
crypto: crc32c-generic - remove cra_alignmask
2018-05-27 00:12:08 +08:00
crct10dif_common.c
crypto: crct10dif - Add fallback for broken initrds
2013-09-12 15:31:34 +10:00
crct10dif_generic.c
crypto: squash lines for simple wrapper functions
2016-09-13 20:27:26 +08:00
cryptd.c
crypto: skcipher - remove remnants of internal IV generators
2018-12-23 11:52:45 +08:00
crypto_engine.c
crypto: engine - Permit to enqueue all async requests
2018-02-15 23:26:50 +08:00
crypto_null.c
crypto: null - Remove VLA usage of skcipher
2018-09-28 12:46:08 +08:00
crypto_user_base.c
crypto: user - remove unused dump functions
2018-12-23 11:52:44 +08:00
crypto_user_stat.c
crypto: user - remove unused dump functions
2018-12-23 11:52:44 +08:00
crypto_wq.c
crypto: crypto_wq - Fix late crypto work queue initialization
2014-03-21 21:54:28 +08:00
ctr.c
crypto: skcipher - remove remnants of internal IV generators
2018-12-23 11:52:45 +08:00
cts.c
crypto: remove several VLAs
2018-04-21 00:58:34 +08:00
deflate.c
crypto: scomp - add support for deflate rfc1950 (zlib)
2017-04-24 18:11:08 +08:00
des_generic.c
crypto: add missing crypto module aliases
2015-01-13 22:29:11 +11:00
dh_helper.c
crypto: dh - make crypto_dh_encode_key() make robust
2018-08-03 18:06:06 +08:00
dh.c
crypto: dh - fix memory leak
2018-07-20 13:51:21 +08:00
drbg.c
crypto: drbg - in-place cipher operation for CTR
2018-08-03 18:05:48 +08:00
ecb.c
crypto: include crypto- module prefix in template
2014-11-26 20:06:30 +08:00
ecc_curve_defs.h
crypto: ecdh - fix typo of P-192 b value
2018-07-20 13:51:22 +08:00
ecc.c
crypto: ecc - regularize scalar for scalar multiplication
2018-11-16 14:11:04 +08:00
ecc.h
crypto: ecc - Actually remove stack VLA usage
2018-04-21 00:58:29 +08:00
ecdh_helper.c
crypto: ecdh - return unsigned value for crypto_ecdh_key_len()
2017-10-12 22:55:00 +08:00
ecdh.c
crypto: ecc - Actually remove stack VLA usage
2018-04-21 00:58:29 +08:00
echainiv.c
crypto: null - Remove VLA usage of skcipher
2018-09-28 12:46:08 +08:00
fcrypt.c
crypto: prefix module autoloading with "crypto-"
2014-11-24 22:43:57 +08:00
fips.c
crypto: fips - Move fips_enabled sysctl into fips.c
2015-04-23 14:18:09 +08:00
gcm.c
crypto: null - Remove VLA usage of skcipher
2018-09-28 12:46:08 +08:00
gf128mul.c
crypto: gf128mul - remove incorrect comment
2017-12-22 19:52:40 +11:00
ghash-generic.c
crypto: shash - remove useless setting of type flags
2018-07-09 00:30:24 +08:00
hash_info.c
crypto: streebog - register Streebog in hash info for IMA
2018-11-16 14:09:40 +08:00
hmac.c
crypto: hmac - require that the underlying hash algorithm is unkeyed
2017-11-29 13:39:15 +11:00
internal.h
crypto: api - Introduce notifier for new crypto algorithms
2018-09-04 11:37:04 +08:00
jitterentropy-kcapi.c
crypto: jitterentropy - drop duplicate header module.h
2016-11-17 23:34:52 +08:00
jitterentropy.c
crypto: jitterentropy - Delete unnecessary checks before the function call "kzfree"
2015-06-25 23:18:33 +08:00
Kconfig
Kconfig updates for v4.21
2018-12-29 13:03:29 -08:00
keywrap.c
crypto: keywrap - Add missing ULL suffixes for 64-bit constants
2017-11-29 17:33:26 +11:00
khazad.c
crypto: prefix module autoloading with "crypto-"
2014-11-24 22:43:57 +08:00
kpp.c
crypto: user - clean up report structure copying
2018-11-09 17:41:39 +08:00
lrw.c
crypto: lrw - fix rebase error after out of bounds fix
2018-10-05 10:22:48 +08:00
lz4.c
crypto: remove useless initializations of cra_list
2018-11-20 14:26:55 +08:00
lz4hc.c
crypto: remove useless initializations of cra_list
2018-11-20 14:26:55 +08:00
lzo.c
treewide: use kv[mz]alloc* rather than opencoded variants
2017-05-08 17:15:13 -07:00
Makefile
crypto: user - made crypto_user_stat optional
2018-12-07 14:15:00 +08:00
md4.c
crypto: shash - remove useless setting of type flags
2018-07-09 00:30:24 +08:00
md5.c
crypto: shash - remove useless setting of type flags
2018-07-09 00:30:24 +08:00
memneq.c
crypto: memneq - fix for archs without efficient unaligned access
2013-12-09 20:09:12 +08:00
michael_mic.c
crypto: prefix module autoloading with "crypto-"
2014-11-24 22:43:57 +08:00
morus640.c
crypto: morus/generic - fix for big endian systems
2018-10-08 13:44:53 +08:00
morus1280.c
crypto: morus/generic - fix for big endian systems
2018-10-08 13:44:53 +08:00
nhpoly1305.c
crypto: adiantum - adjust some comments to match latest paper
2018-12-13 18:24:59 +08:00
ofb.c
crypto: ofb - add output feedback mode
2018-09-28 12:46:26 +08:00
pcbc.c
crypto: do not free algorithm before using
2018-11-29 14:53:59 +08:00
pcrypt.c
Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
2018-12-27 13:53:32 -08:00
poly1305_generic.c
crypto: poly1305 - add Poly1305 core API
2018-11-20 14:26:56 +08:00
proc.c
proc: introduce proc_create_seq{,_data}
2018-05-16 07:23:35 +02:00
ripemd.h
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
rmd128.c
crypto: shash - remove useless setting of type flags
2018-07-09 00:30:24 +08:00
rmd160.c
crypto: shash - remove useless setting of type flags
2018-07-09 00:30:24 +08:00
rmd256.c
crypto: rmd256 - use swap macro in rmd256_transform
2018-07-27 19:28:36 +08:00
rmd320.c
crypto: rmd320 - use swap macro in rmd320_transform
2018-07-27 19:28:36 +08:00
rng.c
crypto: user - fix use_after_free of struct xxx_request
2018-12-07 14:15:00 +08:00
rsa_helper.c
kbuild: rename *-asn1.[ch] to *.asn1.[ch]
2018-04-07 19:04:02 +09:00
rsa-pkcs1pad.c
crypto: rsa-pkcs1pad: Allow hash to be optional [ver #2]
2018-10-26 09:30:46 +01:00
rsa.c
crypto: rsa - Remove unneeded error assignment
2018-04-21 00:58:37 +08:00
rsaprivkey.asn1
crypto: rsa - Store rest of the private key components
2016-07-05 23:05:26 +08:00
rsapubkey.asn1
crypto: akcipher - Changes to asymmetric key API
2015-10-14 22:23:16 +08:00
salsa20_generic.c
crypto: salsa20-generic - don't unnecessarily use atomic walk
2018-12-23 11:52:44 +08:00
scatterwalk.c
crypto: scatterwalk - remove 'chain' argument from scatterwalk_crypto_chain()
2018-08-03 18:06:03 +08:00
scompress.c
crypto: user - clean up report structure copying
2018-11-09 17:41:39 +08:00
seed.c
crypto: prefix module autoloading with "crypto-"
2014-11-24 22:43:57 +08:00
seqiv.c
crypto: null - Remove VLA usage of skcipher
2018-09-28 12:46:08 +08:00
serpent_generic.c
crypto: serpent - improve __serpent_setkey with UBSAN
2017-08-09 20:17:54 +08:00
sha1_generic.c
crypto: shash - remove useless setting of type flags
2018-07-09 00:30:24 +08:00
sha3_generic.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux
2018-08-03 17:55:12 +08:00
sha256_generic.c
crypto: shash - remove useless setting of type flags
2018-07-09 00:30:24 +08:00
sha512_generic.c
crypto: shash - remove useless setting of type flags
2018-07-09 00:30:24 +08:00
shash.c
crypto: user - clean up report structure copying
2018-11-09 17:41:39 +08:00
simd.c
crypto: simd - correctly take reqsize of wrapped skcipher into account
2018-11-09 17:35:43 +08:00
skcipher.c
crypto: skcipher - remove remnants of internal IV generators
2018-12-23 11:52:45 +08:00
sm3_generic.c
crypto: sm3 - fix undefined shift by >= width of value
2019-01-10 21:37:32 +08:00
sm4_generic.c
crypto: sm4 - export encrypt/decrypt routines to other drivers
2018-05-05 14:52:51 +08:00
streebog_generic.c
crypto: streebog - add Streebog hash function
2018-11-16 14:09:40 +08:00
tcrypt.c
crypto: tcrypt - add block size of 1472 to skcipher template
2018-12-13 18:24:40 +08:00
tcrypt.h
crypto: testmgr - update sm4 test vectors
2018-09-28 12:46:26 +08:00
tea.c
crypto: add missing crypto module aliases
2015-01-13 22:29:11 +11:00
testmgr.c
crypto: adiantum - add Adiantum support
2018-11-20 14:26:56 +08:00
testmgr.h
crypto: xchacha20 - fix comments for test vectors
2018-12-13 18:24:59 +08:00
tgr192.c
crypto: shash - remove useless setting of type flags
2018-07-09 00:30:24 +08:00
twofish_common.c
crypto: replace FSF address with web source in license notices
2017-11-29 17:33:25 +11:00
twofish_generic.c
crypto: replace FSF address with web source in license notices
2017-11-29 17:33:25 +11:00
vmac.c
crypto: vmac - remove insecure version with hardcoded nonce
2018-07-01 21:00:44 +08:00
wp512.c
crypto: shash - remove useless setting of type flags
2018-07-09 00:30:24 +08:00
xcbc.c
crypto: xcbc - Remove VLA usage
2018-09-04 11:35:03 +08:00
xor.c
kmemcheck: stop using GFP_NOTRACK and SLAB_NOTRACK
2017-11-15 18:21:04 -08:00
xts.c
crypto: xts - Drop use of auxiliary buffer
2018-09-21 13:24:50 +08:00
zstd.c
crypto: zstd - Add zstd support
2018-04-21 00:58:30 +08:00