iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net
History
Eric Dumazet 05c9e3fc93 netlink: annotate lockless accesses to nlk->max_recvmsg_len 
commit a1865f2e7d10dde00d35a2122b38d2e469ae67ed upstream.

syzbot reported a data-race in data-race in netlink_recvmsg() [1]

Indeed, netlink_recvmsg() can be run concurrently,
and netlink_dump() also needs protection.

[1]
BUG: KCSAN: data-race in netlink_recvmsg / netlink_recvmsg

read to 0xffff888141840b38 of 8 bytes by task 23057 on cpu 0:
netlink_recvmsg+0xea/0x730 net/netlink/af_netlink.c:1988
sock_recvmsg_nosec net/socket.c:1017 [inline]
sock_recvmsg net/socket.c:1038 [inline]
__sys_recvfrom+0x1ee/0x2e0 net/socket.c:2194
__do_sys_recvfrom net/socket.c:2212 [inline]
__se_sys_recvfrom net/socket.c:2208 [inline]
__x64_sys_recvfrom+0x78/0x90 net/socket.c:2208
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd

write to 0xffff888141840b38 of 8 bytes by task 23037 on cpu 1:
netlink_recvmsg+0x114/0x730 net/netlink/af_netlink.c:1989
sock_recvmsg_nosec net/socket.c:1017 [inline]
sock_recvmsg net/socket.c:1038 [inline]
____sys_recvmsg+0x156/0x310 net/socket.c:2720
___sys_recvmsg net/socket.c:2762 [inline]
do_recvmmsg+0x2e5/0x710 net/socket.c:2856
__sys_recvmmsg net/socket.c:2935 [inline]
__do_sys_recvmmsg net/socket.c:2958 [inline]
__se_sys_recvmmsg net/socket.c:2951 [inline]
__x64_sys_recvmmsg+0xe2/0x160 net/socket.c:2951
do_syscall_x64 arch/x86/entry/common.c:50 [inline]
do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80
entry_SYSCALL_64_after_hwframe+0x63/0xcd

value changed: 0x0000000000000000 -> 0x0000000000001000

Reported by Kernel Concurrency Sanitizer on:
CPU: 1 PID: 23037 Comm: syz-executor.2 Not tainted 6.3.0-rc4-syzkaller-00195-g5a57b48fdfcb #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023

Fixes: 9063e21fb026 ("netlink: autosize skb lengthes")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Link: https://lore.kernel.org/r/20230403214643.768555-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: yenchia.chen <yenchia.chen@mediatek.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2024-05-25 16:19:06 +02:00
..
6lowpan
…
9p
9p/net: fix possible memory leak in p9_check_errors()
2024-01-05 15:12:29 +01:00
802
mrp: introduce active flags to prevent UAF when applicant uninit
2023-01-14 10:16:18 +01:00
8021q
vlan: skip nested type that is not IFLA_VLAN_QOS_MAPPING
2024-02-23 08:41:55 +01:00
appletalk
appletalk: Fix Use-After-Free in atalk_ioctl
2023-12-20 15:44:29 +01:00
atm
atm: Fix Use-After-Free in do_vcc_ioctl
2023-12-20 15:44:28 +01:00
ax25
net: ax25: Fix deadlock caused by skb_recv_datagram in ax25_recvmsg
2022-06-22 14:13:17 +02:00
batman-adv
batman-adv: Avoid infinite loop trying to resize local TT
2024-05-02 16:23:33 +02:00
bluetooth
Bluetooth: l2cap: fix null-ptr-deref in l2cap_chan_timeout
2024-05-17 11:48:06 +02:00
bpf
bpf: Move skb->len == 0 checks into __bpf_redirect
2023-01-14 10:15:31 +01:00
bpfilter
…
bridge
net: bridge: fix corrupted ethernet header on multicast-to-unicast
2024-05-17 11:48:07 +02:00
caif
net: caif: Fix use-after-free in cfusbl_device_notify()
2023-03-17 08:45:11 +01:00
can
can: j1939: Fix UAF in j1939_sk_match_filter during setsockopt(SO_J1939_FILTER)
2024-02-23 08:42:29 +01:00
ceph
libceph: use kernel_connect()
2023-10-25 11:54:15 +02:00
core
net: fix out-of-bounds access in ops_init
2024-05-17 11:48:10 +02:00
dcb
net: dcb: choose correct policy to parse DCB_ATTR_BCN
2023-08-11 11:57:50 +02:00
dccp
dccp/tcp: Call security_inet_conn_request() after setting IPv6 addresses.
2023-11-20 11:06:55 +01:00
decnet
Remove DECnet support from kernel
2023-06-21 15:45:38 +02:00
dns_resolver
keys, dns: Fix size check of V1 server-list header
2024-01-25 14:37:50 -08:00
dsa
net: dsa: tag_sja1105: fix MAC DA patching from meta frames
2023-07-27 08:44:10 +02:00
ethernet
ethernet: Add helper for assigning packet type when dest address does not match device address
2024-05-02 16:23:44 +02:00
ethtool
ethtool: netlink: Add missing ethnl_ops_begin/complete
2024-01-25 14:37:56 -08:00
hsr
hsr: Handle failures in module init
2024-03-26 18:22:03 -04:00
ieee802154
net: ieee802154: fix error return code in dgram_bind()
2022-11-03 23:57:51 +09:00
ife
net: sched: ife: fix potential use-after-free
2024-01-05 15:12:24 +01:00
ipv4
tcp: Use refcount_inc_not_zero() in tcp_twsk_unique().
2024-05-17 11:48:06 +02:00
ipv6
ipv6: fib6_rules: avoid possible NULL dereference in fib6_rule_action()
2024-05-17 11:48:07 +02:00
iucv
net/iucv: fix the allocation size of iucv_path_table array
2024-03-26 18:21:46 -04:00
kcm
net: kcm: fix incorrect parameter validation in the kcm_getsockopt) function
2024-03-26 18:21:54 -04:00
key
net: af_key: fix sadb_x_filter validation
2023-08-26 15:26:51 +02:00
l2tp
net l2tp: drop flow hash on forward
2024-05-17 11:48:00 +02:00
l3mdev
l3mdev: l3mdev_master_upper_ifindex_by_index_rcu should be using netdev_master_upper_dev_get_rcu
2022-04-27 13:53:50 +02:00
lapb
…
llc
llc: call sock_orphan() at release time
2024-02-23 08:42:17 +01:00
mac80211
kcov: Remove kcov include from sched.h and move it to its users.
2024-05-17 11:48:07 +02:00
mac802154
mac802154: fix llsec key resources release in mac802154_llsec_key_del
2024-04-13 12:58:25 +02:00
mpls
net: mpls: fix stale pointer if allocation fails during device rename
2023-02-22 12:55:58 +01:00
mptcp
mptcp: don't account accept() of non-MPC client as fallback to TCP
2024-04-13 12:59:38 +02:00
ncsi
net/ncsi: Fix netlink major/minor version numbers
2024-01-25 14:37:44 -08:00
netfilter
netfilter: nf_tables: honor table dormant flag from netdev release event path
2024-05-02 16:23:42 +02:00
netlabel
calipso: fix memory leak in netlbl_calipso_add_pass()
2024-01-25 14:37:40 -08:00
netlink
netlink: annotate lockless accesses to nlk->max_recvmsg_len
2024-05-25 16:19:06 +02:00
netrom
netrom: Fix data-races around sysctl_net_busy_read
2024-03-15 10:48:17 -04:00
nfc
nfc: nci: Fix uninit-value in nci_dev_up and nci_ntf_packet
2024-04-13 12:59:14 +02:00
nsh
nsh: Restore skb->{protocol,data,mac_header} for outer header in nsh_gso_segment().
2024-05-17 11:48:00 +02:00
openvswitch
net: openvswitch: Fix Use-After-Free in ovs_ct_exit
2024-05-02 16:23:41 +02:00
packet
packet: annotate data-races around ignore_outgoing
2024-03-26 18:22:03 -04:00
phonet
phonet: fix rtm_phonet_notify() skb allocation
2024-05-17 11:48:07 +02:00
psample
psample: Require 'CAP_NET_ADMIN' when joining "packets" group
2023-12-13 18:27:06 +01:00
qrtr
net: qrtr: ns: Return 0 if server port is not present
2024-01-25 14:37:38 -08:00
rds
net/rds: fix possible cp null dereference
2024-04-13 12:59:19 +02:00
rfkill
net: rfkill: gpio: set GPIO direction
2024-01-05 15:12:28 +01:00
rose
net/rose: fix races in rose_kill_by_device()
2024-01-05 15:12:24 +01:00
rxrpc
rxrpc: Fix response to PING RESPONSE ACKs to a dead call
2024-02-23 08:42:20 +01:00
sched
net/sched: act_skbmod: prevent kernel-infoleak
2024-04-13 12:59:26 +02:00
sctp
sctp: update hb timer immediately after users change hb_interval
2023-10-10 21:53:39 +02:00
smc
net/smc: reduce rtnl pressure in smc_pnet_create_pnetids_list()
2024-04-13 12:59:43 +02:00
strparser
…
sunrpc
sunrpc: add a struct rpc_stats arg to rpc_create_args
2024-05-17 11:47:58 +02:00
switchdev
…
tipc
tipc: fix UAF in error path
2024-05-17 11:48:10 +02:00
tls
tls: stop recv() if initial process_rx_list gave us non-DATA
2024-03-01 13:16:51 +01:00
unix
af_unix: Suppress false-positive lockdep splat for spin_lock() in __unix_gc().
2024-05-02 16:23:43 +02:00
vmw_vsock
virtio/vsock: fix logic which reduces credit update messages
2024-01-25 14:37:45 -08:00
wimax
…
wireless
wifi: cfg80211: fix rdev_dump_mpp() arguments order
2024-05-17 11:48:02 +02:00
x25
net/x25: fix incorrect parameter validation in the x25_getsockopt() function
2024-03-26 18:21:54 -04:00
xdp
xsk: validate user input for XDP_{UMEM|COMPLETION}_FILL_RING
2024-05-02 16:23:33 +02:00
xfrm
xfrm: Preserve vlan tags for transport mode software GRO
2024-05-17 11:48:06 +02:00
compat.c
…
devres.c
…
Kconfig
Remove DECnet support from kernel
2023-06-21 15:45:38 +02:00
Makefile
Remove DECnet support from kernel
2023-06-21 15:45:38 +02:00
socket.c
net: Save and restore msg_namelen in sock_sendmsg
2024-01-15 18:48:04 +01:00
sysctl_net.c
…