As pointed out by Chris, with our current approach we are actually limited to S16_MAX * PAGE_SIZE for our size when using the blt to clear pages. Keeping things simple try to fix this by reducing the copy to a sequence of S16_MAX * PAGE_SIZE blocks. Reported-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Matthew Auld <matthew.auld@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> [ickle: hide the details of the engine pool inside emit_vma] Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk> Link: https://patchwork.freedesktop.org/patch/msgid/20190810092945.2762-1-chris@chris-wilson.co.uk
195 lines
4.2 KiB
C
195 lines
4.2 KiB
C
// SPDX-License-Identifier: MIT
|
|
/*
|
|
* Copyright © 2019 Intel Corporation
|
|
*/
|
|
|
|
#include "i915_drv.h"
|
|
#include "gt/intel_context.h"
|
|
#include "gt/intel_engine_pm.h"
|
|
#include "gt/intel_engine_pool.h"
|
|
#include "gt/intel_gt.h"
|
|
#include "i915_gem_clflush.h"
|
|
#include "i915_gem_object_blt.h"
|
|
|
|
struct i915_vma *intel_emit_vma_fill_blt(struct intel_context *ce,
|
|
struct i915_vma *vma,
|
|
u32 value)
|
|
{
|
|
struct drm_i915_private *i915 = ce->vm->i915;
|
|
const u32 block_size = S16_MAX * PAGE_SIZE;
|
|
struct intel_engine_pool_node *pool;
|
|
struct i915_vma *batch;
|
|
u64 offset;
|
|
u64 count;
|
|
u64 rem;
|
|
u32 size;
|
|
u32 *cmd;
|
|
int err;
|
|
|
|
GEM_BUG_ON(intel_engine_is_virtual(ce->engine));
|
|
intel_engine_pm_get(ce->engine);
|
|
|
|
count = div_u64(vma->size, block_size);
|
|
size = (1 + 8 * count) * sizeof(u32);
|
|
size = round_up(size, PAGE_SIZE);
|
|
pool = intel_engine_pool_get(&ce->engine->pool, size);
|
|
if (IS_ERR(pool))
|
|
goto out_pm;
|
|
|
|
cmd = i915_gem_object_pin_map(pool->obj, I915_MAP_WC);
|
|
if (IS_ERR(cmd)) {
|
|
err = PTR_ERR(cmd);
|
|
goto out_put;
|
|
}
|
|
|
|
rem = vma->size;
|
|
offset = vma->node.start;
|
|
|
|
do {
|
|
u32 size = min_t(u64, rem, block_size);
|
|
|
|
GEM_BUG_ON(size >> PAGE_SHIFT > S16_MAX);
|
|
|
|
if (INTEL_GEN(i915) >= 8) {
|
|
*cmd++ = XY_COLOR_BLT_CMD | BLT_WRITE_RGBA | (7 - 2);
|
|
*cmd++ = BLT_DEPTH_32 | BLT_ROP_COLOR_COPY | PAGE_SIZE;
|
|
*cmd++ = 0;
|
|
*cmd++ = size >> PAGE_SHIFT << 16 | PAGE_SIZE / 4;
|
|
*cmd++ = lower_32_bits(offset);
|
|
*cmd++ = upper_32_bits(offset);
|
|
*cmd++ = value;
|
|
} else {
|
|
*cmd++ = XY_COLOR_BLT_CMD | BLT_WRITE_RGBA | (6 - 2);
|
|
*cmd++ = BLT_DEPTH_32 | BLT_ROP_COLOR_COPY | PAGE_SIZE;
|
|
*cmd++ = 0;
|
|
*cmd++ = size >> PAGE_SHIFT << 16 | PAGE_SIZE / 4;
|
|
*cmd++ = offset;
|
|
*cmd++ = value;
|
|
}
|
|
|
|
/* Allow ourselves to be preempted in between blocks. */
|
|
*cmd++ = MI_ARB_CHECK;
|
|
|
|
offset += size;
|
|
rem -= size;
|
|
} while (rem);
|
|
|
|
*cmd = MI_BATCH_BUFFER_END;
|
|
intel_gt_chipset_flush(ce->vm->gt);
|
|
|
|
i915_gem_object_unpin_map(pool->obj);
|
|
|
|
batch = i915_vma_instance(pool->obj, ce->vm, NULL);
|
|
if (IS_ERR(batch)) {
|
|
err = PTR_ERR(batch);
|
|
goto out_put;
|
|
}
|
|
|
|
err = i915_vma_pin(batch, 0, 0, PIN_USER);
|
|
if (unlikely(err))
|
|
goto out_put;
|
|
|
|
batch->private = pool;
|
|
return batch;
|
|
|
|
out_put:
|
|
intel_engine_pool_put(pool);
|
|
out_pm:
|
|
intel_engine_pm_put(ce->engine);
|
|
return ERR_PTR(err);
|
|
}
|
|
|
|
int intel_emit_vma_mark_active(struct i915_vma *vma, struct i915_request *rq)
|
|
{
|
|
int err;
|
|
|
|
i915_vma_lock(vma);
|
|
err = i915_vma_move_to_active(vma, rq, 0);
|
|
i915_vma_unlock(vma);
|
|
if (unlikely(err))
|
|
return err;
|
|
|
|
return intel_engine_pool_mark_active(vma->private, rq);
|
|
}
|
|
|
|
void intel_emit_vma_release(struct intel_context *ce, struct i915_vma *vma)
|
|
{
|
|
i915_vma_unpin(vma);
|
|
intel_engine_pool_put(vma->private);
|
|
intel_engine_pm_put(ce->engine);
|
|
}
|
|
|
|
int i915_gem_object_fill_blt(struct drm_i915_gem_object *obj,
|
|
struct intel_context *ce,
|
|
u32 value)
|
|
{
|
|
struct i915_request *rq;
|
|
struct i915_vma *batch;
|
|
struct i915_vma *vma;
|
|
int err;
|
|
|
|
vma = i915_vma_instance(obj, ce->vm, NULL);
|
|
if (IS_ERR(vma))
|
|
return PTR_ERR(vma);
|
|
|
|
err = i915_vma_pin(vma, 0, 0, PIN_USER);
|
|
if (unlikely(err))
|
|
return err;
|
|
|
|
if (obj->cache_dirty & ~obj->cache_coherent) {
|
|
i915_gem_object_lock(obj);
|
|
i915_gem_clflush_object(obj, 0);
|
|
i915_gem_object_unlock(obj);
|
|
}
|
|
|
|
batch = intel_emit_vma_fill_blt(ce, vma, value);
|
|
if (IS_ERR(batch)) {
|
|
err = PTR_ERR(batch);
|
|
goto out_unpin;
|
|
}
|
|
|
|
rq = intel_context_create_request(ce);
|
|
if (IS_ERR(rq)) {
|
|
err = PTR_ERR(rq);
|
|
goto out_batch;
|
|
}
|
|
|
|
err = intel_emit_vma_mark_active(batch, rq);
|
|
if (unlikely(err))
|
|
goto out_request;
|
|
|
|
err = i915_request_await_object(rq, obj, true);
|
|
if (unlikely(err))
|
|
goto out_request;
|
|
|
|
if (ce->engine->emit_init_breadcrumb) {
|
|
err = ce->engine->emit_init_breadcrumb(rq);
|
|
if (unlikely(err))
|
|
goto out_request;
|
|
}
|
|
|
|
i915_vma_lock(vma);
|
|
err = i915_vma_move_to_active(vma, rq, EXEC_OBJECT_WRITE);
|
|
i915_vma_unlock(vma);
|
|
if (unlikely(err))
|
|
goto out_request;
|
|
|
|
err = ce->engine->emit_bb_start(rq,
|
|
batch->node.start, batch->node.size,
|
|
0);
|
|
out_request:
|
|
if (unlikely(err))
|
|
i915_request_skip(rq, err);
|
|
|
|
i915_request_add(rq);
|
|
out_batch:
|
|
intel_emit_vma_release(ce, batch);
|
|
out_unpin:
|
|
i915_vma_unpin(vma);
|
|
return err;
|
|
}
|
|
|
|
#if IS_ENABLED(CONFIG_DRM_I915_SELFTEST)
|
|
#include "selftests/i915_gem_object_blt.c"
|
|
#endif
|