iv/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
linux/net
History
YueHaibing 77df11dae6 net: dsa: Fix error cleanup path in dsa_init_module 
[ Upstream commit 68be930249d051fd54d3d99156b3dcadcb2a1f9b ]

BUG: unable to handle kernel paging request at ffffffffa01c5430
PGD 3270067 P4D 3270067 PUD 3271063 PMD 230bc5067 PTE 0
Oops: 0000 [#1
CPU: 0 PID: 6159 Comm: modprobe Not tainted 5.1.0+ #33
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.9.3-0-ge2fc41e-prebuilt.qemu-project.org 04/01/2014
RIP: 0010:raw_notifier_chain_register+0x16/0x40
Code: 63 f8 66 90 e9 5d ff ff ff 90 90 90 90 90 90 90 90 90 90 90 55 48 8b 07 48 89 e5 48 85 c0 74 1c 8b 56 10 3b 50 10 7e 07 eb 12 <39> 50 10 7c 0d 48 8d 78 08 48 8b 40 08 48 85 c0 75 ee 48 89 46 08
RSP: 0018:ffffc90001c33c08 EFLAGS: 00010282
RAX: ffffffffa01c5420 RBX: ffffffffa01db420 RCX: 4fcef45928070a8b
RDX: 0000000000000000 RSI: ffffffffa01db420 RDI: ffffffffa01b0068
RBP: ffffc90001c33c08 R08: 000000003e0a33d0 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000094443661 R12: ffff88822c320700
R13: ffff88823109be80 R14: 0000000000000000 R15: ffffc90001c33e78
FS:  00007fab8bd08540(0000) GS:ffff888237a00000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffffffa01c5430 CR3: 00000002297ea000 CR4: 00000000000006f0
Call Trace:
 register_netdevice_notifier+0x43/0x250
 ? 0xffffffffa01e0000
 dsa_slave_register_notifier+0x13/0x70 [dsa_core
 ? 0xffffffffa01e0000
 dsa_init_module+0x2e/0x1000 [dsa_core
 do_one_initcall+0x6c/0x3cc
 ? do_init_module+0x22/0x1f1
 ? rcu_read_lock_sched_held+0x97/0xb0
 ? kmem_cache_alloc_trace+0x325/0x3b0
 do_init_module+0x5b/0x1f1
 load_module+0x1db1/0x2690
 ? m_show+0x1d0/0x1d0
 __do_sys_finit_module+0xc5/0xd0
 __x64_sys_finit_module+0x15/0x20
 do_syscall_64+0x6b/0x1d0
 entry_SYSCALL_64_after_hwframe+0x49/0xbe

Cleanup allocated resourses if there are errors,
otherwise it will trgger memleak.

Fixes: c9eb3e0f8701 ("net: dsa: Add support for learning FDB through notification")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Vivien Didelot <vivien.didelot@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-05-16 19:42:34 +02:00
..
6lowpan
6lowpan: iphc: reset mac_header after decompress to fix panic
2018-10-03 17:00:47 -07:00
9p
9p: do not trust pdu content for stat item size
2019-04-20 09:15:04 +02:00
802
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
8021q
net: fix use-after-free in GRO with ESP
2018-07-22 14:28:44 +02:00
appletalk
appletalk: Fix use-after-free in atalk_proc_exit
2019-04-20 09:15:07 +02:00
atm
net: atm: Fix potential Spectre v1 vulnerabilities
2019-04-27 09:35:33 +02:00
ax25
ax25: fix possible use-after-free
2019-02-23 09:06:44 +01:00
batman-adv
batman-adv: Reduce tt_global hash refcnt only for removed entry
2019-05-08 07:20:47 +02:00
bluetooth
Bluetooth: Align minimum encryption key size for LE and BR/EDR connections
2019-05-10 17:53:15 +02:00
bpf
…
bridge
bridge: Fix error path for kobject_init_and_add()
2019-05-16 19:42:33 +02:00
caif
caif: reduce stack size with KASAN
2019-05-08 07:20:45 +02:00
can
can: bcm: check timer values before ktime conversion
2019-01-31 08:13:46 +01:00
ceph
libceph: wait for latest osdmap in ceph_monc_blacklist_add()
2019-03-27 14:13:51 +09:00
core
fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied
2019-05-16 19:42:33 +02:00
dcb
net: dcb: For wild-card lookups, use priority -1, not 0
2018-09-19 22:43:43 +02:00
dccp
dccp: do not use ipv6 header for ipv4 flow
2019-04-03 06:25:08 +02:00
decnet
dn_getsockoptdecnet: move nf_{get/set}sockopt outside sock lock
2018-02-25 11:07:52 +01:00
dns_resolver
KEYS: DNS: fix parsing multiple options
2018-07-22 14:28:49 +02:00
dsa
net: dsa: Fix error cleanup path in dsa_init_module
2019-05-16 19:42:34 +02:00
ethernet
…
hsr
net/hsr: fix possible crash in add_timer()
2019-03-19 13:13:22 +01:00
ieee802154
ipv6: remove dependency of nf_defrag_ipv6 on ipv6 module
2019-04-27 09:35:40 +02:00
ife
net: sched: ife: check on metadata length
2018-04-29 11:33:13 +02:00
ipv4
ipv4: Fix raw socket lookup for local traffic
2019-05-16 19:42:34 +02:00
ipv6
ipv6: invert flowlabel sharing check in process and user mode
2019-05-08 07:20:44 +02:00
ipx
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
iucv
net/iucv: Free memory obtained by kzalloc
2018-03-31 18:10:41 +02:00
kcm
kcm: switch order of device registration to fix a crash
2019-04-17 08:37:45 +02:00
key
af_key: unconditionally clone on broadcast
2019-03-23 14:35:14 +01:00
l2tp
l2tp: fix infoleak in l2tp_ip6_recvmsg()
2019-03-19 13:13:22 +01:00
l3mdev
…
lapb
…
llc
llc: do not use sk_eat_skb()
2018-12-01 09:42:51 +01:00
mac80211
mac80211: fix memory accounting with A-MSDU aggregation
2019-05-16 19:42:21 +02:00
mac802154
net: mac802154: tx: expand tailroom if necessary
2018-09-09 19:55:52 +02:00
mpls
mpls: Return error for RTA_GATEWAY attribute
2019-03-13 14:03:09 -07:00
ncsi
net/ncsi: Fix length of GVI response packet
2017-10-21 01:56:38 +01:00
netfilter
netfilter: nf_tables: warn when expr implements only one of activate/deactivate
2019-05-16 19:42:30 +02:00
netlabel
netlabel: fix out-of-bounds memory accesses
2019-03-13 14:03:08 -07:00
netlink
genetlink: Fix a memory leak on error path
2019-04-03 06:25:08 +02:00
netrom
netrom: switch to sock timer API
2019-02-06 17:31:32 +01:00
nfc
NFC: nci: Add some bounds checking in nci_hci_cmd_received()
2019-05-16 19:42:32 +02:00
nsh
nsh: set mac len based on inner packet
2018-07-22 14:28:49 +02:00
openvswitch
ipv6: remove dependency of nf_defrag_ipv6 on ipv6 module
2019-04-27 09:35:40 +02:00
packet
packet: validate msg_namelen in send directly
2019-05-08 07:20:44 +02:00
phonet
phonet: fix building with clang
2019-03-23 14:35:16 +01:00
psample
MAINTAINERS: Update Yotam's E-mail
2017-11-01 12:19:03 +09:00
qrtr
net: qrtr: Broadcast messages only from control port
2018-08-24 13:09:13 +02:00
rds
net: rds: exchange of 8K and 1M pool
2019-05-02 09:40:33 +02:00
rfkill
rfkill: gpio: fix memory leak in probe error path
2018-05-16 10:10:26 +02:00
rose
net/rose: fix unbound loop in rose_loopback_timer()
2019-05-02 09:40:34 +02:00
rxrpc
rxrpc: Fix net namespace cleanup
2019-05-08 07:20:44 +02:00
sched
net_sched: fix two more memory leaks in cls_tcindex
2019-05-16 19:42:30 +02:00
sctp
sctp: avoid running the sctp state machine recursively
2019-05-08 07:20:44 +02:00
smc
net/smc: fix TCP fallback socket release
2019-01-09 17:14:46 +01:00
strparser
strparser: Remove early eaten to fix full tcp receive buffer stall
2018-07-22 14:28:47 +02:00
sunrpc
sunrpc: don't mark uninitialised items as VALID.
2019-05-02 09:40:29 +02:00
switchdev
net: switchdev: Remove bridge bypass support from switchdev
2017-08-07 14:48:48 -07:00
tipc
tipc: check link name with right length in tipc_nl_compat_link_set
2019-05-02 09:40:32 +02:00
tls
net/tls: Fixed return value when tls_complete_pending_work() fails
2018-12-05 19:41:11 +01:00
unix
missing barriers in some of unix_sock ->addr and ->path accesses
2019-03-19 13:13:24 +01:00
vmw_vsock
vsock/virtio: fix kernel panic from virtio_transport_reset_no_sock
2019-05-02 09:40:31 +02:00
wimax
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
wireless
nl80211: Add NL80211_FLAG_CLEAR_SKB flag for other NL commands
2019-05-16 19:42:21 +02:00
x25
net/x25: fix a race in x25_bind()
2019-03-19 13:13:23 +01:00
xfrm
xfrm: refine validation of template and selector families
2019-02-15 08:09:13 +01:00
compat.c
sock: Make sock->sk_stamp thread-safe
2019-01-09 17:14:46 +01:00
Kconfig
net: Remove CONFIG_NETFILTER_DEBUG and _ASSERT() macros.
2017-09-04 13:25:20 +02:00
Makefile
License cleanup: add SPDX GPL-2.0 license identifier to files with no license
2017-11-02 11:10:55 +01:00
socket.c
net: socket: set sock->sk to NULL after calling proto_ops::release()
2019-03-13 14:03:09 -07:00
sysctl_net.c
…